From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26B3227F72C for ; Tue, 31 Mar 2026 09:15:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774948559; cv=none; b=BLMUvIW1Ghu6B1Hfrb34GNmvfU7nUjBqRLddckY+AiMLDGQTKwv1+BouMDhuCO7vyPtpj/rUP8rucC5XPeDnlEpGfappQDqYLIrEKs8c08SNDHx13h+8cB05iLBPTbW7kd71RfXi4UrF2gJFUxJRpRbk/6Um99GU3/bRObm9ajs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774948559; c=relaxed/simple; bh=IWT2TecODc4x35H2YiJq9hOwIc6t0CcR9UDNOFGnXdk=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=avZsNWVO56qAN9HefJElJSpKaWhLV+WY0GWfoAZYtdYgs75+JjEvAgDCwlJaMm4GYoO6ViBA6giQIwwYReaSMHi78dEvBGYNoJigP1LmHCqLIUcTZ3LpXQligZBa4UuGHCqNiPpMv/MJcsy6yLnPKAjl4Ca9NAFnf+keIA7rwyE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jFS2Ljxg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GPNj+DgC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jFS2Ljxg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GPNj+DgC" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62V6A6EG1090724 for ; Tue, 31 Mar 2026 09:15:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yDhGoxfJDrPVZ5DvoY6PLLrq2voT5ShRIN2ZQa6XElc=; b=jFS2LjxgLgqDC6rZ KEgMTBykcnw1Otn2OZNBfwKrkh/rk6zd8SrrIlnRm3HDwa6P3fOZfrYkOIwFL3sd f/BZE6G+aoRVZnirNSu+eSLPKJn64NL9KV1k0laznYLEfiTTeS8lG2Sn+2EnNbsa Xt6qm0lLaLn6vc+yilSYgJoPOzXiMPPENZoBUTkH00FI/PxZdaTNX7ma+rJqPrNc l53p8vU0qmjYHxGbEkMmetRh6zk085OTLz3lKcIIEDQdAOuH+YjXD/C+sJjGG1DU ICzwSeBgAUKIjeEywZVGYZQY8t4cyhq9enV8qY0LbW/fC4Sm7IUW5QMfLIDgAvkA ehgmHQ== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7trd3ye2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 31 Mar 2026 09:15:57 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82c613194caso3936865b3a.1 for ; Tue, 31 Mar 2026 02:15:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774948557; x=1775553357; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=yDhGoxfJDrPVZ5DvoY6PLLrq2voT5ShRIN2ZQa6XElc=; b=GPNj+DgCTRr7IOgzwioLQWZk0dfVTqg+5R1V6QRX20QwksJtOE6nrvjk87Guyc8eSp g0VuBEHYWQwQCWr2xjj4efPXZEk9AKmFZCpgrDNB1JWt/UWY0srctTDKcT0RaZJF4nNp g9jOCx5MQ887atWdi0OoFRYFahlxdJGDeNgbKtB6sY6YV1BWeQOGBVP9ZkCX8SXeqNGx XqNdvRwV3NDYYZpPbVmRMSYoWz5QPWTqZ86NXjvwbI1qWyzEKjBx0ikjAjjy0aIVzSxA jn++az0QfcmHhRVee8jO9NmI0HwRVYvhRHEq7oU5omy6NbT6ikEu2V2P996DitoVuOdJ fSQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774948557; x=1775553357; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yDhGoxfJDrPVZ5DvoY6PLLrq2voT5ShRIN2ZQa6XElc=; b=PFU/u+gYiHnWFNQRnrFdfMsAW5IZapfVxJsLFCJzkq9dgV9MHklEgm4RI8lw/VR+3Y 2G5msEjueRg5PUGriChmIwbBRRrFbLAPSdgfdh84zQtAaKf1es1HklkePSEJG4DbMdZB dTCoqsRqEjYmR070PcMZhQUStYyMM4iCrcnE1DhTsq0LImFMBmeQJO7juqYtYCgoTab1 S/vwqwjBP1YRnIIadrgcfG0sv5yf/xf1Og2JksaFeYxyuQPnnOpdGYUSuicmfxtlEyic V3oKmvYVR4JOyHtQ6oEd9sGvX5aYQLixaqX/crnWkr7J57z2Obmc9VJANWyHmRHQKRox INmQ== X-Forwarded-Encrypted: i=1; AJvYcCWhHlygNT3D+kgQiv94ogYbbr0tUWyTZfCIFe9ZD2Pwkzlbsm3n5RNJZb12N7Ll9al+xhp+OSWIDh52dA8=@vger.kernel.org X-Gm-Message-State: AOJu0YxkLNQvm7jaO48IY4VGeeYF6IeA59qADRaSboB1wDT5G2xmeRgz f7RhIeoivHy1vpefY1UrBiNPtsjm6/ez96wcu86HqxbGkHagzIVYeIz0zBCI/+Dztrnn4/Uctar avk/4e9gcyx5DDjof9Amff4A4HP+yVfuSjAuxd3p/gJo8aDmxupiaRThIC5y5SAfid08= X-Gm-Gg: ATEYQzz9ztUvNHAJWyfV1nbf3mMA7G1N4pzxA5B7S0uchiltcPSjjUJEj4yjMqg+gCf /VziPs+rECJN1nclLmolFUEpXqlCVO7Id5L6LEJXOfJG7721RXWzXOCmj4WOUtacFqM+gR+TGZa Ywa0NLKfh2QiS6l9O47Y8/bf0lUvobZC1h+Ulh6OhV1RVU1hSPYat/1itYCKhn9iIF4PfKn8N6a gziJ0x8YRwA/aZCwuo0r8WnG0IulCCQgTfNYznbxjfsua758SGXaI8tvtlNkEXvZVR+W19Dgf1Q oQaVfO3yiDD4AIEeCjlnWlhkMiF5JbJuM1wRphLaP8VWcjFEAhf2bFrbDtInLwjzAgD+Y8LXnJ2 Vp+zzrezdqLnDyAHX5CB2UqcRyJ8Quui3J7ZjPhx47jIm17WoIw== X-Received: by 2002:a05:6a00:3e27:b0:82c:7767:5ba9 with SMTP id d2e1a72fcca58-82c95e5bc7fmr14865151b3a.26.1774948556624; Tue, 31 Mar 2026 02:15:56 -0700 (PDT) X-Received: by 2002:a05:6a00:3e27:b0:82c:7767:5ba9 with SMTP id d2e1a72fcca58-82c95e5bc7fmr14865121b3a.26.1774948556116; Tue, 31 Mar 2026 02:15:56 -0700 (PDT) Received: from [10.217.216.245] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca85d3a8esm10232286b3a.39.2026.03.31.02.15.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 02:15:55 -0700 (PDT) Message-ID: Date: Tue, 31 Mar 2026 14:45:51 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: qcom: videocc-glymur: Constify qcom_cc_desc To: Krzysztof Kozlowski , Bjorn Andersson , Michael Turquette , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260331085521.37337-2-krzysztof.kozlowski@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: <20260331085521.37337-2-krzysztof.kozlowski@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: riR2CDJfj3nLHch9xI0kJicUuOCzaB6- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMxMDA4OCBTYWx0ZWRfX5YFL8pvS8qcx WuQTR/m16avhzemCHfhpBMg7RPs3UUsfBZAQ1fXPwECz1nMKfl/kThMdFgrsvJeyd7MZnIW342m eskpGHwt52L8jqlS+Y9tBGCxGY//TFky2hcHKDV4wY3Ag4PfSJt1Jo0MaRjb2WeXpoRQAjTwRF8 uoUgtT80JQfSyt+w4HoDMQorH/P2BVOOQXuLbPvcSPmy14R8Kocuohhbs9iRSNzvr/jaiuozXC3 d43OeyAqNYgE1JLI4Vah+uJEhA8NlaVMteticBK+SUpXC6xJFvS7vzOnSbc4sR+x9PBatYr7vBo cxF1oJX0RPavpaTDnRdzIBaEiFZUdgc9NzX9u86Yng1yQ5SxvpDLx1H0SdOp42+pfBU+eUwWAzL 3InwV3fnmIGH919vjS3j0NdNU4EPP7zK2uBP4O7QeHmQL51IgA9ztPq6iv38CekkiK/LlEW36Qi VZMPluFIQ+Jc6MkwjmQ== X-Proofpoint-ORIG-GUID: riR2CDJfj3nLHch9xI0kJicUuOCzaB6- X-Authority-Analysis: v=2.4 cv=H8/WAuYi c=1 sm=1 tr=0 ts=69cb90cd cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=u_wVa8N0Y7CGBYMdsxYA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-31_02,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 bulkscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 phishscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603310088 On 3/31/2026 2:25 PM, Krzysztof Kozlowski wrote: > Static 'struct qcom_cc_desc' is not modified by drivers and can be made > const for code safety. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Drivers for SM8750 video cc had the same issue. It would be nice if new > code is being built on top of UPSTREAM code, not downstream. > --- > drivers/clk/qcom/videocc-glymur.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/videocc-glymur.c b/drivers/clk/qcom/videocc-glymur.c > index bb3aae6b8396..ea20605dd1e5 100644 > --- a/drivers/clk/qcom/videocc-glymur.c > +++ b/drivers/clk/qcom/videocc-glymur.c > @@ -495,7 +495,7 @@ static struct qcom_cc_driver_data video_cc_glymur_driver_data = { > .clk_regs_configure = clk_glymur_regs_configure, > }; > > -static struct qcom_cc_desc video_cc_glymur_desc = { > +static const struct qcom_cc_desc video_cc_glymur_desc = { > .config = &video_cc_glymur_regmap_config, > .clks = video_cc_glymur_clocks, > .num_clks = ARRAY_SIZE(video_cc_glymur_clocks), Reviewed-by: Taniya Das -- Thanks, Taniya Das