From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6B51311C2A for ; Tue, 13 Jan 2026 11:09:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768302565; cv=none; b=R48qGeUqBQzAR/eKIhcnBSQvEb61VahzFoWr6oz/qAKdiRBIi91NPrL/gx5/Or9rxO9fNQZBqhTU0leT55Ftdf6/VZKNSySiU3vi06jm6uy0i2aes+JdOwOv8iKdN0Lcw9PEVD9Cdr5PkaOEOOSzeO8BdIRiauMFHFEtBD4iET8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768302565; c=relaxed/simple; bh=cAIsCVijVJdf3eeTC5erwHAcVzUAfcnduBdXGNHCs1E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pNa2DB2JZDntuCJOyAxM4gdzH9bPjTN5ni/kPIkFfwZLPGWk/1AjdZkJStGzKzDe59gM+UAiqO3PJh0HM4XamicVsoOqPO3LveLz13DW0rfX5qAnRSN/DHSS37LkDemtfidrDvZtkLh2uBjiDDmgwK/77/E7bYRN/4d4xHjQHzQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BjytnvjX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V4M8mZaP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BjytnvjX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V4M8mZaP" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60D6n81T2604075 for ; Tue, 13 Jan 2026 11:09:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /QriPXAEoCg1J6fQrwPE4jiHUStR2X6nRraXMO9SHFs=; b=BjytnvjXlLcbUWMn /lDseXZut/XmwPC9HF00k0NihosslTEY7aKAAoKoOPbV9xL1I6G0pK4U7FSTwvXe uMCi8R6M0nUmkfW2Sa8B4J5HwolaIgzLMAhgA0jfIk5joWrAz82pY0ELVD2H3tnI PaDSYjurBnkkNtprD0+iL/YB3yuWeHYmnKe+lYad4hEH5Nb9xytwmjIjZRK5oNb/ I+yVKm/XyqY3swXDJ1CspUUfHUer/ccvKIzoMN/bDEkQ9b5DmfQISj2Ol/CToxTi 1zmup+2u9BHS7fPR9b46o3xk3ipgdwM5vyugBaO6pIo1BlkNBYsLqIWJJxcCgVPF aRbPYQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bn7uytdph-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 13 Jan 2026 11:09:22 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ffc6560f05so17182041cf.3 for ; Tue, 13 Jan 2026 03:09:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768302562; x=1768907362; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/QriPXAEoCg1J6fQrwPE4jiHUStR2X6nRraXMO9SHFs=; b=V4M8mZaPomhEm/xa3FaBeka0e/dP+ESEJUkkm+E6Ww8MuWPTMA/Eb7sRnTraPtmGMd qvXA5ohslmhMaroh4e1fZxDT8s6i8W8fEynuMyYHwHskOoKMABdVSXLYxD9115Wz109M 50mvlSQjXVXFQMbcPzFQIWfKMcQokMHMaUi21n0Kn89n/pUfo5XmValZKJFSzJnxT4u8 8is8cCIUfMi20IjVm/+tplI1XxFvrphqYZy93wae+x70LZ/hvqLQl/Fy1M/VtriVQpal /PCvEZ7qr+dBZb3op4R/A8ETjKLMz2U7pez89T2mJo1RvXYuiTT0LiQrwDELfLKg0UR0 aB7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768302562; x=1768907362; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/QriPXAEoCg1J6fQrwPE4jiHUStR2X6nRraXMO9SHFs=; b=xQQYfqwv2fX89GvhwUaCpmHx18VujI8DYVCcoYKEs9sqdwWzdZX3SQfHKh8kbofRSJ 7znuxOmq2SgJV5volebcdG+w1gaJXTJcGKkDJ2HEdw899UrGhYIZQJwi8ov3MkIFMyIy YLcalF0SFi1wuhRN2uqP6sXxt0Xd6DOMOLEReVOS3WxxeKC9ThVmTuGFhvxJaGgSYW+E Q9UdpU+xL6FHyxcVjoFIDkzOS3Od+bMGmwoQODV7INE3b9uyvq9QmfjBAnAW1+oly9dL DtC/6USOTQJdHVQg/H/fg+2nhFsrn2udWXmeCfr2Dn8oxkzoEYBEVM4n1YjxvPQ5aZoc 2NtQ== X-Gm-Message-State: AOJu0Yxwp6tY0Z4ccFR2B1EStww1cXQZh+PsqfC2ttuB1m510gd9zkmw OHWXw3ZU/35t3esE2AxhDSyE6iqctDagdcVPs4FuCfeoAXxUWX3PjJNYgaM555pUZFRz7gAfm5i v6X30dwamK4vejqzmMzFbNUAgSPXHxENqplQscpdJilCa1qD3csblASEgoQ6g6KXuXfY= X-Gm-Gg: AY/fxX7rk3Llgs6k78KUowgeATRjzVlaNzQhFtTwk8tuQP8WUz8VrdhYGXnNbajzJYL bzT6WTylqyTQ5Qw28qMO9/e6uhS3IW9VX649UE+GxQEUa0IMVGmLjaJCQU+7E/hX1Re4euLro1c SZueLYmr/dfnzCnF+jeED5Ya8jLhYsP/Kw91w5+LP12OkZgGM0NxUUKnsxrE/oOrzCJtFsDSruj qdpCZCk/3dK3jj7jSHC/+q/zhLNydv9cRY+ZH1lybWIPyPruzItIqRNGgEy3UwclpZm2zDG9eKx 8rEl6lQK2oyrbxbnboKh9hDFwWN0c1X/ipaHc6ScFlPekM5BndzZEUijG/Algjy9FIXq7B7BliW McMbFM66zAeDMzrwSoSAbxzQZ3/9NOW9uPJv/nkIME2h0IHwxs1CIz6t9FOD0bTml+ls= X-Received: by 2002:a05:622a:110c:b0:4f4:b372:db38 with SMTP id d75a77b69052e-4ffb49228d5mr242132801cf.5.1768302561614; Tue, 13 Jan 2026 03:09:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IF6337MjTU7AcHaegJA0wueUS4wjvItz665L7mSv3oMtkL95AZzYVlHESIEliD3kp9PgHh1Tw== X-Received: by 2002:a05:622a:110c:b0:4f4:b372:db38 with SMTP id d75a77b69052e-4ffb49228d5mr242132371cf.5.1768302560937; Tue, 13 Jan 2026 03:09:20 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6507bf667fcsm19664879a12.29.2026.01.13.03.09.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 03:09:20 -0800 (PST) Message-ID: Date: Tue, 13 Jan 2026 12:09:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 3/7] qcom-tgu: Add signal priority support To: Songwei Chai , andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, suzuki.poulose@arm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org References: <20260109021141.3778421-1-songwei.chai@oss.qualcomm.com> <20260109021141.3778421-4-songwei.chai@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260109021141.3778421-4-songwei.chai@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: UkSZ8fMkl-xtdXRziArinhVP8DLg0_lB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTEzMDA5NCBTYWx0ZWRfX9CXAL58slKiL 0u7eWHjEhJDUpoo4nSnOR4BiVsfrQHaGRSnaRQvg4Uh4mNakdh5dFeH6qKxZWnMC1eDGxOKEi1T Yo3devXuGk1xEVFpztY15UV1Vue/kovRFek4gtsAeOq+9zKvwVvgEIcggvmrfiil4+2cTbOyDRa E6QpG+YGDqHLhKJ+PBYWCUoCiloEtBXcdFGdOnx51lp8BH664THBFPPRUV2Pc8SIzQBmJeDUDQX dMD8p/KRlnRZeRNIguunUmLPxW9FYFtG2d4oMnyG9ANtpb7YEM6Vd54dJXd04qpKyQpUx9+NnJo PlaKiPFDohczXDWKiCbJWV8FTetjG5vm0/6sy6shZX+oUPYjHyr81DlwwOF+B0XZ5iVPdHlcmlV DDovzR0SSHxLSaFUGnCbbByfSAyeogBLJvABBVMu3Fgd4rxhKZgTVxdmhwmLHrhlOqBS43UhO7O Cz4dFXd0wNR0xlo/hmg== X-Authority-Analysis: v=2.4 cv=bpdBxUai c=1 sm=1 tr=0 ts=696627e2 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=v85vifYcghIHyo4UzKcA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: UkSZ8fMkl-xtdXRziArinhVP8DLg0_lB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-13_02,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 impostorscore=0 clxscore=1015 phishscore=0 spamscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601130094 On 1/9/26 3:11 AM, Songwei Chai wrote: > Like circuit of a Logic analyzer, in TGU, the requirement could be > configured in each step and the trigger will be created once the > requirements are met. Add priority functionality here to sort the > signals into different priorities. The signal which is wanted could > be configured in each step's priority node, the larger number means > the higher priority and the signal with higher priority will be sensed > more preferentially. > > Signed-off-by: Songwei Chai > --- [...] > +static ssize_t tgu_dataset_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t size) > +{ > + struct tgu_drvdata *tgu_drvdata = dev_get_drvdata(dev); > + struct tgu_attribute *tgu_attr = > + container_of(attr, struct tgu_attribute, attr); > + unsigned long val; > + int index; > + > + ret = kstrtoul(buf, 0, &val); > + if (ret) > + return ret; > + > + guard(spinlock)(&tgu_drvdata->lock); > + index = calculate_array_location(tgu_drvdata, tgu_attr->step_index, > + tgu_attr->operation_index, > + tgu_attr->reg_num); > + > + tgu_drvdata->value_table->priority[index] = val; > + return size; Style: some functions have a \n before return, some don't. The former is preferred > +static umode_t tgu_node_visible(struct kobject *kobject, > + struct attribute *attr, > + int n) > +{ > + struct device *dev = kobj_to_dev(kobject); > + struct tgu_drvdata *drvdata = dev_get_drvdata(dev); > + struct device_attribute *dev_attr = > + container_of(attr, struct device_attribute, attr); > + struct tgu_attribute *tgu_attr = > + container_of(dev_attr, struct tgu_attribute, attr); > + int ret = SYSFS_GROUP_INVISIBLE; > + > + if (tgu_attr->step_index < drvdata->max_step) { > + ret = (tgu_attr->reg_num < drvdata->max_reg) ? > + attr->mode : 0; > + } > + return ret; This is very convoluted How about: if (tgu_attr->step_index >= drvdata->max_step) return 0; if (tgu_attr->reg_num >= drvdata->max_reg) return 0; return attr->mode; ? [...] > +static void tgu_set_reg_number(struct tgu_drvdata *drvdata) > +{ > + int num_sense_input; > + int num_reg; > + u32 devid; > + > + devid = readl(drvdata->base + TGU_DEVID); > + > + num_sense_input = TGU_DEVID_SENSE_INPUT(devid); > + if (((num_sense_input * NUMBER_BITS_EACH_SIGNAL) % LENGTH_REGISTER) == 0) > + num_reg = (num_sense_input * NUMBER_BITS_EACH_SIGNAL) / LENGTH_REGISTER; > + else > + num_reg = ((num_sense_input * NUMBER_BITS_EACH_SIGNAL) / LENGTH_REGISTER) + 1; num_reg = base case if (num_sense_input * NUMBER_BITS_EACH_SIGNAL) % LENGTH_REGISTER) num_reg++; ? [...] > @@ -112,6 +250,8 @@ static int tgu_probe(struct amba_device *adev, const struct amba_id *id) > { > struct device *dev = &adev->dev; > struct tgu_drvdata *drvdata; > + size_t priority_size; > + unsigned int *priority; reverse-Christmas-tree would be nice > int ret; > > drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); > @@ -127,12 +267,32 @@ static int tgu_probe(struct amba_device *adev, const struct amba_id *id) > > spin_lock_init(&drvdata->lock); > > + tgu_set_reg_number(drvdata); > + tgu_set_steps(drvdata); > + > ret = sysfs_create_groups(&dev->kobj, tgu_attr_groups); > if (ret) { > dev_err(dev, "failed to create sysfs groups: %d\n", ret); > return ret; > } > > + drvdata->value_table = > + devm_kzalloc(dev, sizeof(*drvdata->value_table), GFP_KERNEL); > + if (!drvdata->value_table) > + return -ENOMEM; > + > + priority_size = MAX_PRIORITY * drvdata->max_reg * > + drvdata->max_step * > + sizeof(*(drvdata->value_table->priority)); > + > + priority = devm_kzalloc(dev, priority_size, GFP_KERNEL); > + > + if (!priority) stray \n above [...] > +#define BMVAL(val, lsb, msb) ((val & GENMASK(msb, lsb)) >> lsb) > +#define TGU_DEVID_SENSE_INPUT(devid_val) ((int) BMVAL(devid_val, 10, 17)) > +#define TGU_DEVID_STEPS(devid_val) ((int)BMVAL(devid_val, 3, 6)) > +#define NUMBER_BITS_EACH_SIGNAL 4 "TGU_BITS_PER_SIGNAL" Konrad