From: James Clark <james.clark@linaro.org>
To: Thomas Richter <tmricht@linux.ibm.com>, Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Kan Liang <kan.liang@linux.intel.com>,
Dapeng Mi <dapeng1.mi@linux.intel.com>,
Chun-Tse Shao <ctshao@google.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] perf test: Add basic callgraph test to record testing
Date: Mon, 30 Jun 2025 10:14:02 +0100 [thread overview]
Message-ID: <f3524574-03a4-491b-98d1-8a384132ec5b@linaro.org> (raw)
In-Reply-To: <898927c3-e85f-4a9a-9374-6fdb49236410@linux.ibm.com>
On 30/06/2025 9:01 am, Thomas Richter wrote:
> On 6/28/25 03:55, Ian Rogers wrote:
>> Give some basic perf record callgraph coverage.
>>
>> Signed-off-by: Ian Rogers <irogers@google.com>
>> ---
>> v2: Pick up s390's needed "--call-graph dwarf" as spotted by James
>> Clark <james.clark@linaro.org>.
>> ---
>> tools/perf/tests/shell/record.sh | 30 ++++++++++++++++++++++++++++++
>> 1 file changed, 30 insertions(+)
>>
>> diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
>> index 2022a4f739be..b1ad24fb3b33 100755
>> --- a/tools/perf/tests/shell/record.sh
>> +++ b/tools/perf/tests/shell/record.sh
>> @@ -12,8 +12,10 @@ shelldir=$(dirname "$0")
>> . "${shelldir}"/lib/perf_has_symbol.sh
>>
>> testsym="test_loop"
>> +testsym2="brstack"
>>
>> skip_test_missing_symbol ${testsym}
>> +skip_test_missing_symbol ${testsym2}
>>
>> err=0
>> perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX)
>> @@ -359,6 +361,33 @@ test_precise_max() {
>> fi
>> }
>>
>> +test_callgraph() {
>> + echo "Callgraph test"
>> +
>> + case $(uname -m)
>> + in s390x)
>> + cmd_flags="--call-graph dwarf -e cpu-clock";;
>> + *)
>> + cmd_flags="-g";;
>> + esac
>> +
>> + if ! perf record -o "${perfdata}" $cmd_flags perf test -w brstack
>> + then
>> + echo "Callgraph test [Failed missing output]"
>> + err=1
>> + return
>> + fi
>> +
>> + if ! perf report -i "${perfdata}" 2>&1 | grep "${testsym2}"
>> + then
>> + echo "Callgraph test [Failed missing symbol]"
>> + err=1
>> + return
>> + fi
>> +
>> + echo "Callgraph test [Success]"
>> +}
>> +
>> # raise the limit of file descriptors to minimum
>> if [[ $default_fd_limit -lt $min_fd_limit ]]; then
>> ulimit -Sn $min_fd_limit
>> @@ -374,6 +403,7 @@ test_uid
>> test_leader_sampling
>> test_topdown_leader_sampling
>> test_precise_max
>> +test_callgraph
>>
>> # restore the default value
>> ulimit -Sn $default_fd_limit
>
> Works ok for s390
>
> Tested-by: Thomas Richter <tmricht@linux.ibm.com>
Reviewed-by: James Clark <james.clark@linaro.org>
next prev parent reply other threads:[~2025-06-30 9:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-28 1:55 Ian Rogers
2025-06-30 8:01 ` Thomas Richter
2025-06-30 9:14 ` James Clark [this message]
2025-07-01 17:55 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3524574-03a4-491b-98d1-8a384132ec5b@linaro.org \
--to=james.clark@linaro.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=ctshao@google.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®