From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DD84C4167D for ; Thu, 14 Dec 2023 11:38:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1444065AbjLNLiQ (ORCPT ); Thu, 14 Dec 2023 06:38:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1444027AbjLNLiN (ORCPT ); Thu, 14 Dec 2023 06:38:13 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 48245B7 for ; Thu, 14 Dec 2023 03:38:20 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9BEF21576; Thu, 14 Dec 2023 03:39:05 -0800 (PST) Received: from [10.1.197.60] (eglon.cambridge.arm.com [10.1.197.60]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8C40D3F738; Thu, 14 Dec 2023 03:38:17 -0800 (PST) Message-ID: Date: Thu, 14 Dec 2023 11:38:16 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v7 19/24] x86/resctrl: Add helpers for system wide mon/alloc capable Content-Language: en-GB To: babu.moger@amd.com, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Fenghua Yu , Reinette Chatre , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com References: <20231025180345.28061-1-james.morse@arm.com> <20231025180345.28061-20-james.morse@arm.com> <5e3cc44f-5492-4dc0-a585-b58caa1e27d4@amd.com> From: James Morse In-Reply-To: <5e3cc44f-5492-4dc0-a585-b58caa1e27d4@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Babu, On 09/11/2023 20:51, Moger, Babu wrote: > Thought you are replacing all rdt_mon_capable with > resctrl_arch_mon_capable. But, you missed few. > > 1 rdtgroup.c rdt_get_tree 2640 if (rdt_mon_capable) > 2 rdtgroup.c mkdir_rdt_prepare 3420 if (rdt_mon_capable) > > Any reason these are not replaced? Nope, These were added in tip, which I rebased on to in order to post this late, but didn't have the time to retest the ~100 other patches (mostly MPAM driver) that sit on top of this. x86 was quite happy without these. (There are too many moving parts!) - thanks for catching these. Thanks, James