From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2CC93542F6 for ; Wed, 17 Jun 2026 06:00:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781676021; cv=none; b=Rjul1diQPo0ebaToLUwQmrH0+X7vw2rhV5O29qvojHi7PxTyNrGUcdAV1qkaOC9mB/kIIZBFA7701jHuouSXC4lscLyzrzmrLycsSIaQGdeIKuZqJzSOGHj3x8qfb+Arr1zWpQWksu/SidHdDcpRPYsNZqXKcFhcFQe0SWBnkLQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781676021; c=relaxed/simple; bh=EPp3+y8U+wDZQ2t1aRvjrkpD6kQKVPXuQaessSYJEI8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZjyOw4uaY3g9IOpUBXTSS3DRJvHZ/eGtD38zd3ZObR/MhjDau/TxHrWjJZCkKjzQFiYjSByZexs3YeqL/nblVntKfCy726JDrkPk2aS7uGXJzwlunGrDNtkr0fQKNCP4xv36OBYMuNSWw+GhjQKTGC9bzYGKEmBRSErEqGw9Dng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=N28g7lww; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N28g7lww" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-3967717c951so66276241fa.1 for ; Tue, 16 Jun 2026 23:00:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781676018; x=1782280818; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Cs8qvTgnQoJy3gVauu2STPsPcaY4YlG12CSyBpLnw6c=; b=N28g7lwwNTFg3zxmJaMzTd1gATH4cDPQQoNU6PVBmYcdPfBQ1btepBTCkzhXiprZ5q juW2WL289paaLRE8WgHcSXxyyk0mjaU8hWIplqwq0xJJR3dQ+uP7WXdek8Z6q0Z5kfVp qkx+uhheZUrpF6D4cpjQAcOYm0pMgF0JOa4BdkS00lzm7UYSNlMdAtg1lFHuQSwyVphk ylkcImz8sfgiuRApbIPadmPYTH2lvLTQrqQcuTmskcm2IupO7NSdcYnx8e7vuZ4q/ypF lhaN3aAnAjwTuEIS8M6mLL1nGNnme4+xZG3FUfdXbQ4lOIr9rWJXuQCE5BO3xFvWh3sC ySyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781676018; x=1782280818; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Cs8qvTgnQoJy3gVauu2STPsPcaY4YlG12CSyBpLnw6c=; b=N8YXA6B0TG+1x1+znEOp0jprrl+Uob3nGIw0ymKg8c9Ks5JyVXhnhX30TUGVg4l1tE AmfXoOYh4jVj1pFpH78+Dziu6pe2/3j0KKEUMYn0MxJSSRuiQfUE52FpxjYmvHcB7LZL LGwW7F+p3E1xmdIW2qdtR1v7klJfNmKke+6KeDI8+x+w63gHIc29Q3yvnONppQlYYbNF /AK/3vhDDRqXDvIS+6+r4rD4an40EXUr5AeWJaHaSEnadE6g3nZ/VHSZQkyIFK1eQwB/ Plv2PJKzR2qZeOdDedm1NcrnzKQISZjCf9gB1zWVtNItbDRaU68Y3po1Pn6+askEVUh6 VTkw== X-Forwarded-Encrypted: i=1; AFNElJ+3Jui7oI4mcsAYkZ2vr6C199JDlwHHqRJmbqE9erZu0Dcv7tbTb1HsOZdqM7gZffb9X3dhi00WSUFQkx4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzwu15ydwhZfCyi4kKCWHF9UOSp5yGmnrLlsXLRdn124jzPzt6G hINo1P+Fy9E5KzijBCxRe64jcU8Bdbh8GJ1E9YNB3Q9LM0vp4P/iJutN X-Gm-Gg: Acq92OF/45A3IeqXsuJpRd1pVnX46aWWjXAFPXCghOJFfQIXNk6D6hvQHN4Z7fSMfNx Pdi/KCBCYSWjmD9gufaj/R8zzpWsXKU/wEBA78f8Ceu4RQY8jQ8X+uvGhddd+01AiYV7BqqY1Ua LM6M2JbFsHzyn2cNOeRPYsdp/8Qm4ZoQTdMHxCM7qnPOY9qaKIyvHZg61n7BJkl1ZrHHYaFWMWW UVcfqo98Lfaoi24MIO2lrTWgncMiJ+GzdiUQUTjXs2QojC1mhdDqKCrAnZdWDgEcUshNxG5M4kP eLqzr9xORC4TE/BICo1LlgJhA74A0F9fZ8Jusrfy/eLwE7NkqjVBYWPeFaZzsM2sS5boMHWVUhg i0QWt5WDJ6G3AV+2ak6alYcj6uI8rBvrNLgxEcfeNuPKMMK8Jga1SdqPuoGJadneOtr1T9FZ6XD 0rBjQfSxzGv+HewT2tCnyKJjOYWOszuDbnpfLhaRxSwB33XB2hGZUWbTMizYcckFQM0m70TQ== X-Received: by 2002:a05:651c:2124:b0:38b:e464:f047 with SMTP id 38308e7fff4ca-39969ad94b1mr4694531fa.12.1781676015350; Tue, 16 Jun 2026 23:00:15 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3995c04d8b2sm12250531fa.2.2026.06.16.23.00.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2026 23:00:13 -0700 (PDT) Message-ID: Date: Wed, 17 Jun 2026 09:00:12 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] hwmon: adm1275: Support module auto-loading To: Guenter Roeck , Matti Vaittinen , Matti Vaittinen Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet , Shuah Khan , Wensheng Wang , Ashish Yadav , Kim Seer Paller , Cedric Encarnacion , Chris Packham , Yuxi Wang , Charles Hsu , ChiShih Tsai , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <634e76680ed93e58ebeb35db080138b791cb6c27.1781591132.git.mazziesaccount@gmail.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 16/06/2026 17:04, Guenter Roeck wrote: > On 6/15/26 23:47, Matti Vaittinen wrote: >> From: Matti Vaittinen >> >> Populating the spi_device_id -table is not enough to make the >> driver module automatically load when device-tree node for the bd12780 >> is parsed at boot. >> >> Adding the of_device_id tables causes the driver module to be >> automatically load at boot. Testing has been done with rather old Debian >> system. >> >> When inspecting the generated module-aliases with the insmod, following >> entries seem to be the difference: >> >> alias:          of:N*T*Crohm,bd12780C* >> alias:          of:N*T*Crohm,bd12780 >> >> I suspect these are required for the module loading to work. >> >> Signed-off-by: Matti Vaittinen >> >> --- >> >> I did not add of_device_ids for other supported ICs as I can't verify it >> doesn't cause side-effects. Please let me know if you think those IDs >> should be added as well. I would be glad if I got more educated opinion >> on adding the of-IDs :) (I can squash this to 3/7 and 6/7 in next >> revision, and add own patch for adding of-IDs for other ICs if >> required). >> > > I don't know what those side effects might be. I am much more concerned > about side effects of having some of the devices in adm1275_of_match > and some in adm1275_id. So, yes, please add a patch to provide > adm1275_of_match for all chips supported by the driver. It's nice to have an opinion on this as I was really unsure what is the right way forward. Thanks for all the help this far. I'll do that in v2. Yours, -- Matti -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~