From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C08B136327 for ; Sat, 18 Jan 2025 18:36:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737225379; cv=none; b=S9NLC2x9abr2eqEB2w6XStcVB42WUUb5WpohNMRlVOMPMTdgKMF61/1fDAuAnMVC+6pUkfFGDDDpSVXnWOz3S6jcEBskctS92W6hPVEzRFFudK3ngtS3W9FFCWHy/hDqyeVlB+H54kkWuUNOc4ZT5c08TYuMNXjblf1scrTjmB4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737225379; c=relaxed/simple; bh=Kz0N/occUxpLWo7EEQmrvFR0SJnkG2w6KJ87U3HWRWw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bM2r3aACoI8c6XTL7O/wHxidw3MsyquZHI1KBW17wqPpJ1QCZ0TEMxtMBVRB3obZS9bBnuyOrzSQNsy/OsOYCpBs49TEw0l7gbJizd9IHyFoh8eEgNUCf1i9PF32ssWCaY/9It3ZwPN1qynKAtrT8LzzhFmxvVgKOysRjWXlpLk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DRIDJuy/; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DRIDJuy/" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-21669fd5c7cso57732985ad.3 for ; Sat, 18 Jan 2025 10:36:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737225375; x=1737830175; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=OUkm3O5VXWECV1np9LBwbOA6nOJYwN4Zdwn94mUHEP4=; b=DRIDJuy/H+PosBEN2UMgpfUJslYVRXKOOGFPMUAG0UezgB5mlplzyZ+TIfoE4n6g0p PjoX/QpM7eE9Y6t3oFaSFNM3A0xuGWEKaYEgUsPl916YGNGnHSDF+HHyUellAdTopiAD 79gqyaloHZNkZbLmCGIo1QfLNZcYYkpNywQfR9CQYeVEXwNNsf4Ata8T3GWPL+TIWwSO l29vFQMIeuh1mMkwu59IZOn5lRFpN0rTe499K5Hw5Xfv8Cno9UHguj3lQ06Rr+LHtqjq u3M/8gnfBAAL4JqtU2F52rN9THMAmjH0+Gu54pVDWDrLw1qjB7VnyJYgWmJPMl3c34mv AOPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737225375; x=1737830175; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OUkm3O5VXWECV1np9LBwbOA6nOJYwN4Zdwn94mUHEP4=; b=eokDsEn2tnpfoWO2mFt+fBNzEK3m2OYq/HA5EaCpfO3FOGY9T6RaL/orgIQKzKxI0H j+tABcdmDKFjcslDDYCcTC1IIpxKnrrRNDqijjnDqLiv2918/Eyl4Js07VjS4CzTSzzo ybBHMsihCYFd2vf3bimmBYl3UkdgVKY98krxZvdXkMBATuY4zaVkfr2C8GGIOMbjqxsL /OQ5e/fGAgqPNYS3X565ifJU+IFeiG0GdeWp3kJXVvZz7hf38xEgVUlxwOalfEAGejZC EvxPTu9d1jqP287OiOJ2cx+XyaxYlvBz00Iy0KEoQ2id2jOFnLjholJ9lPLn67t5ho7H E21w== X-Forwarded-Encrypted: i=1; AJvYcCX5+HdYf1FC7J/Ps8Azusk4Sp3yFwP8QZjXwa1MYYMIZfOwpS3AduzXpgNfZ+jLQWeQJ92fJ4wnP7NwA0A=@vger.kernel.org X-Gm-Message-State: AOJu0Ywb3K16AAKOY8O6V9lNLp1zPYRP/+jgiIJ/FqQgVT05v8eteB93 ofIjNoGZo/TO3+b4BMQzXTaaYgDyIb4bGxexrO0cbS2BFwUUcMrU X-Gm-Gg: ASbGnctRe8sFSZFGWu6UjBBrRDxLTIuse3MdMBPQBSkSyYRDRpVUTGuB87oauNNFeGl dcUqtbVA9JGETD5Q1iyeKEGUHuqCHyNqx/Hu/wEfr7rf73wsT//aXK2911Ah9v3I0ziM848HG3Q KZPqGS7cuJeJci2v7bgUtaPvF75ZfhzZnwN0ewFU3UY9pDpT00OM/ErTjBD8fp3PhwvdR6P+RVp huLTCuQ3RrMYcBeZhnzF4SVSywuY8J5UEulaYoywBKZaG0gdoJqRCerQXb8V8QWTFF1RdCkjzpj C7xyl07I9eUndoAZQpD3y50ASHDd5q06wJYFoGAsi3o= X-Google-Smtp-Source: AGHT+IFvMhIT4I2uX6aqedtotZAF2akdbJK4GaZEVBZp4csKoRpE4kZS3khyNby3PJHrspUSH/Y53w== X-Received: by 2002:a05:6a20:2589:b0:1e1:9662:a6f2 with SMTP id adf61e73a8af0-1eb215ded51mr12411392637.35.1737225375282; Sat, 18 Jan 2025 10:36:15 -0800 (PST) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72dab813295sm4012547b3a.46.2025.01.18.10.36.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 18 Jan 2025 10:36:14 -0800 (PST) Sender: Guenter Roeck Message-ID: Date: Sat, 18 Jan 2025 10:36:11 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Buiild error in i915/xe To: David Laight Cc: David Laight , Linus Torvalds , 'Arnd Bergmann' , "'linux-kernel@vger.kernel.org'" , 'Jens Axboe' , 'Matthew Wilcox' , 'Christoph Hellwig' , 'Andrew Morton' , 'Andy Shevchenko' , 'Dan Carpenter' , "'Jason A . Donenfeld'" , "'pedro.falcato@gmail.com'" , 'Mateusz Guzik' , "'linux-mm@kvack.org'" , 'Lorenzo Stoakes' , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, David Airlie , Simona Vetter , Jani Nikula , Rodrigo Vivi References: <34d53778977747f19cce2abb287bb3e6@AcuMS.aculab.com> <20250118170959.3aa56f4d@pumpkin> <29ef57a1-e4dd-4d5d-8726-f1f79c698b66@roeck-us.net> <20250118180916.433bb73c@pumpkin> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <20250118180916.433bb73c@pumpkin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/18/25 10:09, David Laight wrote: > On Sat, 18 Jan 2025 09:49:21 -0800 > Guenter Roeck wrote: > >> On Sat, Jan 18, 2025 at 05:09:59PM +0000, David Laight wrote: >>> On Sat, 18 Jan 2025 08:13:06 -0800 >>> Guenter Roeck wrote: >>> >>>> Hi, >>>> >>>> On Mon, Nov 18, 2024 at 07:13:31PM +0000, David Laight wrote: >>>>> Use BUILD_BUG_ON_MSG(statically_true(ulo > uhi), ...) for the sanity >>>>> check of the bounds in clamp(). >>>>> Gives better error coverage and one less expansion of the arguments. >>>>> >>>>> Signed-off-by: David Laight >>>> >>>> This patch triggers a build error when trying to build parisc:allmodconfig. >>>> See error message and bisect log below. >>>> >>>> I don't think there is anything wrong with the patch. The underlying >>>> problem seems to be that parisc:allmodconfig enables CONFIG_DRM_XE which >>>> tries to build the affected file even though CONFIG_DRM_I915 is not >>>> enabled/supported on parisc. >>> >>> This has appeared before. >>> Any idea which inlined copy of scale() is causing the problem. >>> On the face of it they all look ok. >>> >>> If you can reproduce it maybe try commenting out some of the calls. >>> >> >> See diff below. All three changes are needed. >> No idea why the compiler would know that the values are invalid. > > Maybe it isn't even an inlining issue. > Perhaps that compiler just doesn't like the function ? > What happens without the 'static' (and an extra prototype)? > You mean like that ? -static u32 scale(u32 source_val, + +u32 scale(u32 source_val, + u32 source_min, u32 source_max, + u32 target_min, u32 target_max); + +u32 scale(u32 source_val, u32 source_min, u32 source_max, u32 target_min, u32 target_max) It doesn't help. Worse, after that change the error is still reported even with the #if 0 elsewhere. Guenter