From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98DC123D2B2 for ; Thu, 11 Dec 2025 21:50:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765489842; cv=none; b=rJe9LkbnTuX+MgIfZm5yOeJTu8EWEXcMpZj1Q/pQ7o/iU7p5kbe0t1SKAYZlmyF3AOzG4DfNEWn0J5WlRzB/qpdDyDgQqlUy+cx8l6ibf7U9naaBztwnejmf8dtK45id3bMYzb/TK9pluONDw+ZYVSDg1DDVCvrcvcf7pMFfJzM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765489842; c=relaxed/simple; bh=Jhk+Al8qS1UMPn9v1MerQ6tcNUNRQ5Zq0h4sP4RFvFQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gmGML8nN+yqyCJxpb7PgQkcc1Wts1FW0MCuxT81fSBIGQ1P9j4byFM3StT5MG6xVyIka4GxtpCW3RwKysohP+pGeOVthgqTPheHgUiMhtW/QOovwO71F6n2NVQtLj19ZmWkZIvWC7EO1ZYNZpylCmU1nht+VWymx7FbDkqlnTCY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Uj+nR9XV; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Uj+nR9XV" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-42e33956e76so310630f8f.3 for ; Thu, 11 Dec 2025 13:50:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765489839; x=1766094639; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=a82PJh8eepOGqCmiI3UPw9D1KL6YO5opvGRf2gsxoCk=; b=Uj+nR9XVZi5eM7ox0u9xPVBT9x5Vmw/jz2pPwK7tyR0XwCHlE2poIsJ8B/rnphGPc2 IAx1vl7m6F/9y866ojgiNO2myiwIr3yZzB4Mm5ICxBkMUOB8OImIIIol8q5eUF6eEnQP /461o7Bpftq2u1XB9NEqv+4pKpxHFPqaAHS3erSQCAO4NFkWSrpJOVYusQUxJzBFA2cN adPcv7fzpoqW1467ElauX5tRnaeHH+UDe8oFotJnFCtUERUUHcMtzXxv6ZGwHdwj/aw/ asrINcBw6BrRHgyWeZtqBLznrkehpTqAUdutw88VYMs0io0vjK72F3xiwZS/f0HdPwuG aJfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765489839; x=1766094639; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a82PJh8eepOGqCmiI3UPw9D1KL6YO5opvGRf2gsxoCk=; b=LTktAm6UKl/sx5fCoGf/obzTAtqNA65Cv87c2rpLgto3+7JDaC3/+toHm+I6QsaTz5 XcMzE2SfP/dffml82PGroXZQQyUKSwfc2fnNNYP8IbNAFxBNLnM/uD0esoKHS9axr0DB 6o6Zj9zOFgMMND+FsCxkO8iclrA5AewYjCl7kjg3A7MdHZ/XrrX6fCs9Ihrvkqb+AQrB audYLZStkHxVLam5nfy0llM0nlG/Z/YSB+PgLr7h/ALVlsDKvvBnWzPz342ZKp+ldN4L IrV9tJ6xdqFTxWZVicWYJOvYiUy2q5h5i7SYD6pSJ3qPtP35DNHrPR1+BK3kRinAyUMS bJmA== X-Forwarded-Encrypted: i=1; AJvYcCUXgSGGpZJz745DwxZCebPEjvcHbDaLngA4Wu0LZP0rO/1HK9kBbs5GzoPZZj+iWtdJ1NKUpyc0hg0SqRc=@vger.kernel.org X-Gm-Message-State: AOJu0YxEfLqnRiFbF6tK2PdlHwE3BlstCfNqyLQPCbJW0S9YqtDQ2Hks p4zGqFPhY5kIyHN7cdBetzF2LbeUu1uqgn0dveCge+JVdF6nWVjEhEfN X-Gm-Gg: AY/fxX4IniLkjGOpH9lOSp/836PWIiY3zMZp1PCKus29J4KE1RI0x7pEcKrgqIpfugu 7Z+Z/1R3eUow8w5MsdoFwqa+lRbRNJExixcXtKuTQ+nH1jyOxBglcfyQJh5Uc8mqwrf7pUiMaTp fWvPccml42AuJ6AEr5lMBTnsUAgNdacMvZF1XuCWdNWbp1lmmdOxFC/E8vS3KXqJ+j16gweBOvv tUkp5iWMdzr97FYWLEgjm6U11MMcZafATBlR1cOZRtaxdX4nNrhtqdP7LLiTKSqZCiUnkJgXWMA AF9OgQODKwR0v+YX/2g+ywef0m68adPM686aQyoTPouRWrZtI9KjGRdbA1M951XnH5YZnNZmP6m dlHz5uA5Fg08G7NflUewtbgG5qYU8BlkMevuZ0aK/0R7gMVm9672Bh2/RGkHc3jzrExZ8VrVWTU D5KkBkS9gG2ekelcsdw4jgzhqc X-Google-Smtp-Source: AGHT+IGSpJWsBGIsYUG6VjxkL05+z9cNzHzqC4vUarsrFQWSwtTrv3gNIa2zRBVmWI/2d0ZM6095eA== X-Received: by 2002:a5d:5f95:0:b0:42b:549d:cdfd with SMTP id ffacd0b85a97d-42fa39d92d2mr7526757f8f.2.1765489838697; Thu, 11 Dec 2025 13:50:38 -0800 (PST) Received: from ?IPV6:2001:871:22a:3342::1ad1? ([2001:871:22a:3342::1ad1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42fa8b85f81sm8941712f8f.21.2025.12.11.13.50.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Dec 2025 13:50:38 -0800 (PST) Message-ID: Date: Thu, 11 Dec 2025 22:50:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/11] rust: pin-init: internal: remove proc-macro[2] and quote workarounds To: Gary Guo , Miguel Ojeda , Boqun Feng , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Fiona Behrens Cc: rust-for-linux@vger.kernel.org, Tamir Duberstein , linux-kernel@vger.kernel.org References: <20251211185805.2835633-1-gary@kernel.org> <20251211185805.2835633-2-gary@kernel.org> Content-Language: en-US, de-DE From: Christian Schrefl In-Reply-To: <20251211185805.2835633-2-gary@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Gary, On 12/11/25 7:56 PM, Gary Guo wrote: > From: Benno Lossin > > The kernel only had the `proc-macro` library available, whereas the > user-space version also used `proc-macro2` and `quote`. Now both are > available to the kernel, making it possible to remove the workarounds. > > Signed-off-by: Benno Lossin > Co-developed-by: Gary Guo > Signed-off-by: Gary Guo > --- Its good to see some workarounds/hacks get removed! Overall seems fine, but maybe the imports should be changed to the multiline kernel style? Anyways: Reviewed-by: Christian Schrefl Cheers Christian