From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f12.google.com (mail-pz2-f12.google.com [74.125.228.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83B5A41B8CA for ; Wed, 23 Sep 2026 12:54:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790168099; cv=none; b=CO8/jMf42K3aKYWuqVsK+wVm5/ghMopXjq1sMRSzzwJ2Q9YeuyzWJ47K4EpxtoDQ/vJZ5NCqbZ/+loUOABjeAVk1eK+GmTa/4OQPxyoF7wJ/uMCujEYHfItHTBPgDwZdpALzKkK5weMDLrsmRfCoJ2ue4Iu5qD/k1BDEjMVrmSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790168099; c=relaxed/simple; bh=Zx/zASwng4eAeMQ6fde2oAI+Yd/IiVV1LTddyWl4HxI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NkcDWUQjCE2l9KjcdbBqJIKOTII5jQuQWyJcz/6Gp5P9YqVMguhrupVkVS83S6VaBG2zwvEc5c0/d4KahZq7FPs/+f31h0IHQMIjz2sOTPUpsSzcMZwvTuu3p5UUg6iARYKl7vC3zOOzqWMvDbGSMLgkCBeYojfA5/5jydm9xHE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=htUUN0QD; arc=none smtp.client-ip=74.125.228.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="htUUN0QD" Received: by mail-pz2-f12.google.com with SMTP id 41be03b00d2f7-cc1cebad4adso434238a12.1 for ; Wed, 23 Sep 2026 05:54:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790168081; x=1790772881; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=eH1PKGunx3MHUYSKzUdOGw8jJHjZCuP1JnlKtRRHVto=; b=htUUN0QDk0OQXl2r657SZf1pC2Sp8Rh6/WLFNZbwuKsd7lZ0qieVpmMtz665ZvWCLu 4/ACE+xurWqsMVjwMcyQbbkavRsil1NeyZbicsR4Du66UOGUMJ95J+3Qx+xQUxU2jGRO D8l7UXwSqMACKU5x11kVd5mYYbK01fdLGFhUwkPevDZNG2IR0sU7ejQdSICUsw2yIg/m eW/rDHRKjmClUlbP8BuDmopxy3Qi+8inn9xWqTt0ZMQHm1+FlGu0KWsEQubZhDsa53lP AiIgIj7hDM0fiTbJbgPqs8/TL5eq5/2VKGN8lgQOAPPv6GGR4ZnCMYDEWlcT0tdLJSHS hDfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790168081; x=1790772881; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=eH1PKGunx3MHUYSKzUdOGw8jJHjZCuP1JnlKtRRHVto=; b=mDswPCciBEbnzgRPM/WExG744dHaMKc4GQhPFQ7iVlnhkQU4C4j4d3dEO1gBxO8w5L NCxFs0G80E9JvVfFE0qV1ZvB39oRw29Z25uJV2IUHriqwg+G/DQUmvbV5QvDM8z0X4b+ O4D3XzxxZSXbABO4iQ7sOWB9YIfZ7LGOZztXYG/uGuFfUOEhMP0r/mzbS77r9ulnWfDf LmI5FScxs2+kPqT3eYJtfQQ9kP2Wy5KbyjB0LxLp+OW6G/gyNzr+ESoZUFe7jEB2HuQp nVu7VngCZb2CH5cfc1YrEW4NoKSG/kPn7ZVTxj1Sw8hP0YB9aKZ0RmCkzqA5djHBLryX uoRQ== X-Forwarded-Encrypted: i=1; AKwUvBzflwg7bypfKPMABAVeY4evtzpW6WI0KEoLrBBZZ77Pu6xZqbGQy0W9sOUFRJXxf4uf40BpoBvNX63cfTc=@vger.kernel.org X-Gm-Message-State: AFuF++mK2AWfiQN+pAJKxzPzln2rVs9wKX2EBokX+qAGV6pZerpKkZJv KD/8TULOxU9Pe/GWRHrdO2FLB4NjQx73KI4JFzm7GzQ4KurAswQ5cjmW X-Gm-Gg: AYBFou3e87XoijRk+ZX59uRXCb/CpkT7We5GYxk0UWRnuVIOQUTYQHgiO4wZu7hBr5a AxqX0AKwduGz6pLSnNhlA8hDV/DsmldHktf7aXES2Vq9kHsD80BrJTLJ8LVs5RReVpVPRACqp01 dT2kGPXTeYMUpvSUNgLdrcZD3eV8/4ag1ifCLEglvCn0FKc4OR/LZn33gOUvOuPUD0Wkk0bAwLv DQ4zsySTE3p3bRg/fWN5GVKClbl61RzNxFxfurL39VQNCMa+qnuMLJpiKi6X0cULUS375a94B4I ksslHIUriCaG08BWJ53Kf8guH9Om3XH8yuj4mofTwa16hTn1jQLu4uMga9qSBNrYhQNrxwxK7Rn HmalC1TOXnuJVJkFC7G8fgLn6RoLsrXBF4S8R0J0Vb+tnI8TfVXuZQoKljLCsWOZalMtwZeKO0e Y5spxnngsKbDkY+jbbHtCEoxac+7UH8qpmDFZAeLpl5O1cEOQicslzpAqY9WhWOMKXwyA41BCk/ vZfkj6YdBAzY0m67ts= X-Received: by 2002:a05:6a21:8287:b0:3dd:85a8:4c56 with SMTP id adf61e73a8af0-3ddf7e52ca6mr2589348637.29.1790168080565; Wed, 23 Sep 2026 05:54:40 -0700 (PDT) Received: from [100.125.248.95] ([124.70.231.46]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cc75f3d67bbsm1007180a12.13.2026.09.23.05.54.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Sep 2026 05:54:40 -0700 (PDT) Message-ID: Date: Wed, 23 Sep 2026 20:54:18 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ext4: Fix sparse warning in extents kunit test when EXT4_KUNIT_TESTS=m To: Ojaswin Mujoo , linux-ext4@vger.kernel.org Cc: Theodore Ts'o , Ritesh Harjani , Zhang Yi , linux-kernel@vger.kernel.org, Baokun Li , Jan Kara , Ye Bin , kernel test robot References: <20260922135808.3371159-1-ojaswin@linux.ibm.com> Content-Language: en-US From: Zhang Yi In-Reply-To: <20260922135808.3371159-1-ojaswin@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/22/2026 9:58 PM, Ojaswin Mujoo wrote: > When kunit tests are compiled as modules, the extents kunit test emits > a sparse warning: > >>> fs/ext4/extents-test.c:59:3: sparse: sparse: symbol 'k_ctx' was not > declared. Should it be static? > > Fix this by declaring it as static. > > Fixes: cb1e0c1d1fad ("ext4: kunit tests for extent splitting and conversion") > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202609221900.Pgwrcp41-lkp@intel.com/ Looks good to me. Reviewed-by: Zhang Yi > --- > fs/ext4/extents-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/extents-test.c b/fs/ext4/extents-test.c > index bd7795a82607..9669b2197fca 100644 > --- a/fs/ext4/extents-test.c > +++ b/fs/ext4/extents-test.c > @@ -48,7 +48,7 @@ > #define EXT_DATA_LBLK 10 > #define EXT_DATA_LEN 3 > > -struct kunit_ctx { > +static struct kunit_ctx { > /* > * Ext4 inode which has only 1 unwrit extent > */