From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5286823AC for ; Mon, 23 Sep 2024 16:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727108636; cv=none; b=AtXRJho94ZMGLTqcxw1jXCxWukkWoSI7iSWGS6IB2U94lyYa4h6cqgZwCWqU3jop7u0PIrpcGAKbFgSWvkT0YI68yZfcxROPEr/qHysmlcUlP0IM7ojbxfDDPMRCppLxqkmcnyf95//67vdWyqmEiDyhprm0ECfEBcc+2hxvpzw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727108636; c=relaxed/simple; bh=pH27xsWg8G6SeVBeYa7PVys3VaHWxE1d41xvTvXeHKo=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=s2c5lNaKrmkj664nwADpVWRaWRdENURw+bpXMiAcHnkDmq1gBq/ISatPaYk9pOjMtU56qVv8GSs7I2uHO1WUyWQX9UnnrFb268g2MdA1aVdb281bqHlzDTX7wB6VIK4AczkUYU269VY3obRtULWwDpM35fBES5eFY5cQZOpzAq4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ikYrWzMs; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ikYrWzMs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727108633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xhibzVfiT6YYguU9Zn+WLSPcbkXuFS0jVV+8r0H5PLk=; b=ikYrWzMsuUXlPeEnF5elObCthX2Rgo4gmlZ5IRUBFoOWpmvGSV6alg+kcAAy1y254+f5IU YP2yY8CJa6b0dEf5/Whq5Csw4x5lFEhsYA9hj+jebH2OjzhaPVaLIVhRPoyxKdUJd/DMA8 /9n1jPxFQvuAiquqBUY2bxRv3eXEXyI= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-103-FwcDhSAjMgSM_7iG9pniLg-1; Mon, 23 Sep 2024 12:23:52 -0400 X-MC-Unique: FwcDhSAjMgSM_7iG9pniLg-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4585419487aso76885071cf.3 for ; Mon, 23 Sep 2024 09:23:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727108632; x=1727713432; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xhibzVfiT6YYguU9Zn+WLSPcbkXuFS0jVV+8r0H5PLk=; b=TkPP7rr69oSRgoiHt0FsAhgzjwNd8vAK1ScjdNcRisTfybbea17PBoSm6ZiRAroftq 7qIuJNZ0LWzw6dxGhCtxJfcuhTLFOrZGVN9zbs7w7ETHqNd5MxHYIrlP2xpqbo+ZMnu1 sjUUwJfKubbYvzKn2SumlC/DQc29bJ41Xj9RycyJOdPCHj+TYObrf0RfzWwncsP0g+6k zteOlJ7s9BWc8keEmY2AoUOiWrFMq3vwfV9boatdXxyzYlkUbqcoVlkmyuboQhawj9TQ jZcuC2Zqa9EjGVCkvt7OnBVEG9606Lm/e5l9+mSTqrnnebyYuqsc9J1cDwad+Ya3zAqV pdUA== X-Forwarded-Encrypted: i=1; AJvYcCUke73l+1XN5W4YGBaCrxdyoKhCsEOWdWxLgfbJuRuL9vMhGl5MztLeRctkKu63S5nkLrwKBzKzpBJihBU=@vger.kernel.org X-Gm-Message-State: AOJu0YxLUKWOss6RFB0LjaW0d0uN1b1/EGfxI9T78IwvEmEqSdTDk+KA ZsZYWPIAK/GQ8lET2qNeiMiGLri/SdLU/uB+sChwneD3iY4duGQuzhnv77RJThcDFunL2QWI4V0 Kih2wNG+KcZIib1+IeEHpDyaz+89vOJk5/ioKjCcy6ZvL4qlYOg4T5PSFZFz8uA== X-Received: by 2002:ac8:7f93:0:b0:453:140c:ac60 with SMTP id d75a77b69052e-45b20573d99mr163550441cf.50.1727108631831; Mon, 23 Sep 2024 09:23:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGah0EW43b/NHrbQUHUF4y0RDzvpRR/zN6gzuhBBTaJwGY/I9BmVKauh4Q+cH5LrDtlepgfjA== X-Received: by 2002:ac8:7f93:0:b0:453:140c:ac60 with SMTP id d75a77b69052e-45b20573d99mr163550181cf.50.1727108631502; Mon, 23 Sep 2024 09:23:51 -0700 (PDT) Received: from starship ([2607:fea8:fc01:760d:6adb:55ff:feaa:b156]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-45b178751casm48368671cf.22.2024.09.23.09.23.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Sep 2024 09:23:50 -0700 (PDT) Message-ID: Subject: Re: [PATCH v3 0/4] Allow AVIC's IPI virtualization to be optional From: Maxim Levitsky To: Sean Christopherson Cc: kvm@vger.kernel.org, Will Deacon , linux-kernel@vger.kernel.org, Borislav Petkov , Dave Hansen , x86@kernel.org, Ingo Molnar , "H. Peter Anvin" , Thomas Gleixner , Joerg Roedel , Suravee Suthikulpanit , Robin Murphy , iommu@lists.linux.dev, Paolo Bonzini Date: Mon, 23 Sep 2024 12:23:48 -0400 In-Reply-To: References: <20231002115723.175344-1-mlevitsk@redhat.com> <1d6044e0d71cd95c477e319d7e47819eee61a8fc.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Mon, 2024-09-23 at 02:29 -0700, Sean Christopherson wrote: > On Tue, Sep 10, 2024, Maxim Levitsky wrote: > > On Wed, 2023-10-04 at 16:14 +0300, Maxim Levitsky wrote: > > > У пн, 2023-10-02 у 12:21 -0700, Sean Christopherson пише: > > > > On Mon, Oct 02, 2023, Maxim Levitsky wrote: > > > > > Hi! > > > > > > > > > > This patch allows AVIC's ICR emulation to be optional and thus allows > > > > > to workaround AVIC's errata #1235 by disabling this portion of the feature. > > > > > > > > > > This is v3 of my patch series 'AVIC bugfixes and workarounds' including > > > > > review feedback. > > > > > > > > Please respond to my idea[*] instead of sending more patches. > > > > > > Hi, > > > > > > For the v2 of the patch I was already on the fence if to do it this way or to refactor > > > the code, and back when I posted it, I decided still to avoid the refactoring. > > > > > > However, your idea of rewriting this patch, while it does change less lines of code, > > > is even less obvious and consequently required you to write even longer comment to > > > justify it which is not a good sign. > > > > > > In particular I don't want someone to find out later, and in the hard way that sometimes > > > real physid table is accessed, and sometimes a fake copy of it is. > > > > > > So I decided to fix the root cause by not reading the physid table back, > > > which made the code cleaner, and even with the workaround the code > > > IMHO is still simpler than it was before. > > > > > > About the added 'vcpu->loaded' variable, I added it also because it is something that is > > > long overdue to be added, I remember that in IPIv code there was also a need for this, > > > and probalby more places in KVM can be refactored to take advantage of it, > > > instead of various hacks. > > > > > > I did adopt your idea of using 'enable_ipiv', although I am still not 100% sure that this > > > is more readable than 'avic_zen2_workaround'. > > > > Hi! > > > > Sean, can you take another look at this patch series? > > Ya, it might take a week or two, but it's on my todo list. > Thanks in advance! Best regards, Maxim Levitsky