From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Douglas Anderson <dianders@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: swboyd@chromium.org, Bhupesh Sharma <bhupesh.sharma@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "arm64: dts: qcom: Fix 'reg-names' for sdhci nodes"
Date: Thu, 7 Jul 2022 09:02:30 +0200 [thread overview]
Message-ID: <f373aeeb-7f8e-5eb4-9230-4cb924032e5e@linaro.org> (raw)
In-Reply-To: <20220706144706.1.I48f35820bf3670d54940110462555c2d0a6d5eb2@changeid>
On 06/07/2022 23:47, Douglas Anderson wrote:
> This reverts commit afcbe252e9c19161e4d4c95f33faaf592f1de086.
>
> The commit in question caused my sc7280-herobrine-herobrine-r1 board
> not to boot anymore. This shouldn't be too surprising since the driver
> is relying on the name "cqhci".
Thanks for finding the issue.
>
> The issue seems to be that someone decided to change the names of
> things when the binding moved from .txt to .yaml. We should go back to
> the names that the bindings have historically specified.
>
> For some history, see commit d3392339cae9 ("mmc: cqhci: Update cqhci
> memory ioresource name") and commit d79100c91ae5 ("dt-bindings: mmc:
> sdhci-msm: Add CQE reg map").
>
> Fixes: afcbe252e9c1 ("arm64: dts: qcom: Fix 'reg-names' for sdhci nodes")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
> This is just a straight revert. That presumably means we'll get some
> "make dtbs_check" warnings that were fixed by the commit being
> reverted. I'll leave it to the authors of the original commit to
> adjust the bindings to fix those.
Thanks for the report. I can help here.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-07-07 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 21:47 Douglas Anderson
2022-07-07 2:46 ` Bjorn Andersson
2022-07-07 7:02 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f373aeeb-7f8e-5eb4-9230-4cb924032e5e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®