From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751366AbdJEOs7 (ORCPT ); Thu, 5 Oct 2017 10:48:59 -0400 Received: from mail-eopbgr00044.outbound.protection.outlook.com ([40.107.0.44]:55360 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751043AbdJEOs6 (ORCPT ); Thu, 5 Oct 2017 10:48:58 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=ed.blake@sondrel.com; Subject: Re: [PATCH 4/4] irqchip: imgpdc: Pass on peripheral mask/unmasks to the parent To: James Hogan Cc: tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, linux-kernel@vger.kernel.org References: <1506938159-466-1-git-send-email-ed.blake@sondrel.com> <1506938159-466-5-git-send-email-ed.blake@sondrel.com> <20171004140302.GG25320@jhogan-linux.le.imgtec.org> From: Ed Blake Message-ID: Date: Thu, 5 Oct 2017 15:48:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171004140302.GG25320@jhogan-linux.le.imgtec.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [195.88.9.101] X-ClientProxiedBy: AM4PR0701CA0004.eurprd07.prod.outlook.com (2603:10a6:200:42::14) To AM4P191MB0002.EURP191.PROD.OUTLOOK.COM (2603:10a6:200:64::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e3086963-743b-49e1-2cb8-08d50c003401 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:AM4P191MB0002; X-Microsoft-Exchange-Diagnostics: 1;AM4P191MB0002;3:dgnPnfzZgKRhjHzzHL7ituFUhKm9YMNvtR5iV7qOQNZ61u+qhWj4HvKi0Uz3TTqTxBtDwSPhGRm3+vtNg7e9xoMQNrr3p5Pl6uGpY/4sD3l+jrDVvs05ancjH7HhtwuBPE+76tR/KpBdnQgoWIvKcGx9AXU9dZQcpdG/UD+QGqiDcZ9KvoR4HTW15TdvvjUHPjNhUEZ9I1D7Nihmx2C35weCTms52wOjP4C7bP2ydVzN7zBATHrwPw8xLGv5vrTB;25:OXYZVBJ7c9uYtZyG4T62pQkcNFnN1h/DLdYzm1w4g7oxpnMqOy9jZdpn1ejqeUReScgwCQJpDcsZk4/eJqhn35MNxXuAdTBmZTwFKuukSm2shHL620JlNx7IMPkK0kt+Eq/US6yyQ6L1W0vvUGObxWhaRoyoomEQ/lPPyBh0lSPzQMqlqiU6d23723/AJhQaHobv0YeblMAR57aulhwQI4D7HmbWYVCm7Sy2qqu1hcOblrKP5tr2NVSNrHL6EpAARsx1OxrLb+TByzo27N9GV4EgfTFeIktcEDMc/9mbEJMzK6Z2dU1ge+qqBbhG9lfZ6KDS1+xDK8VSZlvkFBH0yA==;31:6vOJ15VM7sf/KaEcjawrHA07Dp80mWJW7pYqnq6CHb/EUiXDdtwWOqgN8Pa1+5tP87GJoM1Rj0N0oYx341AuovxvtHct8gLGvprFVsIxFNQRH+06+yGlv4Zvym7781xbfO8Z1t12D92qVuNNsBma9nI+qELYzuMK4QjB5lTDBhqhyUVrs1SX1nALEpUA7T9X3piKtnlbqnBJnNmP1oefUk+Yq4hjtov3Q8aa4fsaptE= X-MS-TrafficTypeDiagnostic: AM4P191MB0002: X-Microsoft-Exchange-Diagnostics: 1;AM4P191MB0002;20:ocWQB7IZTbIskR7hR8hjxKBuOYfX03AWEAO0k1GTeAVGxxp/tat4qG5XtNRV6xGQ/7orvSpd3OB4ZfQ5XHzOwCAEEMpoq/DCA4P6at1NHAYwZlaPPurqaUwTSOvn4BoFCMoHhKH71SVqWcB0ssZnhWIAi9B+V8ZCWnnSM0XyErokWsV0i2SIrx1ttSX7rFDvpYmvfIonk8U+vuW0mBCWiSvLdzec5UF+KChTyBnLxoSrhZ5UQiLbtEAkGaWKfPDz;4:C4wbaBpJyHqTmeatLKAI99ibt9eFrhOwfBURDJpHHBKm4lZKzfAKd/3s4q2GlloA1ASSlPVy41Xq9mtvlr+jnwqsh5ncBG4U+R9RplFQ3TrsXMUm8ajBc3D2NgX5lQe8cZXuEhD9fktXLnn7BH3KE+NF0gxUqXvZQh9dSfTsUTNsPbENbU5qj+wzfPVC0z/lFBkT2veq+PfqI0bTAdtNW2ZDEq65LxcMzkHk44OcegdCWi5OwxkC2g0AMh0DjYTX X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(100000703101)(100105400095)(3002001)(93006095)(93001095)(6041248)(20161123558100)(20161123562025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM4P191MB0002;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM4P191MB0002; X-Forefront-PRVS: 04519BA941 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(39830400002)(376002)(346002)(24454002)(199003)(189002)(8676002)(81166006)(5660300001)(86362001)(81156014)(16526018)(478600001)(77096006)(83506001)(65826007)(6486002)(2870700001)(106356001)(36756003)(25786009)(8936002)(64126003)(31686004)(76176999)(54356999)(50986999)(105586002)(33646002)(31696002)(3846002)(6116002)(68736007)(53546010)(6246003)(101416001)(305945005)(58126008)(50466002)(316002)(16576012)(2950100002)(6916009)(23676002)(65806001)(47776003)(53936002)(66066001)(4326008)(65956001)(97736004)(189998001)(7736002)(229853002)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM4P191MB0002;H:[10.40.8.170];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTRQMTkxTUIwMDAyOzIzOmdWeWxkNjJ6dEdUUVdIK2pENTVsNTlJSVJV?= =?utf-8?B?VmRJYmZBcDJlYkcvUFRNRVVFQXd4bWswd1hFMytDRkdWQ1R4UjN1SHBUZkgy?= =?utf-8?B?WnFEMWIrOEE3MzM0TjdVUEN6cEVlalIxOGlwMG5xbFRaTE9tenlYekIxQUtR?= =?utf-8?B?SUZBZzh5bnpld1l5QkRKQVVlcWE2UFVVUVVqVVQ5MEhXZ0MyS3pRWml3djZ1?= =?utf-8?B?WjE1T0ZzUklTemlwQkZDZzduanJmRDJhRmJnR2dSUEhWUnhjd1RERGIyWDlD?= =?utf-8?B?TUt1OVNuemhqVWVZbmJTME1yUnBIbFdWekgyRlh1eDF1VUQ3VUFLUHBqMi9q?= =?utf-8?B?YlNVVDFpVzZwOVFvTHlhOENsVjNXS2I2WTVTMFUrdTJnNzZYYVYyWm96c1Aw?= =?utf-8?B?WFV3WXkwSUw1TnkyZ0pITlU2bHdXSVZTSkd2M3QvM2NQNDRub0VTMVFUcCty?= =?utf-8?B?WS9HOThXMStCdW53dWdDdUNhUVJzUFVyOG45SGt5TmhXbDY3MWsrelMzbC9z?= =?utf-8?B?YzlCZytYeThoT2cwKzBDU1AvVk9NQjd4RHR6ZjN4OE4rLzI2NVV4Z3ZzR05v?= =?utf-8?B?SzVUejRvZENndjhZdFdwa2RaMVZjMEdzOHFLZDZXUEdGTFlwSlhHQ2l1RlQx?= =?utf-8?B?TUl1RHRJY2xBdnM0K2FaWjdCalBBa1pJTGlVcE0wcm9oS3hjQ1B2VGxKWWow?= =?utf-8?B?ZTRCMllNWU5wVm41MTkyL1gzNklFSllxVFQ3ZWhVY3JEdjMxcVEzdW9GRWhk?= =?utf-8?B?Z216dkJLZlNrQXNualhvTnYrRXlUZWlkZjQvMXU1a2phYmZrREJhSURXRFJh?= =?utf-8?B?OFZrVHdoeitnOS81ckdFa0JwWXV6cDFNMzJQTWxreXJvL0thM2Z3eVlpeHJR?= =?utf-8?B?RmhiUGFCNmRndmkyQ3hpTndzYm0yL3Arc05oRm5Ddkx6Qk9vQnZOYUxNUkkz?= =?utf-8?B?SDBhWThvdFFhTzJHTjZMRVpHTVhCbFBrWWFvbm1MUzNJU0p1b2VmU1JNRTUv?= =?utf-8?B?blcxU2cxN3kwZXBiVUtOd3Y1TGNJemw3emRsZkQ5RUlWd3BjRzN5dnFxMGhr?= =?utf-8?B?R0VNZ3hUNVdrVDdCWDhqZkFESklCdkUwY0hnZjVIZ3YraXdCUWk5ZEM3bkxK?= =?utf-8?B?QXNnOXd2ek9KN2g3Mk00bzVSbjJkUHc5WDRBcmR3TGVQeEtYVmZrcVcyWnNz?= =?utf-8?B?bVNmdk5Ra3dRWHFjSC9nenJEd2ZlUU5jb0p3NFBPNW4wWDdCY2VxelF4alBl?= =?utf-8?B?MHVKRE01dERLa1g2UkdwWWtKblBYZVlNUjVLNUNJYlJjanZ3TTJUdkFaMllD?= =?utf-8?B?cHpMMWlFVDhCL2VDbDVTOWZWeDZKZXZjajRBQzAydWltVVRXVEozNm1GTVpH?= =?utf-8?B?dmIyMFdscFYvbXVMZHZBTkpUSzdKK3F6cmVMRXZDV09HR1dHWGZoYVE0Q2Iy?= =?utf-8?B?UWQzaUZjL3QySGFaSHVwb1VaQUp3Mnh1R0tzWVBmQWQya1hiei9tOVExTUFU?= =?utf-8?B?allBZWluRmV3VGFiaUl1MmlXdnJ4SU0zakhkZVVnaUtJT2t4N3p4R2NZZXUx?= =?utf-8?B?elA4NlZ6TEJodkRUcmRIWlc2dkpMdkRhbW4zL2MrUVJ5RkR3QXlHYW5WN01u?= =?utf-8?B?di9PVlBLUjRqellMSnlqWVZESmJsdk96cmg4T1MrYVQ0eCtqczNEUC9HK0xv?= =?utf-8?B?d0R4V2hPT2NpRzlXYWcxWGZXZkIvRldOZlhuS1puU0JKNnhXTFBjRTJlTUhQ?= =?utf-8?Q?gDbmYkbhezGMTJgFsup7HVNU85+1NKbMzUIpM=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM4P191MB0002;6:WXSLec6DswRyLCHmkmUO6IcfLL+rdBXyRXxKYxHhvzvrEhxoV+RugvoXhjjfdl0Lt/hwYS+5Txs6bbhO9Bx3xb5LRo7EwdqSzMWrGu9HK5gaaiOusM8nAZ0FMuN9OSljWhepd7gvnZ1T7o1XJpAhGU2jG0JGeD2yWqkscPNpHTGNEZYxyBNBxVEsva2gtPERu+10dKHJnoOKIDY939aUwxZaM7tO4jeDL9xBl/G/BgkrkjCmpqtF+pmFv04yy7gSw3PCUynwf1KbFAEjb8vV9Wt1FwiU9vU6uwXdhoCNbg8vafJqHx63nKcnUiPVq2rjHSY35vTCGOHg3LYc/neVoA==;5:829zxR6wtBYb0wqE9MXMNiZ9u/68DslK4rqRl6J2MuhKxNGTIX7P5tA6SDJy1ZnRdQ6onUCz/W7s06PEu9gry+tNdGAoHNUrI80omiVbmiapNVMLLL4+pKWZVjKMMVbkfnjKiT8CYk+B1vU+IQUAsA==;24:W9MfB5yvBTA6LDDdRj2GeASxhwLNj/Q7rCVVg59MQ4mzdBqoZw2aGKJhl36Xpr7JECc0JQpRbODBoBjLQw4ML6u16KpkbOSYvNw8szuB/pE=;7:ikQ3xreWPMpKUyPumKQuLYTPovPRgvgSkodA4s7XfxFxSX4TDcGZvXcIehPQVY/cSJpAAiPdMXPiLtdlTT5Y8df5NHk+C/i8sibhljFNrkI4haiQvmqN7AZ9/S1/WpV6ZaPXdLQZxGd2O1ntCbD8aPNBR9tsQi0uPLHdU3wBIP7qzS7fIn+YISMURU/xNzvSdo+FCTUSKEpF/84U0md7L1E/bw8cIgfy6aOD2Z4QwBc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sondrel.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2017 14:48:55.3099 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4faa3872-698e-4896-80ec-148b916cb1ba X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4P191MB0002 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/10/17 15:03, James Hogan wrote: > Hi Ed, > > On Mon, Oct 02, 2017 at 10:55:59AM +0100, Ed Blake wrote: >> Pass on peripheral (RTC/IR/WD) irq masks and unmasks to the parent >> interrupt controller, as well as setting / clearing the relevant bits >> in the IRQ_ROUTE register. >> >> Clearing bits in the IRQ_ROUTE register will prevent future interrupts >> from being passed on to the parent, but won't mask an existing >> interrupt which has already made it to the parent. > Is it an edge or level sensitive interrupt from the PDC? It's level triggered. > I'm a little rusty on the IRQ subsystem TBH, but if edge sensitive I > would have expected the parent interrupt to be acked/cleared by the > parent handler. > > And if level sensitive I would have expected the deasserted parent > interrupt to be masked by the parent handler, and immediately cleared > upon rerouting. > > Maybe you can clarify whats going on here. I'm not sure how this is supposed to work, but the issue seems to be that without this patch the parent irq isn't being masked.  This is causing the parent handler (MIPS GIC in this case) to be called continuously.  This leads to the PDC irq being masked each time, but not the parent irq.  This is the callstack:     "irq-imgpdc.c"::perip_irq_mask     mask_ack_irq     handle_level_irq     generic_handle_irq_desc     generic_handle_irq     generic_handle_irq_desc     generic_handle_irq     gic_handle_shared_int     gic_handle_local_int     "irq-mips-gic.c"::gic_irq_dispatch     generic_handle_irq_desc     generic_handle_irq     do_IRQ     plat_irq_dispatch() Ed.