From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6E45C0015E for ; Fri, 4 Aug 2023 02:20:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233044AbjHDCUr (ORCPT ); Thu, 3 Aug 2023 22:20:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233470AbjHDCU0 (ORCPT ); Thu, 3 Aug 2023 22:20:26 -0400 Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2DF744B0 for ; Thu, 3 Aug 2023 19:20:23 -0700 (PDT) Received: by mail-qv1-xf2e.google.com with SMTP id 6a1803df08f44-63d30554eefso9564846d6.3 for ; Thu, 03 Aug 2023 19:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1691115623; x=1691720423; h=in-reply-to:references:subject:cc:to:from:message-id:date:from:to :cc:subject:date:message-id:reply-to; bh=WCtKRV7b+epJAAEXM2TZFXGiCSj243meGoK8CGC4Js4=; b=DlPXRmHvBtbIVEg/TQL4KDpt1sq7TYTm38bx3KiI6PY+OzFa7r2re2OmLFeR+rFEJG oHopXyMDnpSNps8cMOD64hN2pOb6JYsVtVslAyFQokUsjrKkF+tGk/TJON8GObDRyP9i M3KTKFLDpvKNnyWqez4x3OhjWN3R5+OK6C3j0N2TjS4tbKBfTiZuVAufTPleupn6FURD tCNrSMzpSlMhzXvGodq6FBnJmTj8lTixDhrmRjRUHmYDsKHLIcxT37r0KiZnaT8setNC TaQNfcMbpGgjhaSfFtPrZ/lUE00NoNAUe2X7aZwnrgYfJXYCeknVdTRb8xI6dgvWJRkJ /K8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691115623; x=1691720423; h=in-reply-to:references:subject:cc:to:from:message-id:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WCtKRV7b+epJAAEXM2TZFXGiCSj243meGoK8CGC4Js4=; b=YQJjgekBvEUs3omvKEhUWC5u2Jv46j4cvdVMeFzbe9kRXIHltzLj5/5DrlvhNtlsMW AIx7kI9nNN1jX4qHuDmJG2IZXTEvFvZ+c/NF8Z4K7xYI7rdwny2qrtL0EKghO31FWVhH I1uWdPi3YC0+JxW9uPXXzUB4UYLaVWqMOXGolQsv0m841GD0Po4gC4di/yOlurrdHg13 x+NOeA7zoohJ84tK3cC/TF7lI6W6r1HTPY1juXbcxHkIZof7kni+T7TlE83VGs9ibbtQ tHb28mmzlkT1ypxccJgQ3/bQMdvG0Xt0kurvdmVCEgszedjpVlyc176E31rgkwz6NZ/y ZLgg== X-Gm-Message-State: AOJu0Yy6iLQKP5W9CrLOV9Ngg0Sl+JNpDS/Rvrs9mN2SWGUJyh8VYnUo xzj2uKLGwpQKEHSsQFKf8Dnq X-Google-Smtp-Source: AGHT+IH+7NG8bzD2w66luBoKir2wyDLXvKAHHE9GAHJjXSenmZo2cvAXXITlkdxkqabvs9MWAZ7QHw== X-Received: by 2002:a0c:e38f:0:b0:63d:2fa3:441f with SMTP id a15-20020a0ce38f000000b0063d2fa3441fmr421199qvl.11.1691115622724; Thu, 03 Aug 2023 19:20:22 -0700 (PDT) Received: from localhost ([70.22.175.108]) by smtp.gmail.com with ESMTPSA id l9-20020a0ce089000000b0063d5a7871d4sm325603qvk.78.2023.08.03.19.20.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Aug 2023 19:20:22 -0700 (PDT) Date: Thu, 03 Aug 2023 22:20:22 -0400 Message-ID: From: Paul Moore To: =?UTF-8?q?Christian=20G=C3=B6ttsche?= , selinux@vger.kernel.org Cc: Stephen Smalley , Eric Paris , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 7/9] selinux: avoid implicit conversions in selinuxfs code References: <20230728155501.39632-6-cgzones@googlemail.com> In-Reply-To: <20230728155501.39632-6-cgzones@googlemail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jul 28, 2023 =?UTF-8?q?Christian=20G=C3=B6ttsche?= wrote: > > Use umode_t as parameter type for sel_make_inode(), which assigns the > value to the member i_mode of struct inode. > > Use identical type for loop iterator. > > Signed-off-by: Christian Göttsche > --- > v2: avoid declarations in init-clauses of for loops > --- > security/selinux/selinuxfs.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c > index b969e87fd870..7d7931d1758e 100644 > --- a/security/selinux/selinuxfs.c > +++ b/security/selinux/selinuxfs.c ... > @@ -1623,7 +1622,7 @@ static int sel_make_avc_files(struct dentry *dir) > #endif > }; > > - for (i = 0; i < ARRAY_SIZE(files); i++) { > + for (u32 i = 0; i < ARRAY_SIZE(files); i++) { No initializers in the for-loop ;) Also, how did you decide 'i' should be a u32? > struct inode *inode; > struct dentry *dentry; > > @@ -1649,7 +1648,7 @@ static int sel_make_ss_files(struct dentry *dir) > { > struct super_block *sb = dir->d_sb; > struct selinux_fs_info *fsi = sb->s_fs_info; > - int i; > + u32 i; Same as above, why u32? > static const struct tree_descr files[] = { > { "sidtab_hash_stats", &sel_sidtab_hash_stats_ops, S_IRUGO }, > }; > @@ -1700,7 +1699,7 @@ static const struct file_operations sel_initcon_ops = { > > static int sel_make_initcon_files(struct dentry *dir) > { > - int i; > + u32 i; Again, why u32? > for (i = 1; i <= SECINITSID_NUM; i++) { > struct inode *inode; > -- > 2.40.1 -- paul-moore.com