From: Florian Fainelli <f.fainelli@gmail.com>
To: Sieng Piaw Liew <liew.s.piaw@gmail.com>,
davem@davemloft.net, kuba@kernel.org
Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] bcm63xx_enet: fix sporadic kernel panic
Date: Sun, 21 Feb 2021 21:05:50 -0800 [thread overview]
Message-ID: <f382effd-a4f5-b860-c521-5728f1f6200d@gmail.com> (raw)
In-Reply-To: <20210222013530.1356-1-liew.s.piaw@gmail.com>
On 2/21/2021 17:35, Sieng Piaw Liew wrote:
> In ndo_stop functions, netdev_completed_queue() is called during forced
> tx reclaim, after netdev_reset_queue(). This may trigger kernel panic if
> there is any tx skb left.
>
> This patch moves netdev_reset_queue() to after tx reclaim, so BQL can
> complete successfully then reset.
>
> Signed-off-by: Sieng Piaw Liew <liew.s.piaw@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Fixes: 4c59b0f5543d ("bcm63xx_enet: add BQL support")
--
Florian
next prev parent reply other threads:[~2021-02-22 5:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 1:35 Sieng Piaw Liew
2021-02-22 5:05 ` Florian Fainelli [this message]
2021-02-23 20:16 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f382effd-a4f5-b860-c521-5728f1f6200d@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=liew.s.piaw@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®