From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F0E8310784 for ; Wed, 22 Jul 2026 13:38:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784727503; cv=none; b=psqYrJrx3Cd3DAoNoPmov8UgpAnZwNg6UndFqu8+NQIZXmf9K2f4DDJ89cNt2nnKdU38j6C7MtSnUzwh3T1RnTFjMlNvIHFRdwVfzhbwWK0qZ4cwuchz2oCmP+4evp/oEi91h1zL7iIGq0zBOhvsdu7sOVvJM5EP5iacr0jkxiE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784727503; c=relaxed/simple; bh=Tn4zmq2o9A4/NAroW01ut1DtvvZJ3tnPOffipBKBe2Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QLb3rGPXXwq50XeWie6cxfMGL88w41Zn9NS7jd/WCBT2ecO0HsCewifGVLQabXZsIPia/4tUJWFdN0LWuyfrmkkUTaNZrpK1LB8x7Vz5KAPHIf/trcXTmBTh/noRYML2x5He1WkdRQ8PfKU61YLOaBB9yLmxcu54jo6rVZA7fUc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kqE6IwFh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hJk2/uWh; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kqE6IwFh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hJk2/uWh" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66MDWUPu1027039 for ; Wed, 22 Jul 2026 13:38:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2l3UPMiH4BMjDVBQXY9WDYnPDDLaNtRsBeyRv5rmKZ4=; b=kqE6IwFhwLt8xaS8 uFN2hqohGlBHEeDOLzkUJR0/fBwzxJy6qye3Yq715iXb+72l1ZT0fgHjRm/abXxa 8GAYkV72G4Ow/eqPl9u/Qk1d5CCDkwiM9iJo8CebjECRPzr22eImqmstSRx9Og77 rOEj9bAnK4zBaDHbFt7d+A3vApPxTB8iB7SX1pmSHzPWUETByQr9XGTeLh26hpPZ xlkMSeF9wCVLfehXZa3Fb5zeZpRvJLq6b8OkEkMLE0nfRunxCsP6pu5gPwF8IY1C RhthE1UW7kNQlm8IkovmLQM3bkrIEZb+Afb35/J5neUihZ+Q/XZNNgOEGDh5XnY9 KvLQeA== Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fjt7998b2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Jul 2026 13:38:20 +0000 (GMT) Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-7eb89852728so8350978a34.3 for ; Wed, 22 Jul 2026 06:38:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784727500; x=1785332300; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2l3UPMiH4BMjDVBQXY9WDYnPDDLaNtRsBeyRv5rmKZ4=; b=hJk2/uWhL/2mKhO52NaoqqpHKTuXDIdtjX8cfC0fmhGBGM5WMrtufXUvwCS4xAsuUK GnbaYxrTEiKudNUPCXMTzOuhHXjTeMyUIr+B0bBe8LMmofO+X8X6pT3ZoFehZDg3gj+Z WkC4cJnb6c6EQAw+DgWgjmc8RDyGFmDb9ShO8F9s/XAzuMTxyp5xMVFrct6f0a82WAEF ZlA8OmQHIOConbsNEKKQUPAHXyZR6d4wuTtmJL7sMWmNaNTrgScc1iT1pbiyv1fhUzN7 poPStKqZWqo01trBBykdJNnO/2fDKTZ7RVPeYOpBqjR0qTvNzDk1DTY6Yl8oucrKGFTD 88wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784727500; x=1785332300; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2l3UPMiH4BMjDVBQXY9WDYnPDDLaNtRsBeyRv5rmKZ4=; b=G6Uk7wsN101+NKSRIPCwTdm9PnVwyD36rxZNp8RMTU2ydZRd6r0m9ApYjko6D03AQr 8uJZ5a1E2P3yYvV88HRqkRzOpNWgZylJQOwOnafQiIbfKNXt9kbRh7XFAlCnM5Tzsccs InO54XmJ/Bw1V25LcRUy6EwdSWK2Z8Aet1TG9eTYy9dL71VFwWEdSqApE4mk4aMKQmvD 0dWgZwjwgOGfh1d/ozRBvJAA8/E/2qXQHQlgxXHvgoNQC3lBgeLoDi5MpSoRfx6yS4a+ Vtxu+oW7XMFT7To2oMXVDdJgiVIxLc4QM9KBbozwrSZNgCNeq3b0OI+YUzruMhdgHKjM O9sA== X-Forwarded-Encrypted: i=1; AHgh+RqhL1iD789pOy+HhQJ2ssc72H/EPe7JVPknONSCOJPVUBz8l1R+OB9K6poy0iBtuwMCqA4sfegR9H3FkJo=@vger.kernel.org X-Gm-Message-State: AOJu0YwDIAZWPuWcwQ1rAOStDx2pdcTJElR51Aqkm9OiucMmd4lu40Cz +w07Xkn8Xt4BAFyBCNKPt9ppXXOdMr+7URagAhInTxhvSPBmb5GCf5QKYRwCqHmHemCd4on/liO 3hWzLD/be+wwURYdoewwshKDomtN9U0VuCSYhO/yfGewQgggMvFDEiI1Y6d7rhK/JBlA= X-Gm-Gg: AR+sD12JxHp7/qRFYns6GUBYsbyNeaIQF2O2gOu2kt16eHpgpy9gbTSxBi/CmLbSl5+ f/t0JeKhS2ugpRoQ9bpUy70qj1CMnmziT3jfiSXzHE/0s9wnwhahTaXwDozSWG3AIy0rOO9Bauq 0+KkTnmyp5YY1qqXS3yPWFbc9XZLX+Og+LlisSMDvSoQ0FqVOm4XG7hOWlZfmWLppEQOO0Nr7K+ aj8SL69jXGI/Ls51omyNrOyAdHbi8xnFaOKvGoOYVvcOx+RyOOMpBidhcNBJf4ZmifUyjz9fPvF Ge0MuvXXRbmjBNb4G8bqRS+xaCQnAI0stVoytOxxnn+i2CG0PQLZ//Q4cmdJpeVZ9+D6vfKLsr2 k7Mq9LzpxATZNe2j2QSNdX/xUH06pWd1p X-Received: by 2002:a05:6830:8387:b0:7e9:b4d0:53ac with SMTP id 46e09a7af769-7eda4d479b2mr11916583a34.29.1784727500116; Wed, 22 Jul 2026 06:38:20 -0700 (PDT) X-Received: by 2002:a05:6830:8387:b0:7e9:b4d0:53ac with SMTP id 46e09a7af769-7eda4d479b2mr11916547a34.29.1784727499674; Wed, 22 Jul 2026 06:38:19 -0700 (PDT) Received: from [192.168.1.11] ([106.222.235.129]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ee29db292esm1359458a34.6.2026.07.22.06.38.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jul 2026 06:38:19 -0700 (PDT) Message-ID: Date: Wed, 22 Jul 2026 19:08:07 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/9] dt-bindings: remoteproc: qcom,pas: add #cooling-cells property To: Krzysztof Kozlowski Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Daniel Lezcano , Amit Kucheria , Konrad Dybcio , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Manivannan Sadhasivam , Kees Cook , "Gustavo A. R. Silva" , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-hardening@vger.kernel.org, manaf.pallikunhi@oss.qualcomm.com References: <20260721-b4-qmi-tmd-v5-0-99620e07f505@oss.qualcomm.com> <20260721-b4-qmi-tmd-v5-1-99620e07f505@oss.qualcomm.com> <20260722-active-kangaroo-of-order-ebb28f@quoll> Content-Language: en-US From: Gaurav Kohli In-Reply-To: <20260722-active-kangaroo-of-order-ebb28f@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Sr6gLvO0 c=1 sm=1 tr=0 ts=6a60c7cc cx=c_pps a=+3WqYijBVYhDct2f5Fivkw==:117 a=/HV6WY1oXUpe+KOgORLkYw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=NFQhSzq1V_q7mLtt_zYA:9 a=QEXdDO2ut3YA:10 a=eYe2g0i6gJ5uXG_o6N4q:22 X-Proofpoint-ORIG-GUID: cnDS5Xaejhc3zbkz59WrAt90aB3NHGdT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDEzMiBTYWx0ZWRfX5mEeVjpCkSZ7 3Dnc/T+OVIOdxSyPtw5Y+uB34PS/uNgDVotqtCmttctmSOwKifXZB4DYoEUy0C9YjAUt8MCSMbe QW8lPpRjeydhUcgcWPIkq3jUdWATAQ5w9IkNwWSIV95k70BwQWaXAiRMYMjxOUuSP2jnGnTdV4R 2MUfAdmpEqE630ibMEPti74Q4MFBNIBMneyTEg88oYDNtc6UmA+gyB1yfNP28SM1EW18rnHWQpq aCB7F4nGJ7dcrc738VUzIjKnB7jUSK3oxtdgQw8b5xPT0OPtK9YLQ7+3BREw8co3aTmzcsrKbHH 2o11zec8D6Q1qtvMC2T0zK0SAHZhAuqDhgJoXzpwW8zwqhQN2VUMEby6bYq/oQzO3Kfl+Z4kMqj Lkvx8wjNBG1blAqtts+AOa3uvfqozcwBMd43aSXXsSLSGH937oCtED4f2jC0p/9Iun7leGqnzu0 mDolj5eUU4ggNQLq8+w== X-Proofpoint-GUID: cnDS5Xaejhc3zbkz59WrAt90aB3NHGdT X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDEzMiBTYWx0ZWRfX2VOkoGst5WPh cf+k1H2e4dAMroa7I+V2AOu8DSvIrtbGSSPX5V77YsY/8SrrqPyFyyQGlqNMA/h7prUBQjjYpFs HvOXGVHA43eavaqzp+lgjPWyBtVcm1A= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-22_04,2026-07-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 clxscore=1015 impostorscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607220132 On 7/22/2026 12:36 PM, Krzysztof Kozlowski wrote: > On Tue, Jul 21, 2026 at 11:58:58AM +0530, Gaurav Kohli wrote: >> Document the optional #cooling-cells property for Qualcomm PAS >> remoteproc nodes so they can be used as thermal cooling devices via >> the QMI Thermal Mitigation Device (TMD) interface. >> >> Qualcomm remote processors expose TMD endpoints that support thermal >> throttling through firmware. The cooling-device specifier uses 3 cells: >> >> <&phandle device_id min_state max_state> >> >> where device_id selects the TMD endpoint (for example PA, modem, or >> CDSP software mitigation), with constants defined in: >> include/dt-bindings/thermal/qcom,qmi-tmd.h >> >> Example usage in a thermal zone: >> >> cooling-maps { >> map0 { >> trip = <&cpu_alert>; >> cooling-device = <&remoteproc_cdsp >> QCOM_TMD_CDSP_SW >> 0 THERMAL_NO_LIMIT>; >> }; >> }; >> >> Signed-off-by: Gaurav Kohli >> --- >> .../bindings/remoteproc/qcom,pas-common.yaml | 9 +++++++++ >> MAINTAINERS | 1 + >> include/dt-bindings/thermal/qcom,qmi-tmd.h | 20 ++++++++++++++++++++ >> 3 files changed, 30 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml >> index 11faf655f530..39e79a1c1079 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml >> @@ -77,6 +77,15 @@ properties: >> channels and devices related to the ADSP. >> unevaluatedProperties: false >> >> + '#cooling-cells': >> + description: | >> + Cooling device with three cells: >> + Cell 0: Cooling device id as defined in >> + include/dt-bindings/thermal/qcom,qmi-tmd.h >> + Cell 1: Minimum cooling state >> + Cell 2: Maximum cooling state >> + const: 3 >> + >> glink-edge: >> $ref: /schemas/remoteproc/qcom,glink-edge.yaml# >> description: >> diff --git a/MAINTAINERS b/MAINTAINERS >> index dcffe9fc54f6..2d4d19201aec 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -3423,6 +3423,7 @@ F: drivers/watchdog/gunyah_wdt.c >> F: include/dt-bindings/arm/qcom,ids.h >> F: include/dt-bindings/firmware/qcom,scm.h >> F: include/dt-bindings/soc/qcom* >> +F: include/dt-bindings/thermal/qcom,qmi-tmd.h >> F: include/linux/firmware/qcom >> F: include/linux/soc/qcom/ >> F: include/soc/qcom/ >> diff --git a/include/dt-bindings/thermal/qcom,qmi-tmd.h b/include/dt-bindings/thermal/qcom,qmi-tmd.h > > Filename must match compatible. There are no qcom,qmi-tmd or qcom,.*tmd > or qcom,.*qmi compatibles. > > Which device is providing this ABI? PAS? thanks for review. Yes, this belongs under PAS. Should i rename the file to pas? > > Best regards, > Krzysztof >