From: Valentin Schneider <valentin.schneider@arm.com>
To: Phil Auld <pauld@redhat.com>, linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] sched/rt: silence double clock update warning by using rq_lock wrappers
Date: Mon, 16 Sep 2019 09:56:46 +0100 [thread overview]
Message-ID: <f388725d-1725-401f-bb44-9bcc785a124a@arm.com> (raw)
In-Reply-To: <f094734a-eeae-02db-dd0b-d7fe7e9d5db8@arm.com>
[Added Steven to Cc]
On 15/08/2019 18:24, Valentin Schneider wrote:
> On 15/08/2019 15:53, Phil Auld wrote:
>> With WARN_DOUBLE_CLOCK enabled a false positive warning can occur in rt
>>
>> [] rq->clock_update_flags & RQCF_UPDATED
>> [] WARNING: CPU: 6 PID: 21426 at kernel/sched/core.c:225
>> update_rq_clock+0x90/0x130
>> [] Call Trace:
>> [] update_rq_clock+0x90/0x130
>> [] sched_rt_period_timer+0x11f/0x340
>> [] __hrtimer_run_queues+0x100/0x280
>> [] hrtimer_interrupt+0x100/0x220
>> [] smp_apic_timer_interrupt+0x6a/0x130
>> [] apic_timer_interrupt+0xf/0x20
>>
>> sched_rt_period_timer does:
>> raw_spin_lock(&rq->lock);
>> update_rq_clock(rq);
>>
>> which triggers the warning because of not using the rq_lock wrappers.
>> So, use the wrappers.
>>
>> Signed-off-by: Phil Auld <pauld@redhat.com>
>> Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
>> Cc: Ingo Molnar <mingo@redhat.com>
>> Cc: Valentin Schneider <valentin.schneider@arm.com>
>> Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
>
> Looks sane to me, and no missing _irqsave this time around ;)
>
> Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
>
Stumbled on that one while reviewing my inbox, ping?
prev parent reply other threads:[~2019-09-16 8:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 14:53 Phil Auld
2019-08-15 17:24 ` Valentin Schneider
2019-09-16 8:56 ` Valentin Schneider [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f388725d-1725-401f-bb44-9bcc785a124a@arm.com \
--to=valentin.schneider@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®