From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
agross@kernel.org, andersson@kernel.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
johan+linaro@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: qcom: sc8280xp-x13s: fix va dmic dai links and routing
Date: Thu, 2 Mar 2023 13:28:29 +0100 [thread overview]
Message-ID: <f39890de-54a9-297b-68ee-41dedd7bdf27@linaro.org> (raw)
In-Reply-To: <20230302115741.7726-5-srinivas.kandagatla@linaro.org>
On 2.03.2023 12:57, Srinivas Kandagatla wrote:
> VA dmics 0, 1, 2 micbias on X13s are connected to WCD MICBIAS1, WCD MICBIAS1
> and WCD MICBIAS3 respectively. Reflect this in dt to get dmics working.
I'm far from good when it comes to sound, but is it expected that
(VA DMICn) are are connected to both (MIC BIASn) and (VA MIC BIAS{1, 1, 3})?
> Also fix dmics to go via VA Macro instead of TX macro to fix device switching.
>
> Fixes: 8c1ea87e80b4 ("arm64: dts: qcom: sc8280xp-x13s: Add soundcard support")
If that doesn't depend on any driver changes, please Cc stable
so that distros will pick this up.
Konrad
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> .../arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> index d18d405d1776..89230112e288 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
> @@ -933,9 +933,9 @@
> "VA DMIC0", "MIC BIAS1",
> "VA DMIC1", "MIC BIAS1",
> "VA DMIC2", "MIC BIAS3",
> - "TX DMIC0", "MIC BIAS1",
> - "TX DMIC1", "MIC BIAS2",
> - "TX DMIC2", "MIC BIAS3",
> + "VA DMIC0", "VA MIC BIAS1",
> + "VA DMIC1", "VA MIC BIAS1",
> + "VA DMIC2", "VA MIC BIAS3",
> "TX SWR_ADC1", "ADC2_OUTPUT";
>
> wcd-playback-dai-link {
> @@ -986,7 +986,7 @@
> va-dai-link {
> link-name = "VA Capture";
> cpu {
> - sound-dai = <&q6apmbedai TX_CODEC_DMA_TX_3>;
> + sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>;
> };
>
> platform {
next prev parent reply other threads:[~2023-03-02 12:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 11:57 [PATCH 0/4] arm64: dts: qcom: sc8280xp: fix audio dts Srinivas Kandagatla
2023-03-02 11:57 ` [PATCH 1/4] arm64: dts: qcom: sc8280xp: fix rx frame shapping info Srinivas Kandagatla
2023-03-02 11:57 ` [PATCH 2/4] arm64: dts: qcom: sc8280xp: fix lpass tx macro clocks Srinivas Kandagatla
2023-03-02 12:24 ` Konrad Dybcio
2023-03-02 11:57 ` [PATCH 3/4] arm64: dts: qcom: sc8280xp-x13s: fix dmic sample rate Srinivas Kandagatla
2023-03-02 12:25 ` Konrad Dybcio
2023-03-02 11:57 ` [PATCH 4/4] arm64: dts: qcom: sc8280xp-x13s: fix va dmic dai links and routing Srinivas Kandagatla
2023-03-02 12:28 ` Konrad Dybcio [this message]
2023-03-02 13:45 ` Srinivas Kandagatla
2023-03-15 23:35 ` [PATCH 0/4] arm64: dts: qcom: sc8280xp: fix audio dts Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f39890de-54a9-297b-68ee-41dedd7bdf27@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®