From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753939AbbG1Elt (ORCPT ); Tue, 28 Jul 2015 00:41:49 -0400 Received: from mail-yk0-f174.google.com ([209.85.160.174]:33721 "EHLO mail-yk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932106AbbG1Elo (ORCPT ); Tue, 28 Jul 2015 00:41:44 -0400 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6 From: Joshua Clayton To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , Sudip Mukherjee , Nitin Kuppelur , Joshua Clayton , Vaishali Thakkar , Tapasweni Pathak , Daniel Baluta , Melike Yurtoglu , Max Perepelitsyn , Aya Mahfouz , Cristina Opriceana , Dogukan Ergun , Julia Lawall , Dan Carpenter , Haneen Mohammed , Rickard Strandqvist Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH V3 3/8] staging: rtl8712: fix comment Date: Mon, 27 Jul 2015 21:41:12 -0700 Message-Id: X-Mailer: git-send-email 2.4.6 In-Reply-To: References: In-Reply-To: References: The old comment refers to a typedef name which is being removed, and to a style of calculation which is no longer being used. It falsely states that IELength is variable length, instead of IEs. Change comment to simply state that the IEs field is a buffer of variable size and that IELength refers to the current size. Signed-off-by: Joshua Clayton --- drivers/staging/rtl8712/wlan_bssdef.h | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/staging/rtl8712/wlan_bssdef.h b/drivers/staging/rtl8712/wlan_bssdef.h index 2ea8a3d..8c5d6e7 100644 --- a/drivers/staging/rtl8712/wlan_bssdef.h +++ b/drivers/staging/rtl8712/wlan_bssdef.h @@ -83,17 +83,6 @@ struct NDIS_802_11_FIXED_IEs { u16 Capabilities; }; -/* - * Length is the 4 bytes multiples of the sume of - * 6 * sizeof (unsigned char) + 2 + sizeof (ndis_802_11_ssid) + sizeof (u32) - * + sizeof (s32) + sizeof (NDIS_802_11_NETWORK_TYPE) - * + sizeof (struct NDIS_802_11_CONFIGURATION) - * + sizeof (NDIS_802_11_RATES_EX) + IELength - - * Except the IELength, all other fields are fixed length. Therefore, we can - * define a macro to present the partial sum. - */ - struct ndis_wlan_bssid_ex { u32 Length; unsigned char MacAddress[6]; @@ -105,6 +94,7 @@ struct ndis_wlan_bssid_ex { struct NDIS_802_11_CONFIGURATION Configuration; enum NDIS_802_11_NETWORK_INFRASTRUCTURE InfrastructureMode; NDIS_802_11_RATES_EX SupportedRates; + /* number of content bytes in EIs, which varies */ u32 IELength; /*(timestamp, beacon interval, and capability information) */ u8 IEs[MAX_IE_SZ]; -- 2.4.6