From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Mehdi Djait <mehdi.djait@bootlin.com>,
mchehab@kernel.org, heiko@sntech.de, hverkuil-cisco@xs4all.nl,
laurent.pinchart@ideasonboard.com,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
conor+dt@kernel.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
alexandre.belloni@bootlin.com, maxime.chevallier@bootlin.com,
paul.kocialkowski@bootlin.com,
Mehdi Djait <mehdi.djait@bootlin.com>
Subject: Re: [PATCH v9 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder
Date: Wed, 22 Nov 2023 05:43:37 -0500 [thread overview]
Message-ID: <f39cdd12-4be4-4a9b-9ec6-3704c84e12da@suswa.mountain> (raw)
In-Reply-To: <dc65a89e7803782a75bf663158e031356ef7cb1a.1700235276.git.mehdi.djait@bootlin.com>
Hi Mehdi,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Mehdi-Djait/dt-bindings-vendor-prefixes-Add-techwell-vendor-prefix/20231117-234411
base: git://linuxtv.org/media_tree.git master
patch link: https://lore.kernel.org/r/dc65a89e7803782a75bf663158e031356ef7cb1a.1700235276.git.mehdi.djait%40bootlin.com
patch subject: [PATCH v9 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder
config: powerpc-randconfig-r071-20231122 (https://download.01.org/0day-ci/archive/20231122/202311221134.0i9KavRs-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231122/202311221134.0i9KavRs-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202311221134.0i9KavRs-lkp@intel.com/
New smatch warnings:
drivers/media/i2c/tw9900.c:628 tw9900_runtime_resume() warn: inconsistent returns '&tw9900->mutex'.
Old smatch warnings:
drivers/media/i2c/tw9900.c:348 tw9900_s_std() error: uninitialized symbol 'mode'.
vim +628 drivers/media/i2c/tw9900.c
cf24af11e0a74c Mehdi Djait 2023-11-17 597 static int tw9900_runtime_resume(struct device *dev)
cf24af11e0a74c Mehdi Djait 2023-11-17 598 {
cf24af11e0a74c Mehdi Djait 2023-11-17 599 struct i2c_client *client = to_i2c_client(dev);
cf24af11e0a74c Mehdi Djait 2023-11-17 600 struct v4l2_subdev *sd = i2c_get_clientdata(client);
cf24af11e0a74c Mehdi Djait 2023-11-17 601 struct tw9900 *tw9900 = to_tw9900(sd);
cf24af11e0a74c Mehdi Djait 2023-11-17 602 int ret;
cf24af11e0a74c Mehdi Djait 2023-11-17 603
cf24af11e0a74c Mehdi Djait 2023-11-17 604 mutex_lock(&tw9900->mutex);
cf24af11e0a74c Mehdi Djait 2023-11-17 605
cf24af11e0a74c Mehdi Djait 2023-11-17 606 if (tw9900->reset_gpio)
cf24af11e0a74c Mehdi Djait 2023-11-17 607 gpiod_set_value_cansleep(tw9900->reset_gpio, 1);
cf24af11e0a74c Mehdi Djait 2023-11-17 608
cf24af11e0a74c Mehdi Djait 2023-11-17 609 ret = regulator_enable(tw9900->regulator);
cf24af11e0a74c Mehdi Djait 2023-11-17 610 if (ret < 0)
cf24af11e0a74c Mehdi Djait 2023-11-17 611 return ret;
mutex_unlock(&tw9900->mutex) before returning.
cf24af11e0a74c Mehdi Djait 2023-11-17 612
cf24af11e0a74c Mehdi Djait 2023-11-17 613 usleep_range(50000, 52000);
cf24af11e0a74c Mehdi Djait 2023-11-17 614
cf24af11e0a74c Mehdi Djait 2023-11-17 615 if (tw9900->reset_gpio)
cf24af11e0a74c Mehdi Djait 2023-11-17 616 gpiod_set_value_cansleep(tw9900->reset_gpio, 0);
cf24af11e0a74c Mehdi Djait 2023-11-17 617
cf24af11e0a74c Mehdi Djait 2023-11-17 618 usleep_range(1000, 2000);
cf24af11e0a74c Mehdi Djait 2023-11-17 619
cf24af11e0a74c Mehdi Djait 2023-11-17 620 ret = tw9900_write_array(tw9900->client, tw9900_init_regs,
cf24af11e0a74c Mehdi Djait 2023-11-17 621 ARRAY_SIZE(tw9900_init_regs));
cf24af11e0a74c Mehdi Djait 2023-11-17 622
cf24af11e0a74c Mehdi Djait 2023-11-17 623 mutex_unlock(&tw9900->mutex);
cf24af11e0a74c Mehdi Djait 2023-11-17 624
cf24af11e0a74c Mehdi Djait 2023-11-17 625 /* This sleep is needed for the Horizontal Sync PLL to lock. */
cf24af11e0a74c Mehdi Djait 2023-11-17 626 msleep(300);
cf24af11e0a74c Mehdi Djait 2023-11-17 627
cf24af11e0a74c Mehdi Djait 2023-11-17 @628 return ret;
cf24af11e0a74c Mehdi Djait 2023-11-17 629 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-11-22 10:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 15:42 [PATCH v9 0/3] media: i2c: Introduce driver for the TW9900 video decoder Mehdi Djait
2023-11-17 15:42 ` [PATCH v9 1/3] dt-bindings: vendor-prefixes: Add techwell vendor prefix Mehdi Djait
2023-11-17 15:42 ` [PATCH v9 2/3] media: dt-bindings: media: i2c: Add bindings for TW9900 Mehdi Djait
2023-11-29 14:50 ` Paul Kocialkowski
2023-11-17 15:42 ` [PATCH v9 3/3] media: i2c: Introduce a driver for the Techwell TW9900 decoder Mehdi Djait
2023-11-22 10:43 ` Dan Carpenter [this message]
2023-11-29 15:02 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f39cdd12-4be4-4a9b-9ec6-3704c84e12da@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lkp@intel.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mchehab@kernel.org \
--cc=mehdi.djait@bootlin.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®