From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vinod Koul <vkoul@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Manivannan Sadhasivam <mani@kernel.org>
Subject: Re: [PATCH v2] arm64: dts: qcom: db845c: Add support for MCP2517FD
Date: Tue, 19 Apr 2022 09:37:45 +0200 [thread overview]
Message-ID: <f3a159b5-ebca-ce00-88dc-ddde353c9031@linaro.org> (raw)
In-Reply-To: <20220419043348.1483625-1-vkoul@kernel.org>
On 19/04/2022 06:33, Vinod Koul wrote:
> Add support for onboard MCP2517FD SPI CAN transceiver attached to
> SPI0 of RB3.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> Changes in v2:
> - add cs and pinctrl config
> - remove misleading comment
>
> arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 33 ++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index 28fe45c5d516..4f4d45be93e3 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -28,6 +28,13 @@ chosen {
> stdout-path = "serial0:115200n8";
> };
>
> + /* Fixed crystal oscillator dedicated to MCP2517FD */
> + clk40M: can_clock {
No underscores in node names.
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <40000000>;
> + };
> +
> dc12v: dc12v-regulator {
> compatible = "regulator-fixed";
> regulator-name = "DC12V";
> @@ -746,6 +753,24 @@ codec {
> };
> };
>
> +&spi0 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&qup_spi0_default>;
> + cs-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>;
> +
> + can@0 {
> + compatible = "microchip,mcp2517fd";
> + reg = <0>;
> + clocks = <&clk40M>;
> + interrupts-extended = <&tlmm 104 IRQ_TYPE_LEVEL_LOW>;
> + spi-max-frequency = <10000000>;
> + vdd-supply = <&vdc_5v>;
> + xceiver-supply = <&vdc_5v>;
> + status = "okay";
No need for status for new nodes (unless it is an extension of existing
node?), it is okay by default.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-19 7:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 4:33 Vinod Koul
2022-04-19 7:37 ` Krzysztof Kozlowski [this message]
2022-04-21 7:23 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3a159b5-ebca-ce00-88dc-ddde353c9031@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®