From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: lpass-va: add npl clock for new VA macro
Date: Tue, 15 Nov 2022 15:21:05 +0100 [thread overview]
Message-ID: <f3a6a7b1-b196-0abb-0c18-8a13908c6891@linaro.org> (raw)
In-Reply-To: <20221115105541.16322-2-srinivas.kandagatla@linaro.org>
On 15/11/2022 11:55, Srinivas Kandagatla wrote:
> LPASS VA Macro now has soundwire master to deal with access to
> analog mic in low power island use cases. This also means that VA macro
> now needs to get hold of the npl clock too. Add clock bindings required
> for this.
>
> As part of adding this bindings, also update bindings to be able to
> specific and associate the clock names specific to the SoC.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> .../bindings/sound/qcom,lpass-va-macro.yaml | 72 ++++++++++++++++---
> 1 file changed, 64 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> index c36caf90b837..848e34111df1 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
> @@ -27,16 +27,13 @@ properties:
> const: 0
>
> clocks:
> - maxItems: 3
> + minItems: 1
> + maxItems: 4
> +
>
> clock-names:
> - oneOf:
> - - items: #for ADSP based platforms
> - - const: mclk
> - - const: core
> - - const: dcodec
> - - items: #for ADSP bypass based platforms
> - - const: mclk
> + minItems: 1
> + maxItems: 4
>
> clock-output-names:
> maxItems: 1
> @@ -61,6 +58,65 @@ required:
> - reg
> - "#sound-dai-cells"
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: qcom,sc7280-lpass-va-macro
> + then:
> + properties:
> + clocks:
> + minItems: 1
You can skip minItems here.
> + maxItems: 1
> + clock-names:
> + items:
> + - const: mclk
> + required:
> + - clock-names
> + - clocks
IIUC, all variants require now clocks, so these two lines should be part
of top level "required:".
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: qcom,sm8250-lpass-va-macro
> + then:
> + properties:
> + clocks:
> + minItems: 3
> + maxItems: 3
> + clock-names:
> + items:
> + - const: mclk
> + - const: core
> + - const: dcodec
> + required:
> + - clock-names
> + - clocks
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,sc8280xp-lpass-va-macro
> + - qcom,sm8450-lpass-va-macro
> + then:
> + properties:
> + clocks:
> + minItems: 4
> + maxItems: 4
> + clock-names:
> + items:
> + - const: mclk
> + - const: npl
How about making it the last clock so the order matches with sm8250?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-15 14:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 10:55 [PATCH 0/2] ASoC: codec: lpass-va: add npl clock support Srinivas Kandagatla
2022-11-15 10:55 ` [PATCH 1/2] ASoC: dt-bindings: lpass-va: add npl clock for new VA macro Srinivas Kandagatla
2022-11-15 14:21 ` Krzysztof Kozlowski [this message]
2022-11-18 6:56 ` Srinivas Kandagatla
2022-11-15 10:55 ` [PATCH 2/2] ASoC: codecs: va-macro: add npl clk Srinivas Kandagatla
2022-11-15 14:23 ` Krzysztof Kozlowski
2022-11-18 7:02 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3a6a7b1-b196-0abb-0c18-8a13908c6891@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®