mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: zhangheng <zhangheng@kylinos.cn>
Cc: joyce.ooi@intel.com, andrew+netdev@lunn.ch, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	chris.snook@gmail.com, f.fainelli@gmail.com, horms@kernel.org,
	shannon.nelson@amd.com, jacob.e.keller@intel.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: Use dma_set_mask_and_coherent to set DMA mask
Date: Mon, 25 Nov 2024 19:10:08 +0100	[thread overview]
Message-ID: <f3a7d89c-43b4-4d5a-ac70-6b14c77b4cd4@lunn.ch> (raw)
In-Reply-To: <20241125033446.3290936-1-zhangheng@kylinos.cn>

On Mon, Nov 25, 2024 at 11:34:46AM +0800, zhangheng wrote:
> Many drivers still have two explicit calls of dma_set_mask() and
> dma_set_coherent_mask().
> 
> Let's simplify with dma_set_mask_and_coherent().

Is simplification a sufficient justification?

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#clean-up-patches

1.6.6. Clean-up patches

  Netdev discourages patches which perform simple clean-ups, which are
  not in the context of other work. For example:

  Addressing checkpatch.pl warnings

  Addressing Local variable ordering issues

  Conversions to device-managed APIs (devm_ helpers)

  This is because it is felt that the churn that such changes produce
  comes at a greater cost than the value of such clean-ups.

What is the value of this simplification? What is the likelihood you
have actually broken something? The problem with these sorts of
patches is that they are often made blindly without understanding the
code and a small percentage actually break things. As a result,
Maintainers need to look at these patches and spend the time to
actually understand them. I would prefer to spend that time on new
drivers, rather than old code which works and does not really benefit
from simplification.

	Andrew

  reply	other threads:[~2024-11-25 18:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-25  3:34 zhangheng
2024-11-25 18:10 ` Andrew Lunn [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-11-23 10:27 zhangheng
2024-11-23 19:45 ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3a7d89c-43b4-4d5a-ac70-6b14c77b4cd4@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andrew+netdev@lunn.ch \
    --cc=chris.snook@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=joyce.ooi@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shannon.nelson@amd.com \
    --cc=zhangheng@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®