Re: [PATCH v2 2/2] net: stmmac: dwmac-qcom-ethqos: add support for emac4 on qcs9100 platforms

[Tengfei Fan <quic_tengfan@quicinc.com>]

On 7/10/2024 11:02 AM, Aiqun Yu (Maria) wrote:
> 
> 
> On 7/9/2024 11:33 PM, Andrew Lunn wrote:
>> On Tue, Jul 09, 2024 at 09:40:55AM -0500, Andrew Halaney wrote:
>>> These patches are for netdev, so you need to follow the netdev
>>> rules, i.e. the subject should be have [PATCH net-next] in it, etc as
>>> documented over here:
>>>
>>>      https://docs.kernel.org/process/maintainer-netdev.html#tl-dr
>>>
>>> On Tue, Jul 09, 2024 at 10:13:18PM GMT, Tengfei Fan wrote:
>>>> QCS9100 uses EMAC version 4, add the relevant defines, rename the
>>>> has_emac3 switch to has_emac_ge_3 (has emac greater-or-equal than 3)
>>>> and add the new compatible.
>>>
>>> This blurb isn't capturing what's done in this change, please make it
>>> reflect the patch.
>>
>> Hi Tengfei
>>
>> If i remember correctly, there was a similar comment made to one of
>> the patches in the huge v1 series.
>>
>> The commit messages are very important, just as important as the code
>> itself. Please review them all and fixup issues like this before you
>> repost.
> 
> Thx Andrew L for the info.
>>
>>      Andrew
>>
>> ---
>> pw-bot: cr
> 

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore all the current patches here.
Thank you for your input.

-- 
Thx and BRs,
Tengfei Fan