From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793623916; b=GX5oLm/xFr+C95jm5H1arPcdh19CqzD76pkBCSTUILt4JD6tWAXMBVQvbcoyiNQ+Pa3e avBRFsN39Cmd0VWgac7h23Iri6j3iqv1dTe1a48PoyakasqW3vlvo97YW5RHOPZG1jGjs a+b/KH1j/KC4P5Q627KMITkvU7bh0OHjcS6gl71qw6Bf2M2OzkXn9ASUGqex8gb/+aExJ ED2vB4sjVVdxQ4XUglUZX6UO2i12Es/xsTBZJENsSR52Yd2nRo50ahUfRYEHjTFeTrShB iMo5MS0RkTzGUzFyHU24+KnUCrqj+E3poVy4nFJroaIbajXXQJS2jvrrsDuNQOHyHmA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793623916; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=gYrHasKbCnivUZKlafZ5WVAkPwuwplVb+icnUCX5yjY=; b=eR3pB9TY1/h1f+swNgCy2L5Ih5L46UTeHfeIUE7r1xf8rL2NabY7RZ8tFJDkp8NPrEM7 DI8A0mGyMVTSAIYEUbZYRxkhxFiX+wuZqQUliZdptJqbFJAMBUR2zwOmfuHxzEU8eshj/ nu40AVcmzDTpZh3IDW3T+huIlfi5tlnfSfV38sypVopHeZLNyen/Eu/vKRAKBKtynAJ9U qSIs8xLkFcNbA/kmVj2207p7tG8OHqwCBznaHyVeObQ4GEBuM3GkQue1VgIcb4x/B0ZPw p3j/1pelE41cOt3oRN3LfAjjsLTSCSwmo1C3nhISMmBXzDlKdvHgr6aSIjJIPp3JVOg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=S7BWKxBM; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D428606A327 for ; Mon, 2 Nov 2026 12:51:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=S7BWKxBM Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FB291F00A16; Mon, 2 Nov 2026 12:51:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793623915; bh=gYrHasKbCnivUZKlafZ5WVAkPwuwplVb+icnUCX5yjY=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=S7BWKxBMbz2TWV1nf0UCf7ZV5WKchz9k6I6etY/gESRikgsmpQDZBXjP/EXr4akBa /j5B0jJ/sPjy5d6if9n8y7qgBbUVoowfJYp2HGXQLE48D2x/dAqdUJV6QdntlevleI eGno6zZHuKPuxVWDvaM1XsxHGFD3U0Dql/1gRPoPgyHCPBwfJboNlvbJ1moYrPRqvT EDusjqcTxWypyUht1ESIULFpAcrA/zF2TcuHU1A+bVxaSYth0oQ0AW6YHXs5PqMCTc lkF5hkKAFiPuxFWGPibAl6FSdUQZYkrb7S5/hLf938RJ2pMXmQrI3jtqE2IBM1HfAD kJ1ScwyaFZIDA== Message-ID: Date: Mon, 2 Nov 2026 13:51:52 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] tools/mm/thpmaps: fix missing order-1 file THP statistics To: Weilin Tong , Andrew Morton , Ryan Roberts Cc: Baolin Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20261027074904.3328878-1-tongweilin@linux.alibaba.com> <20261027074904.3328878-3-tongweilin@linux.alibaba.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20261027074904.3328878-3-tongweilin@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/27/26 08:49, Weilin Tong wrote: > File-backed THPs can have order 1, but the per-size counters are only > emitted for order 2 and above. Fully and contiguously mapped order-1 > file THPs are therefore missing from the output. > > Start emitting the per-size counters at order 1. > > Fixes: 2444172cfde4 ("tools/mm: add thpmaps script to dump THP usage info") > Assisted-by: LLM > Signed-off-by: Weilin Tong > --- > tools/mm/thpmaps | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/mm/thpmaps b/tools/mm/thpmaps > index d92aace005c1..30a8e915d677 100644 > --- a/tools/mm/thpmaps > +++ b/tools/mm/thpmaps > @@ -295,7 +295,7 @@ def thp_parse(vma, kpageflags, ranges, indexes, vfns, pfns, anons, heads): > > def flatten_sub(type, subtype, stats): > param = f"{type}-thp-pte-{subtype}-{{}}kB" > - for od, nr in enumerate(stats[2:], 2): > + for od, nr in enumerate(stats[1:], 1): > rstats[param.format(odkb(od))] = {'type': type, 'value': nrkb(nr)} > > def flatten_type(type, stats): Acked-by: David Hildenbrand (Arm) -- Cheers, David