From: Joe Perches <joe@perches.com>
To: Aditya Srivastava <yashsri421@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: lukas.bulwahn@gmail.com, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v3] checkpatch: avoid COMMIT_LOG_LONG_LINE warning for signature tags
Date: Mon, 16 Nov 2020 08:59:28 -0800 [thread overview]
Message-ID: <f3ac4a646b82ef2d31bfb0e9ea953b2c961de2c2.camel@perches.com> (raw)
In-Reply-To: <20201116083754.10629-1-yashsri421@gmail.com>
On Mon, 2020-11-16 at 14:07 +0530, Aditya Srivastava wrote:
> Currently checkpatch warns us for long lines in commits even for
> signature tag lines.
Thanks Aditya.
Acked-by: Joe Perches <joe@perches.com>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -2961,8 +2961,8 @@ sub process {
> # file delta changes
> $line =~ /^\s*(?:[\w\.\-]+\/)++[\w\.\-]+:/ ||
> # filename then :
> - $line =~ /^\s*(?:Fixes:|Link:)/i ||
> - # A Fixes: or Link: line
> + $line =~ /^\s*(?:Fixes:|Link:|$signature_tags)/i ||
> + # A Fixes: or Link: line or signature tag line
> $commit_log_possible_stack_dump)) {
> WARN("COMMIT_LOG_LONG_LINE",
> "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
prev parent reply other threads:[~2020-11-16 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 8:37 Aditya Srivastava
2020-11-16 16:59 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3ac4a646b82ef2d31bfb0e9ea953b2c961de2c2.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®