From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753281AbdKIH6x (ORCPT ); Thu, 9 Nov 2017 02:58:53 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:34772 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753063AbdKIH6t (ORCPT ); Thu, 9 Nov 2017 02:58:49 -0500 Subject: Re: [PATCH x86/urgent] bpf: emulate push insns for uprobe on x86 To: Thomas Gleixner CC: David Miller , , , , , , , , References: <20171108213712.1232793-1-yhs@fb.com> <20171109.090647.824552877953564084.davem@davemloft.net> <526920a7-0329-cc2b-0cae-1af221a48aee@fb.com> From: Yonghong Song Message-ID: Date: Wed, 8 Nov 2017 23:57:44 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c090:180::1:e5f4] X-ClientProxiedBy: CY4PR2201CA0005.namprd22.prod.outlook.com (10.171.208.143) To MWHPR15MB1839.namprd15.prod.outlook.com (10.174.255.143) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 868efca6-0ad1-4fd3-cea6-08d5274794fa X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:MWHPR15MB1839; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1839;3:ogAkOqyIcI7wUeSeW+e255ajDqzg0yEQLYzbER+dLfxS6V0MkfA/zJOTTaXbAQNLm5Ae0sXWjKeFZaOdCTWT10mHXyzt1aG4hJk7aOzlbJvxEhxFDZuMyM5pdXocib7s89gNEdGTd65kw8Lu0hYK0Ylbyu0esCns32TpPWx9E7GcMlo6Kds0geCd6Ey/7T9MJGcI1CS+3msbJukre4u7+8nrGek09OKbfakwp+MBY+UMdItblBXhbJ01NVJx4AYE;25:n5Qbl3migOIy2/t4NY095cNng4lSkvOC26tPG7DkPGdcgVJ2mUmEpJigEqLvwUS/8WPMZ/zHYmMh6nuXtRYvpL9hxscik6KJIRp+kmX02spABEofB4VWryBexCUV6px7uIopxbYVo/2P+PAYso5OkB4d1WzK2G/UFgXT2fZbQvg/9p7jiW7Rf0eYxKa5IqZFuCVagZQOoQGmKfYkm/8p8f+tN1IZIH6Y8KulqMN4KddfBqGJzvyvGGPMQQ4QiHRKqfMBau5dpSS9ibJ7zl2uly2ICza8z+N4rZvT+Yjcw+LB5Kw7RSlKTV+OJIagCc4peLnJjaW6FuD/S86fpIZy3A==;31:wjschjReUxCC0/TG54nss2s75kLSMs0Jd4C4psveuL5ueOTCyphQD7BgKwTipxoqZB8DhJcgZxkfghyh2a6C8+OB8o1u4YfkyQBr9XbdHuJkALcJW5p+6iGI/cImXHOb5tqn2qIdP5t+uNajD05xsJ7H+PlLYTp6ljMniqnOxYh9Efgtu/C8ciXqqk61uNizYYIKPPLqNUBapGyOj29wZ6DGwJGxYciKTz/xiG1NOCE= X-MS-TrafficTypeDiagnostic: MWHPR15MB1839: X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1839;20:tMuWR+Yeg4Ser3DpZgXxCuGpYCYqkTQ1LnUcfsrBilFgJXeDqa5UpLtPG06I1TaMZxsFSl90mH9WajrUbK0J+3K4Sqmh2zaeLtuzwAuclKhrOeeaSfevKQu4Gj22E6SgydSGlcZ+USkEre2it8N+kXBq8ti3Gzpvllh1Aw4qUC2PppEzW+ehqP6znKaac14C4/hYMZ/NiSCRhBIuDTmel3Hhzfo0z08oq9m7LYTRpVKpdZYhnRJRWqE6d8rmPd4TzUmTTdLlf6oSVwUUkKdq5hVGwhMFObPHAwlwGcMUFB0q4JvcBelD0Y7JACzkGGqWGk2WwcvjUnpbYECfMpp0vlUu7bE/TENUNkPbmwZHHjm22TsymlKAHS7fCKslNHQWdsGhGII7ZTpLzNP+Y9p63sMUOlSrFRHq9H6g3k15zLabbESHt4yvDgPD+dNRzHgoyUvHxMAi1GtLP2T5Ymb3p2mxkkIvFSDlqtHskqPTAwb33A2dH3+vlU1AQMwo1VgM;4:OsmeDpPu50pHZGdTeFZ68bu88VcCwWp4jWZdaQmMoAt2DWbx4qqdtS2ldImnveWHRPSCP5NOSVYqzg+t9vJFbVRl73dNBPduOB57gFuCnKdckRfWQ7D3N9pQoo9OHGR6siNmo06CkxTfgVqpuNi0hG2IIvhenOjuMC09j4fa0ah74jo3Ub9MML1jigfGyeQYCRXCcXhwvxyb+tbby/Pnklww0OsxKqCmjzY7LCH0poCAcaOsR8jhHn3U1T0X83r7vVteusXkL/q8jlwIb19v/qiDms125t5XPLgnkALpd98dmrHc3Ewzb4yAWJRAWCa/ X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(11241501159)(6040450)(2401047)(5005006)(8121501046)(3231021)(3002001)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR15MB1839;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR15MB1839; X-Forefront-PRVS: 0486A0CB86 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(346002)(376002)(199003)(189002)(24454002)(6512007)(53936002)(2906002)(25786009)(2950100002)(65806001)(6666003)(229853002)(97736004)(4326008)(86362001)(67846002)(23676003)(65956001)(6916009)(6506006)(93886005)(47776003)(316002)(6486002)(31686004)(218543002)(83506002)(5660300001)(6246003)(7736002)(33646002)(305945005)(65826007)(31696002)(81166006)(81156014)(58126008)(478600001)(230700001)(8676002)(8936002)(53546010)(105586002)(68736007)(101416001)(50986999)(54356999)(64126003)(189998001)(76176999)(6116002)(50466002)(106356001)(36756003)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1839;H:dhcp-172-20-165-6.DHCP.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjE1TUIxODM5OzIzOnMvVCtVWThVWitiOVJzSzVwVXpsQWUzamcy?= =?utf-8?B?WFpyelRyclc5SVIyalRxS21TN1NveEx0dDBJcXM1c0NCV1h3Q1dRZmI4MGtR?= =?utf-8?B?cnBVRFlaMlMzZnkyRzk3bXJMdFZPbnZib1FOM2VDQnY1TjR3YlpyV2ZqZUZL?= =?utf-8?B?RjJ4WWxQNjVIckR3cUErLzg0VitXdnB0ak9LNjRHUit1dytsVWpDUE8xQ1hF?= =?utf-8?B?cDBlaXFESzMxVFFnTWd6U3hTWERZRkdzMnJuZU5GTloyZEE2RW5ESzBxemFQ?= =?utf-8?B?bXlYakp4eCtqd0MxMEVLMWpkMzh5T1dRMEJVMkpzaU9IVWx3cGxTeC9GaXlY?= =?utf-8?B?RXY5MFJuY0dRalQwWDc0L0RBMHdxSHBMTi9YMnNaWjJOaHN6SlVyMm9MVUtz?= =?utf-8?B?Z2ZwUHQ4RXg5YXcyUFYzVWFyWW1JUDdURmpjdWN1VjVBbzZJbWRNbFhPOWRT?= =?utf-8?B?UmliYS8wdVpWbG9QSnJlL2t0c1VZWnIzN3R0U1Rvb2F6RGt2RFAvQXZDNTcz?= =?utf-8?B?VzdiWjNYYlQ2RWo0clVSUnY5RUlMUW9BSnI0UnpLS3UwUytQWGZjRWhBOW1H?= =?utf-8?B?Vml3bURtZHlVUDZvZ21FWmxyejAzZmRhMkpVYlM3bm9RMUxiZnlYOTA5NkFm?= =?utf-8?B?bGpURDJpQlpLOVFWM1FvSnRadWZnQ3FnZGwyWU10d3VqNEl3eTBBWlVXZE0r?= =?utf-8?B?TGxlbDRTZjdlbUFISC9XQUVNUFpzQ20rRVk1RCtyWTlJMlhCeWVYWStDNi9n?= =?utf-8?B?QlpUYUp4VlB4ZWdreUthaWdhWG9FUWNoaTRPL1IvaDhzSmpwcEdQYWM5UGpJ?= =?utf-8?B?ZjRFdE1QMTVZS21IbnR0NzFOZkp2NUU1eWY0cUNKUEVhS2FKWm1ESy9nSFJt?= =?utf-8?B?ME1LVWQ5Y3dDd0w5YW5IMWNnZkNMNkRoTXgwV3RLZGorcDVNY25MOXI4Rjk5?= =?utf-8?B?YUd3T0d3ZG9qcm9RNm0rbTlJcmJQaDZZN05qUG1LR2wrMVJWakZkV00wNkRy?= =?utf-8?B?eXBoYmFMMjZUN3BDTnNuN1hYSGZSL3VBeU9LQ3FuYkVQaFRxV3J6ZVYxWUQ3?= =?utf-8?B?dElLczZIaHpVd2dNVnFZZFc1U2pMK21RVUpIUWcvYW5nU3JjdGNBTmdOcVZI?= =?utf-8?B?VmlITjZkZWxLQjZJUVk4emg3WmhVOUxXOFNNU3V4Q1V0aU1WcytkNmdvOE15?= =?utf-8?B?OVB1aElKeTdmeGtLS0F0RmFtcWVHOStjUG03bGw1bXdwQWowZVJIdE5mZFky?= =?utf-8?B?dzBjSVlUUVo0cURVUnJUV0NFaE1zT3QvTDZ3bXhMRTE5YUw1RGJHZHgwMW9J?= =?utf-8?B?Q2JudDNIMUV5Um1qRjRtQzVhR1JHLy9aNjMxL0RrMGZ1VVNOdHVQZ3hyZGtP?= =?utf-8?B?bTBuMDErM1ZRVUZEZHJuZk9VTWFIVGUyRWRKZTQ5eUxYQzJkaGZEbm5XSXhQ?= =?utf-8?B?bDQ0eEg0a2U1aFZ5N3lSSXA2VGhVTjFWNy84ZVJEOHV1dFRRa28wdDlIbkJP?= =?utf-8?B?Y09SY2x1UXJlalFYa1ZnOTVRZGpzTTVvaTFWMjN1bm42UU53amdvcW5DRE9s?= =?utf-8?B?b2VDQXp3aTh5VzhxS3UyUmhaOS9zcDlMME9iaDZRMzYyYkdqVHJvek8ybitU?= =?utf-8?B?WjRQNmpsMWhrZzZRbmhmS05GdTdVc3I3cGxsSUQ1NDRoRTJQckJyUDVQV2ZB?= =?utf-8?B?c2ZjdS83S21uSHBHQ3hoOW9LcmZsdXlZUWVyV1ByZWRZWnNZZVE5WWlOc0pk?= =?utf-8?Q?0k/zaEuq+p17Or1aupErzojJFhx9QZeO/gZ00=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1839;6:bml44Q6wnBl6E6GRFgxn986deJB2Wp71dD3INr/9LX7U16Mm6nFHiFxTqBCFCOvDf3aNT6FCRovAlLiMrk94aKi96IWf/E60c3sm+idlRLLDhllC/Moy+j+jD94KDLxejsvMZLwGNvZ9aHFm2GbZ68hr91rUWybKr+FPv9BPijJxHuysovQWxIsolZ0AOCG/dv4YBhVM7YEUxEnRDNFvPyvCQ+sEfOf71W3KM9DIoH7cpUJHHlT6U3FphBQR/TeCiDSRFAP7S3RQhGUAE53zmqLEeYcpeJvJDnvyqA+6EwoajQVQEmHBC5RLgUxSwTl8lCZ4ScOM8LgH5hXS67jvL+YF35rE4sajOfGCfIjDU48=;5:G2woTE/kWd7zCv7wm1dnvDut74fNNa0b3VprgPiKuuPb6O7fU013iT27xw2hvr9CIE+CTH+zXLtBJjQXnRScdrD4dUaH3sqp2855z7/HI2M1Hewqz03crUUj4mduBemvg/vMNoJOUrvNpAhy++gvwMvFCfbrqBhPkpP95Jzx+w0=;24:gVgZWmcJivsvODfAOsYucqZdiulmQQdwtfZBGm+C/7kZw7mPKbdgfiuyLiAEW3RzID2nI1xu7KvAkDbvbTXERo49GTsCgp0Ur6Jb5eitUg8=;7:Dh6JvgZxoR9+SzeEVWowqwetSdeSFrtW+eDvvc9qI4zI4PXd2qm7I/7yLPb4G9W2qgjEzSRorXIF17tonJXbOYJQ6jurqw6ul2p2FZ/rpfyCh7uyXsAlnO2txsY6JNZ1r5QYq4S48Fav5YjvHvN7Xhwt+WvF3QqotdSUZd+mQobamAup8hpciExVIfZ3Wj+7LJW+Cd4oJjHnQuowu1ZBxBn1upt54Jyn3AjA4ZY7TZu2E6zDGQeqBGmXYltFjHTW SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1839;20:rhkEP2vJyjmUs7CyIPAgusDEkbkwAPLBmLCobJW4D2t0vV4rkAbEHdqAugvDSiFpacDGiIfZZKqcoAy0NV2/rLSmKxynu9x1Z42Mfp1n6mf+Dw9jTqwG4s6hYQkU0L5myWyavLl21HAKNcXOvvpGT6mJtjNtfUOz+D6wP/qD17w= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2017 07:57:50.4200 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 868efca6-0ad1-4fd3-cea6-08d5274794fa X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1839 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-11-09_01:,, signatures=0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/8/17 10:53 PM, Thomas Gleixner wrote: > On Wed, 8 Nov 2017, Yonghong Song wrote: >> On 11/8/17 4:06 PM, David Miller wrote: >>> From: Yonghong Song >>> Date: Wed, 8 Nov 2017 13:37:12 -0800 >>> >>>> Uprobe is a tracing mechanism for userspace programs. >>>> Typical uprobe will incur overhead of two traps. >>>> First trap is caused by replaced trap insn, and >>>> the second trap is to execute the original displaced >>>> insn in user space. >>> ... >>> >>> I don't understand how this is bpf related, and if it is you don't >>> explain it well in the commit message. >> >> Right. This is not related to bpf. Will remove the "bpf" from the subject line >> in the next revision. > > The proper subject is something like: > > [PATCH] uprobes/x86: ....... Thanks, Thomas, I will fix the subject etc. Previously, I added x86/urgent as the branch I did my test on top of it (similar to net-next). I will add that information in the comments and re-submit. > > which you can figure out by looking at the subsystem prefixes via > > git log arch/x86/kernel/uprobes.c > > Note, that it says [PATCH} and nothing else. That patch is a nice > performance improvement, but certainly not x86/urgent material. x86/urgent > is for bug and regression fixes. > > Thanks, > > tglx >