From: Marek Vasut <marex@denx.de>
To: Leonard Crestez <leonard.crestez@nxp.com>,
Fabio Estevam <festevam@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Peter Chen <Peter.Chen@nxp.com>,
Anson Huang <Anson.Huang@nxp.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-kernel <linux-kernel@vger.kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Christoph Fritz <chf.fritz@googlemail.com>
Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Remove cpufreq OPP override
Date: Tue, 25 Apr 2017 19:28:06 +0200 [thread overview]
Message-ID: <f3bbd20c-2132-1121-1044-ba00dba302d6@denx.de> (raw)
In-Reply-To: <1493141004.3557.8.camel@nxp.com>
On 04/25/2017 07:23 PM, Leonard Crestez wrote:
> On Tue, 2017-04-25 at 14:02 -0300, Fabio Estevam wrote:
>> On Tue, Apr 25, 2017 at 2:02 PM, Fabio Estevam <festevam@gmail.com> wrote:
>>>
>>> Hi Leonard,
>>>
>>> On Tue, Apr 25, 2017 at 1:57 PM, Leonard Crestez
>>> <leonard.crestez@nxp.com> wrote:
>>>>
>>>> The board file for imx6sx-dbg overrides cpufreq operating points to use
>>>> higher voltages. This is done because the board has a shared rail for
>>>> VDD_ARM_IN and VDD_SOC_IN and when using LDO bypass the shared voltage
>>>> needs to be a value suitable for both ARM and SOC.
>>>>
>>>> This was introduced in:
>>>>
>>>> commit 54183bd7f766 ("ARM: imx6sx-sdb: add revb board and make it default")
>>>>
>>>> This only only applies to LDO bypass mode, a feature not present in
>>>> upstream. When LDOs are enabled the effect is to use higher voltages than
>>>> necesarry for no good reason.
>>>>
>>>> Setting these higher voltages can make some boards fail to boot with ugly
>>>> semi-random crashes, reminiscent of memory corruption. These failures
>>>> happen the first time the lowest idle state is used. Remove the OPP
>>>> override in order to fix those crashes.
>>>>
>>>> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
>>>>
>>>> ---
>>>> It's not clear exactly why the crashes happen. Perhaps waking up from idle
>>>> draws more power than is available? Removing this override is a correct
>>>> change anyway so maybe there is no need to investigate deeper.
>
>>> Marek just sent a similar one a few minutes ago:
>>> http://lists.infradead.org/pipermail/linux-arm-kernel/2017-April/503230.html
>
>> Forgot to add Marek.
>
> Wow, that was literally 15 minutes before my patch. In my defense I did
> search the archives before starting to format the patch but it had not
> arrived yet.
Hehehe :-)
> Anyway, that version also sets the supply for reg_arm and reg_soc. It
> is not necessary for fixing the crash I'm seeing but is good because it
> will result in the minimum voltage on VDD_ARM_SOC_IN rather than a fix
> 1375mv. I tested Marek's patch and it works fine on my rev B board
> (which otherwise fails to boot upstream).
Oh that's nice , thanks ! I don't have SDB and I hacked it up after a
brief discussion with Fabio without even compile-testing it, thus RFC.
Glad to hear it works and thanks for testing it ! Can you add a formal
Tested-by please ?
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2017-04-25 17:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 16:57 Leonard Crestez
2017-04-25 17:02 ` Fabio Estevam
2017-04-25 17:02 ` Fabio Estevam
2017-04-25 17:23 ` Leonard Crestez
2017-04-25 17:26 ` Fabio Estevam
2017-04-25 17:28 ` Marek Vasut [this message]
2017-05-03 13:57 ` Shawn Guo
2017-05-03 14:26 ` Marek Vasut
2017-05-03 14:32 ` Marek Vasut
2017-05-03 14:41 ` Shawn Guo
2017-05-03 14:51 ` Marek Vasut
2017-05-03 14:58 ` Leonard Crestez
2017-05-03 15:59 ` Marek Vasut
2017-05-03 17:58 ` Leonard Crestez
2017-05-03 19:33 ` Marek Vasut
2017-05-04 9:42 ` Leonard Crestez
2017-05-04 10:06 ` Marek Vasut
2017-05-04 12:44 ` Shawn Guo
2017-05-04 13:08 ` Marek Vasut
2017-05-04 13:41 ` Shawn Guo
2017-05-04 14:34 ` Marek Vasut
2017-05-05 1:18 ` Shawn Guo
2017-05-05 10:11 ` Leonard Crestez
2017-04-27 1:17 ` Peter Chen
2017-05-04 11:43 ` Shawn Guo
2017-05-04 11:46 ` Fabio Estevam
2017-05-04 12:50 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3bbd20c-2132-1121-1044-ba00dba302d6@denx.de \
--to=marex@denx.de \
--cc=Anson.Huang@nxp.com \
--cc=Peter.Chen@nxp.com \
--cc=chf.fritz@googlemail.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=shawnguo@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®