From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932815AbdKONg4 (ORCPT ); Wed, 15 Nov 2017 08:36:56 -0500 Received: from mail.etersoft.ru ([91.232.225.46]:53463 "EHLO mail.etersoft.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932294AbdKONgq (ORCPT ); Wed, 15 Nov 2017 08:36:46 -0500 DKIM-Filter: OpenDKIM Filter v2.10.3 mail.etersoft.ru 3D7296D7A7D MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Date: Wed, 15 Nov 2017 16:36:43 +0300 From: Vitaly Lipatov To: Jeff Layton Cc: linux-fsdevel@vger.kernel.org, hch@lst.de, bfields@fieldses.org, Alexander Viro , linux-kernel@vger.kernel.org Subject: Re: [PATCH] fcntl: don't cap l_start and l_end values for F_GETLK64 in compat syscall Organization: Etersoft In-Reply-To: <20171115131750.27717-1-jlayton@kernel.org> References: <20171115131750.27717-1-jlayton@kernel.org> Message-ID: User-Agent: Roundcube Webmail/1.3.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vAFDb0ei011958 Jeff Layton писал 15.11.17 16:17: > From: Jeff Layton > > Currently, we're capping the values too low in the F_GETLK64 case. The > fields in that structure are 64-bit values, so we shouldn't need to any > sort of fixup there. > > Make sure we check that assumption at build time in the future however > by ensuring that the sizes we're copying will fit. Nice fix. The only question I do not know answer is what is purpose of COMPAT_LOFF_T_MAX macro? -- С уважением, Виталий Липатов, Etersoft