From: Bart Van Assche <bvanassche@acm.org>
To: Christoph Hellwig <hch@infradead.org>, Yu Kuai <yukuai1@huaweicloud.com>
Cc: axboe@kernel.dk, neil@brown.name, akpm@linux-foundation.org,
linux-block@vger.kernel.org, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org, colyli@kernel.org, xni@redhat.com,
yi.zhang@huawei.com, yangerkun@huawei.com,
johnny.chenyi@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH] block: fix disordered IO in the case recursive split
Date: Thu, 21 Aug 2025 08:19:21 -0700 [thread overview]
Message-ID: <f3c5067f-af90-4491-86c0-06eaa24e2946@acm.org> (raw)
In-Reply-To: <aKbgqoF0UN4_FbXO@infradead.org>
On 8/21/25 2:02 AM, Christoph Hellwig wrote:
> On Thu, Aug 21, 2025 at 04:56:33PM +0800, Yu Kuai wrote:
>> BTW, for all the io split case, should this order be fixed? I feel
>> we should, this disorder can happen on any stack case, where top
>> max_sector is greater than stacked disk.
>
> Yes, I've been trying get Bart to fix this for a while instead of
> putting in a workaround very similar to the one proposed here,
> but so far nothing happened.
Does the above comment refer to the block/blk-crypto-fallback.c code? I
will leave it to Eric Biggers to move the bio splitting call from that
code into the filesystems that need it.
Bart.
next prev parent reply other threads:[~2025-08-21 15:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 7:47 Yu Kuai
2025-08-21 8:06 ` Coly Li
2025-08-21 8:43 ` Christoph Hellwig
2025-08-21 8:56 ` Yu Kuai
2025-08-21 9:02 ` Christoph Hellwig
2025-08-21 9:33 ` Hannes Reinecke
2025-08-21 9:42 ` Yu Kuai
2025-08-21 9:37 ` Yu Kuai
2025-08-25 6:15 ` Yu Kuai
2025-08-25 9:15 ` Christoph Hellwig
2025-08-25 9:17 ` Christoph Hellwig
2025-08-25 9:49 ` Yu Kuai
2025-08-21 15:19 ` Bart Van Assche [this message]
2025-08-21 9:16 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3c5067f-af90-4491-86c0-06eaa24e2946@acm.org \
--to=bvanassche@acm.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=colyli@kernel.org \
--cc=hch@infradead.org \
--cc=johnny.chenyi@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neil@brown.name \
--cc=xni@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®