From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A4D43AC0C1 for ; Mon, 22 Jun 2026 12:42:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.13 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782132175; cv=fail; b=Yaq5OG/57IY6F3ZOmmnvNsh7ZeyhE1MqDN7ma8egNeTgl8qwwF0m7JOgu2lS4FTKeZYOL2+09nbwKdmp9646e2Ns+bF4gDGVMh22SbwDHZsMw/WzAluuM9sn1QJP2kxpeIXb9+Y9xnyQrMk0QVnYID4BCVbUv13xb3TFUKP8/IQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782132175; c=relaxed/simple; bh=YOn/olnFzGyUVPVAmuZFBEtr7exqVpjm2U5BfE5m4Cw=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=de8MX6LnORnjyZtLZGdCloUfgAcDzZ++Al0tppGvHlzZtuXvo5P55HE7YiOXHbJ9KZutj0yasoGgFsUHx6sMl5OWMbu62cXImX+dtqGQ8IBIhTiYJxCbVPh/1hlA0lTpd3zJw+qu/7oplPghsxnBgPCQiej4FrBQiK/nnlcFpA8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=EFRe11X6; arc=fail smtp.client-ip=198.175.65.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="EFRe11X6" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1782132174; x=1813668174; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=YOn/olnFzGyUVPVAmuZFBEtr7exqVpjm2U5BfE5m4Cw=; b=EFRe11X63rhddwRBdNcplcLo9U1x5U65lQqjWMOO0+K9VY6dn5GUOFz5 pa8p1GhpGsDwGkP1/jObRruOm8eQbjS6OSCdTgMAaCLKRoTEai+w8FnyT uxi4HiraPFLsUzOr0pQMAxzYeoAMElEaV4lKDMx096Yt5q2eIZKT6BRHR 2cDlkwOCWfFnDJVvdg6cs53dv+iggaFu/Lgn4LyeC+wmuj3FDssWNVE8T m2+gQ+jfl+KEX8HmvLJo2UoGeVySlhw7IiqBLKMvLJEupsrhneinFVo3N 2qdct/elOetP9xUgz3uhGUWAdP+v5caTxI+YP9BGDQKQf/7DSvGYOVZyA Q==; X-CSE-ConnectionGUID: SF8qgRSdRPW8zqc1zvOCpA== X-CSE-MsgGUID: Glarn3WaTt2UhH/Tk0UHlA== X-IronPort-AV: E=McAfee;i="6800,10657,11824"; a="93975781" X-IronPort-AV: E=Sophos;i="6.24,218,1774335600"; d="scan'208";a="93975781" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2026 05:42:54 -0700 X-CSE-ConnectionGUID: +M75gn3MSFyx0PmbJy2vPA== X-CSE-MsgGUID: 121FMLFjTJ2YjNfRRotXFQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,218,1774335600"; d="scan'208";a="253118131" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by orviesa003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2026 05:42:54 -0700 Received: from ORSMSX902.amr.corp.intel.com (10.22.229.24) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 22 Jun 2026 05:42:53 -0700 Received: from ORSEDG901.ED.cps.intel.com (10.7.248.11) by ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37 via Frontend Transport; Mon, 22 Jun 2026 05:42:53 -0700 Received: from SJ2PR03CU001.outbound.protection.outlook.com (52.101.43.50) by edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Mon, 22 Jun 2026 05:42:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VzxxI0Sz+MEl8PE3dMpK2JTLp4AVWOuOUUEp21V380e++ezxCI2OgPZtuoHJmc+q8pgUpuzufaR/LPh8icah7fgXfvhFw8YHnienqYC/VldC+/ta59O40iAPyxx9qlCPzxV4aWgjf8Nrca8Sd4GU96LlQZD5zdxEKBWMZxN2PV4YkrhYHKl7X7H3rh5z2os70UyqSxJ0XKsJ2UgY4UQUHiTHY4+5wCnesY5JhmLPSoY6MFpWdpxzUeR502LiSC+jm2TkSX0hy8u4/ENz7bxnUieGnVs0UOYGhj39cJ3fg5C1oJPn6sZq4BKnZyiEZ7KbAWLL0QCg+hH0/VzvAYcvIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+L9UpmnNAlZNmNNkH/GnBiPEtCybe3HYimK5W1xmlXE=; b=hXgE7hcULFz+UmF1/FSsfdv6g1lOELy4XDhFuauK8hSc2GNXRhvxWlFrw58C930OXWylnmqptfNd/szNj7Lh1Ns/fRGmKzIEqmLWjCKhcOybDG5pz3llgRA0xErjld10gr1HxoSyIpu1ehJkhfoyhDJp3gC5dDZz0xmJjlPpfkZcACjgy419alkEidouyc9XT5QAHdQqPSVrNnS7SOsuLG4iDNKOX4zjwURu5cCGxwSpcNZlGvRk8drL19Mbb2E5MmqgwWoLJCG8cuXtzISt5Oi1G5hsh9ddz38wi+vXPtXI7k50lqHrhEBzFFffDVk8EJoC4pv10uwUmcNWr6KyIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) by DM4PR11MB6095.namprd11.prod.outlook.com (2603:10b6:8:aa::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.19; Mon, 22 Jun 2026 12:42:49 +0000 Received: from DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::3058:1480:e4ac:5765]) by DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::3058:1480:e4ac:5765%4]) with mapi id 15.21.0139.009; Mon, 22 Jun 2026 12:42:49 +0000 Message-ID: Date: Mon, 22 Jun 2026 20:42:39 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/6] x86/resctrl: Rename prev_msr to prev_mon_val To: Reinette Chatre CC: , , , , , , , , , , , , , Chen Yu References: <2e9bd6a1a012b937e9205908ab6bbb09a21e0f71.1781332698.git.yu.c.chen@intel.com> <3ee018f0-689d-4175-bfd2-dda62a4aa45b@intel.com> Content-Language: en-US From: "Chen, Yu C" In-Reply-To: <3ee018f0-689d-4175-bfd2-dda62a4aa45b@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: TPYP295CA0031.TWNP295.PROD.OUTLOOK.COM (2603:1096:7d0:7::9) To DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6020:EE_|DM4PR11MB6095:EE_ X-MS-Office365-Filtering-Correlation-Id: 90de4956-499b-4298-a5a9-08ded05bc46a X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|7416014|376014|366016|18002099003|22082099003|56012099006|4143699003|11063799006; X-Microsoft-Antispam-Message-Info: JTgWMxvTBWFHuEMegkAzEMehesKxQlNAjzyFQfVbenb3I6iZZqtJGfSMcHlegzrHnzasn23dPXSaPa4G7ZKXTIMZ/bYeIOjyPuAdmVbkj97QoGAoMUVaizZ8jVhB60jVkrcn/Mh7Xr2jJS0poV4g5GWNE/Vt1LMYsSUf0jjFHlwDRBAdNMMFmo+yKML27IcX/VHch8TrPgL1tsN7ZIvvvcOw2il+2sb0oblJU+/DWfYi4Z0f9BIsjwluQes8gqXok/soTqF78r47hyD3qtu0nEiJYzekEGSibsw1wE1EXn4Gfcr8vdqbtg9/Y1eDh/qrQ9unXb3ylq1ZbsA+035/WHBc712xGJkjcI/KvY8uzkst7Jb5/1vi+IQVAklxjtdVveIIB6rdRzNpRVvvgLmf/oHo+xO0Qy6A5y12ZBxMfPsCodkIyHZcSUtC6/UvmOI4K8XZTDEmvdfq9DXxdEff5jFtM3gA5XRmh7oT0yR/u2Ir/hwmW/DVC+V+09NeUYRwILwwqny18xQiTJzzOrNEaVTqlUaF2y3D1heFg4DVHpWojDurQKoyVkEXnxzNAM5WVnujWs6lAgLJ9Z6v7i9JyyVUraAyxtObXeTwhsNJozxVTCHxX0HqzPwP1cyEKJLa9/jo2OVBMxBK70FPSaP3O0JM1lgHyB5FLtIzedaEHUY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6020.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(7416014)(376014)(366016)(18002099003)(22082099003)(56012099006)(4143699003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWlyZThFQzNESllpNTF6ZEtucUk3SlN0cHpiOXZOUFZ6cTM2QmRHejQzMHNW?= =?utf-8?B?eUY3U0R4R1dhRk1FSTNaQTdoRkRHYy9lSTg2YlJPTTNtRWt4aU1yMVBBZCtG?= =?utf-8?B?MTlRaitYRVNsNnRNZ3M0bDRaM24yMXI2c0RqUkpSN1YzVU1ubkRQL04yZFk3?= =?utf-8?B?MDlwbUIxcFV6ZnlVTUt4SzF0VktPQzVMb0ZoQnMwb2o0bGlPb0RtYUs4Y3VX?= =?utf-8?B?RjNqbmpwbEY4VDV0elBDM2NDU2FNZHl1STUvazlsM0hWUDUxaFBWWXY3dHpa?= =?utf-8?B?Rk1oclAwQUxBaU1PbUFBMzJKUTVkQ1NsdnJjcHFDeXlJZFpsUmtiek1FTmFV?= =?utf-8?B?VnpTMEE2YVVVWThHZ295UTVkdTVNNUlKWTZDNExpeEh3MmRPcThlOEpRNUVm?= =?utf-8?B?RnpVUVdIbk5uc3FDa05EZ3hGNGppbXROL2ZwZncwVDVWdDlia3ZwL3hSc2RK?= =?utf-8?B?VnFhcS90Mm8vSEo4azQ5VjF6S0l3eE1mYnR0NTFWeEhJWDFEdHljWlA4QVJF?= =?utf-8?B?cjVZSTZtY3c3ck9FZ2FIbElHUXR6bjBEdyt3OFArRmRjc1hSZjNIbHRPclJK?= =?utf-8?B?b3pTUTQ4NmwzSDdKSm1Yd2E4aHc3QmNGaHgzMjkvaVZvV1YwMk1XSzdtbzY0?= =?utf-8?B?MUY1ekszR1dLN2VIKzFmZFJ6Z1ByNjEwRFU2N2pjbHZYYTJzTmhRYlF4cGd4?= =?utf-8?B?cUNqUVZNeFlrQTUwT0lEZzQ0eU8wVVVDMkdUbVFnTDR5UmZaZ0Q1a0VXUisx?= =?utf-8?B?Ri8ybW1VMks2bXR6SW1qdWhEcGJVS2RiSE9rZ0w5SDQvZ2VJbUhrcTRlVnVL?= =?utf-8?B?bjZTbERHdklINnhqaDkxOWxQOXF3SjR1VllnbzY3MVg2blVsTllyUVJGZEs3?= =?utf-8?B?NkVxbUV4NzJadWlhOTh1bjIwTWVlQ2hhdzVkMkZsbElIVzFBWUtrQmN2ekh6?= =?utf-8?B?NDlxckFFQ2ZOY3EweUNKZTJPeVJicjZDK3hxUTNOTDNxM3E1aDBrMVY4TjZF?= =?utf-8?B?SUFSWVRUN2Y2VXRaem56Y25qemxMUFBmTTBySnVQR1N0NllLcUxJd0E1WFdG?= =?utf-8?B?enYxYnU5d0k2WjZVRkt6R09aTEc1bVgwOTRHMEFJOXU2WWlOK0lYa09JMVBZ?= =?utf-8?B?UVdXMzNiQ3hvUkg4aXFJMHVhMmQwQjBOeVB4eC8rVUd3WDVFL0ViVzBFb1l1?= =?utf-8?B?aUxJSUtzNk5YOSs1MFJWajh1QnhPZUtJNjdUbU5oTmhUOEdsaFM4ek9odVE5?= =?utf-8?B?MllCWDhBdHNOTEpBY2dSd3p5RkJRSEZaeHp5YVA2RUZWZHpWYlk2dWtaV3Av?= =?utf-8?B?c0JkbE9LaEN3NTdZSkhHZStHNjlwamNYR1NWY0srWEpUSmZON3kycGovbUFw?= =?utf-8?B?bzFGbEk4Qkg4VkI2TWtLUXR0eHpDc0VVWmtDQmpPZ0tMeG5Jd2RGNTBWS3J1?= =?utf-8?B?cktGUHFTK2ZEbkt3ZmJlMTB6eDBaeXdHdVZWOWcvK2dCY0pTSy80VnJ1L1VP?= =?utf-8?B?aXAyRU1abVg1RkpUV1ZZYVdMeVA5Sm8zaTNxK0RBWXRRWlNJNFZlSU1xSEg2?= =?utf-8?B?WmRWQk94VjJzYVlTK1M5QStNMmZZY2R0ZSs5bmJTcGZLSWY3bjNKNHZvblNW?= =?utf-8?B?UWx4aDVOK3VzS3BEdGM3UWtGeS96THNQcjJEeVJsNzdqRWVDdjAwaXlUWTcv?= =?utf-8?B?R0t5aDBGWmVNeEdENXNlYzFGajdJSHZVTXZnSmt3S3N3Vy9YS2RXR1M4S09z?= =?utf-8?B?NUMyZWxCejhmdG5kNjhzTjdzRDh0TkhxS21XT1AvcUNhMHBocEc4SmVMSkVL?= =?utf-8?B?d2R5Y1VJMEdHbGpVQWRra2dzK0hSOXNMUTZta3hrWHgxMnViaEMrWHp3MmxF?= =?utf-8?B?YzF5dm9TdWk3OVRaMnI5STZmUDFObFJRbzhhemhPVXFqVjhWa2RNbTVlWThw?= =?utf-8?B?UHdZMitlSlFrbGhYU3h0bUxkRjE4VHFkc3VWWDB3Y2NkUHdxZ3pGdlI4RGV0?= =?utf-8?B?M2RIbXZFSjhhM0dZRlV4VitRSHROcW8rZ3dmdnJPRUllV3BITCtDYm9manBv?= =?utf-8?B?MDZmek0zR2NnTFRrc25nVThwR3pIVWdKS3V6Y3lWNHV3ZXllZWxueWxucmRJ?= =?utf-8?B?dzc5aHFGNkIveXdmeWtwQ3VoT04xMnZsRmM4VWRodzV4M0ZWdjlWT2Jpcjdi?= =?utf-8?B?Zno3M244MHBWTzVvNXlOelo1TlZUa2VSRVNqdjBJemMvM0hVSmdnSEtwYUlL?= =?utf-8?B?V0tQSFpVUHRHM255TDFNUVpVQUR1UHZHcVNWeEp0bVM3MnBpSFdGNEowN3Vk?= =?utf-8?B?bWd2Nkl2L2w3YkgyaXJrUjlRbzRpc2FvMVZMOGlaQmNjQWh6bzlpZz09?= X-Exchange-RoutingPolicyChecked: WwLU2Vou/os7VijY62QcAISS8DAPxUNja/ajN6AIOvlW67ylkKzvqxMj1LZRO5n59Qcvbv753Bfc4pjMa2bfbpCQawSMY8P2t5IJd0LRRHNN70U+lQkaEvsz3VvVoxWB/1u5iGBmcIhcgeE//41dP7hy1zvNo6slB0yu0SgxdZGOs4gNdwxyYoaOpVWGUqhEIXIaruIPfvcliukZscxyh3NepgbqppUogrRcuPATe/tT/CRyyyGYaQ7OS4D0iqNFQrQRUoJbMsGEqgZUQk72MmM3oiAaLcLeWwP3PRMguiwldnz3z5CpjWqelrt8DfOEIRjyc2inNBwx2f8jBVD7iw== X-MS-Exchange-CrossTenant-Network-Message-Id: 90de4956-499b-4298-a5a9-08ded05bc46a X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2026 12:42:49.1765 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UCsXO5ELVTYCB6m/UiQxRPGa2oxlQbTM5vN7UVfa5ctzpxFTmbo1j5jKD8PX+x63nVbltqoZrOL+0bNugAFe2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6095 X-OriginatorOrg: intel.com Hi Reinette, On 6/19/2026 7:39 AM, Reinette Chatre wrote: > Hi Chenyu, > > On 6/13/26 12:57 AM, Chen Yu wrote: >> Rename the prev_msr field in struct arch_mbm_state to prev_mon_val. > > This change as described seems out of place when considering the following > from cover letter: > This patch set focuses on the first part: enabling MMIO-based access for > Cache Monitoring Technology (CMT), *while CAT/MBM/MBA are still using MSR*. > > It is thus confusing to find a change related to switching MBM to use MSR > in a series that claims that it does not do this. > > The patch looks fine but reading the changelog and the first few hunks makes > this patch look out of place. Could you please update the changelog to be > accurate about what this patch does? > OK, let me change it to: x86/resctrl: Rename prev_msr to prev_mon_val Rename the prev_msr field in struct arch_mbm_state to prev_mon_val to decouple the field name from the specific access method. Use a generic name for the stored previous monitoring counter value so that the field remains accurate regardless of whether the value is read through an MSR or another interface in the future. No functional change. thanks, Chenyu