From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFB6015F32D for ; Mon, 19 Aug 2024 10:12:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724062343; cv=none; b=mWt6BiTKWby74z0mMZsPWLbsCkrxF2r7IkECgCTR/kSUqmYpfgXYVcppciMYcVR0FNOfwY83jJ0lMhmhmgjJmy9+/ORYuxBCEGoL1fviIWDGSkSRXky+xa4YkAJko4ppSuB1ep68VAkj4dE7p0TLWmWyCU6WNX5ogqvV1GeXCaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724062343; c=relaxed/simple; bh=/ghlRPw7Tuu3E6xgtqsVeIXHB8YA6tN69TVusu8Ea/I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Re6QrJilV5HAnL5GyI0GB/bOpQ2r7WdsNsETItEZZWCRGE4p2WYjXw+yUKxDgtt73Pa03XGDq/aCZFTaSYRNPBIuqUMKXRLXVPJqFwuxylXEZGX6nadEy3dwTMRFC40stt8r+w66G5KrfRj+L3D8j4G7Aw0g6uW6xjYcj5GzRCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZfbVLNe9; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZfbVLNe9" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-42819654737so31878125e9.1 for ; Mon, 19 Aug 2024 03:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724062340; x=1724667140; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=u01tN3aVPRz7WiKLoD0/+oPhy5rtcvmG0FA6+cZ2cQc=; b=ZfbVLNe9rffrhwo2UUVykmH17138ANMwfmd8EpI81sSzQdNjXOaUtbJUysDFSXF5Hf GSrctYhA7/YYcRqvg/wDIwtnVGOwhfRv8xjoyrpIf1uSe6dFXVZXFzDiF87Gx6lV9Kyh TqE6M287MM6lzukbiYXW8qdOBwJlW4eC0yQo5wf4QSgAGPbhtylPWOmNNQYPkX9WeL1m Ob5nXlE9nO8UU7SHY8joFMiJYD5cPwkJahzGs65e9YrfEBbEVVsSphqYGYT9i6ipdYYC TQHjcoZJc7OB6b01mDROPDcWE1YnVElo4wr/F9Ersl/Gad9mfrPUy+qulnKQcp2aR5xV 1ARw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724062340; x=1724667140; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u01tN3aVPRz7WiKLoD0/+oPhy5rtcvmG0FA6+cZ2cQc=; b=SCFxLdpk+F25RC46zjSWJY8uNwXFSdxfikvfGtuqoMCwf7uu6elATrCsQPzIV139uS csEAvLwFzHmhUrQsR29MGJ4nsgcqcrulidhTL/TVJLpaXXGHkPT6CaZI7oRzfSd3RGlG ir6MMHPGbSOGkD0vhT4uDsqhwA+A0WNXJXlWjvECdol5KpjYe6hkR2EEBZ5eJLx64YpQ tP0sbPk8LOTd6BChyWUQAWf8zgixKQsmDC07QnJ2YzoE2dn36tr3NHUedPNkQGEwodbD Mpm/j9yWdpd2yo0SQUh00fq4GSRAWZDtfn2ViwfFlmc6zuAvRgODfRpUbNOjdFjooWir 2h2w== X-Forwarded-Encrypted: i=1; AJvYcCUpEW5Cy1er4AAjkJI9aAHmYphI8v2X2BAS9rt/XaaSyMjK1JBm7sSdC8BNGrDd8ef4fQOQW/aioVCN9rb7soJQqD/XaF4WjhkVnoW/ X-Gm-Message-State: AOJu0Yw+RJhLRzjiOdqT+fGCGbyaYxR0bacXVyvFjpNjKXlEAbH5AM44 gZFGW2MyXgG2GguaNjAIGhv6AcKm+5siBDeVaVB1Y5Mg/lMzzmtZxOpuxyGy/hw= X-Google-Smtp-Source: AGHT+IHu+N6/2viMLzlmeJTksGmRyS8v1GlaliV8j0cpbt9bMFA3jAFMaaZXMRXUvn8ECUs599nhQg== X-Received: by 2002:a05:600c:354d:b0:426:5dc8:6a63 with SMTP id 5b1f17b1804b1-429ed7d19e9mr62670535e9.30.1724062339473; Mon, 19 Aug 2024 03:12:19 -0700 (PDT) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-429d877f234sm163622105e9.1.2024.08.19.03.12.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2024 03:12:19 -0700 (PDT) Message-ID: Date: Mon, 19 Aug 2024 12:12:18 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] thermal: of: Fix OF node leak in thermal_of_trips_init() error path To: Krzysztof Kozlowski , "Rafael J. Wysocki" , Zhang Rui , Lukasz Luba , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org References: <20240814195823.437597-1-krzysztof.kozlowski@linaro.org> Content-Language: en-US From: Daniel Lezcano In-Reply-To: <20240814195823.437597-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 14/08/2024 21:58, Krzysztof Kozlowski wrote: > Terminating for_each_child_of_node() loop requires dropping OF node > reference, so bailing out after thermal_of_populate_trip() error misses > this. Solve the OF node reference leak with scoped > for_each_child_of_node_scoped(). > > Fixes: d0c75fa2c17f ("thermal/of: Initialize trip points separately") > Cc: > Signed-off-by: Krzysztof Kozlowski > --- Applied, thanks for the fixes -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog