mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aleksander Jan Bajkowski <olek2@wp.pl>
To: Andrew Lunn <andrew@lunn.ch>, Konstantin Meshkov <skyline@mail.ru>
Cc: netdev@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Christian Marangi <ansuelsmth@gmail.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: phy: marvell: add LED support for 88E1116R PHY
Date: Fri, 9 Oct 2026 22:40:12 +0200	[thread overview]
Message-ID: <f3d2f5e0-f9a8-42a5-ad83-07be215ca690@wp.pl> (raw)
In-Reply-To: <1bef1633-8213-476f-a019-f29a71553e09@lunn.ch>

Hi Andrew,

On 09/10/2026 14:15, Andrew Lunn wrote:
> On Fri, Oct 09, 2026 at 09:08:29AM +0300, Konstantin Meshkov wrote:
>> The Marvell 88E1116R PHY (used on the D-Link DNS-325) exposes its LEDs
>> through the same page 3 register 0x10 LED control layout as the 88E1318S.
>> Wire up the existing 88E1318S LED handlers in the 88E1116R driver entry
>> so the PHY LEDs can be described in the device tree and driven through
>> the LED trigger API with hardware offload.
>>
>> The LED polarity is configured through the led_polarity_set() callback
>> shared with the 88E1318S family.
>>
>> Signed-off-by: Konstantin Meshkov <skyline@mail.ru>
>> ---
>> This patch depends on:
>> [PATCH net-next v2] net: phy: marvell: add support for PHY LEDs polarity modes
> I've not be tracking. Is this merged already? If not, please resubmit
> once it has been.

I was expecting that Konstantin will send a patch that only adds support
for LED triggers. This patch should be simple and I expect it to be quickly
merged. Then I'm planning to include LED polarity settings for the 88e1116r
in the next iteration of my patch.

Best regards,
Aleksander

  reply	other threads:[~2026-10-09 20:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-09  6:08 Konstantin Meshkov
2026-10-09 12:15 ` Andrew Lunn
2026-10-09 20:40   ` Aleksander Jan Bajkowski [this message]
2026-10-09 20:51 ` kernel test robot
2026-10-09 20:51 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3d2f5e0-f9a8-42a5-ad83-07be215ca690@wp.pl \
    --to=olek2@wp.pl \
    --cc=andrew@lunn.ch \
    --cc=ansuelsmth@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=skyline@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®