mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Prashant Malani <pmalani@chromium.org>,
	groeck@chromium.org, bleung@chromium.org, lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mfd: cros_ec: Add usbpd-notify to usbpd_charger
Date: Fri, 20 Dec 2019 09:55:11 +0100	[thread overview]
Message-ID: <f3d6267e-2429-e5a0-2a0e-60cab5bb1bb9@collabora.com> (raw)
In-Reply-To: <20191219201340.196259-2-pmalani@chromium.org>

Hi Prashant,

This should be [PATCH v3 2/2]. All the patches in the series should have the
same version otherwise makes difficult to follow.

Thanks,
 Enric

On 19/12/19 21:13, Prashant Malani wrote:
> Add the cros-usbpd-notify driver as a cell for the cros_usbpd_charger
> subdevice on non-ACPI platforms.
> 
> This driver allows other cros-ec devices to receive PD event
> notifications from the Chrome OS Embedded Controller (EC) via a
> notification chain.
> 
> Change-Id: I4c062d261fa1a504b43b0a0c0a98a661829593b9
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
> ---
>  drivers/mfd/cros_ec_dev.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index c4b977a5dd966..1dde480f35b93 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -85,6 +85,9 @@ static const struct mfd_cell cros_ec_sensorhub_cells[] = {
>  static const struct mfd_cell cros_usbpd_charger_cells[] = {
>  	{ .name = "cros-usbpd-charger", },
>  	{ .name = "cros-usbpd-logger", },
> +#ifndef CONFIG_ACPI
> +	{ .name = "cros-usbpd-notify", },
> +#endif
>  };
>  
>  static const struct cros_feature_to_cells cros_subdevices[] = {
> 

  parent reply	other threads:[~2019-12-20  8:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-19 20:13 [PATCH v3 1/2] platform: chrome: Add cros-usbpd-notify driver Prashant Malani
2019-12-19 20:13 ` [PATCH 2/2] mfd: cros_ec: Add usbpd-notify to usbpd_charger Prashant Malani
2019-12-20  0:13   ` Benson Leung
2019-12-20  0:48     ` Prashant Malani
2019-12-20  8:55   ` Enric Balletbo i Serra [this message]
2019-12-20 10:52     ` Lee Jones
2019-12-20 19:35       ` Prashant Malani
2019-12-20 17:32     ` Prashant Malani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f3d6267e-2429-e5a0-2a0e-60cab5bb1bb9@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=bleung@chromium.org \
    --cc=groeck@chromium.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmalani@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome