From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756225AbdKCRge (ORCPT ); Fri, 3 Nov 2017 13:36:34 -0400 Received: from mail-db5eur01on0052.outbound.protection.outlook.com ([104.47.2.52]:60670 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754823AbdKCRgb (ORCPT ); Fri, 3 Nov 2017 13:36:31 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=cmetcalf@mellanox.com; Subject: Re: [PATCH v16 12/13] arm, tile: turn off timer tick for oneshot_stopped state To: Mark Rutland Cc: Steven Rostedt , Ingo Molnar , Peter Zijlstra , Andrew Morton , Rik van Riel , Tejun Heo , Frederic Weisbecker , Thomas Gleixner , "Paul E. McKenney" , Christoph Lameter , Viresh Kumar , Catalin Marinas , Will Deacon , Andy Lutomirski , Daniel Lezcano , Marc Zyngier , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1509728692-10460-1-git-send-email-cmetcalf@mellanox.com> <1509728692-10460-13-git-send-email-cmetcalf@mellanox.com> <20171103171801.xzxyypt3axyawu7l@lakrids.cambridge.arm.com> From: Chris Metcalf Message-ID: Date: Fri, 3 Nov 2017 13:36:14 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171103171801.xzxyypt3axyawu7l@lakrids.cambridge.arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [216.156.69.42] X-ClientProxiedBy: BN6PR20CA0057.namprd20.prod.outlook.com (2603:10b6:404:151::19) To HE1PR0501MB2764.eurprd05.prod.outlook.com (2603:10a6:3:c0::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 27fd6148-b436-4f5d-f66f-08d522e168e9 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:HE1PR0501MB2764; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2764;3:IYqkDj7k45xqVEWYciPwl3TKJyakD2PEnLCkHekHeqY3nIpqrAl/eIm1ozsnqxGuNJ8+eizrnVaurD1J3U1Ggs/ZO98On7xFwVKEbAi0qxKev8QxkWG6OsfyH4iEfv6IOFr68U/91WUVXbGCvqzsgKFgpvKz6KzKOjPyRT7iBZDiKElQlhdVey/WqwX+RIDnRp0XAMCPfsF8UPnIoMS8AwGPhClq8BBhsARWXofK/9olmwT859RVQP2vxRSuD9wm;25:kOEV7Faqmn97dFTLNAZ0iVIv7VF+zw5fF/gq+yKpk7TRwXYVSQ0PZUsfB0voPPAkMT9OsVTQv6vLrPg6tdjAedLvS55TXFL2bv7+3YQCGW5zTH7WGVh+aywXhOJ2nq9qQj1LjMrlG+oaw3H5bkbAjfOVkh1k5Y6ZyQEExakjFI1eGIhrSaL62TYp05njdqLr/q4+a8p5mUiwwN/IjJC3GuECv6iK2N/2I3Uwwjyy+WSrz55xIKeDWbRK/2osn7qI96K8dpXN9n7WRhZhXLncVnC7BnVlXlFcRF6PCxOz9rfXB/R1bkgT43yaT23D5+hQm4TjSElksrUpRPlfTUaq5w==;31:xb7jPrTHWv4R/VxPLXEY4aMhlYYa96abIi95ygmmMXmRqafx2Sb4yUCWGSucc0gDOFdZpEYPvpQHO6p5IrBunQDCfsTSJJ6ber2c+EMSxN1spXsDjXBh4YoDL4L7Xt8xovi5nyVpkpYfolK44ag4ht/HtbvWr+kGhTXLgjLOEL03q+Xtyitdx7ytQ8XjwEKia2VhdZGcFNGQc1OedybMoSdG9NdDeE4Vjg3t33s4xOo= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2764: X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2764;20:PAzJ5jTXjF/ivBogNahZ8Ufvtlz8QWqo1yyviz9zbavNjIymLf7M4aA6d8B9N8OLErb9bLDYjtKXQSEoln/nZQfXe4o0iekjYC4NYmbaKRtSl4MM5abQ9Np8TskOscfQ3Xtf5g2pDVFiwYubixt1pdLgpToD4mURhHZvLs9FOxigHH3QyHmkxwz4xtjFuolHlKUHQgAUNDrcUBeFIZ/UsEvNJKLRDnfGhxjIpDQdVhZ/sBcrkSOuDirq2v/bH20pCuZlGjdkXGDOyLtdi6XDI3OHT60mBvTW7UxwLJCGyA1pDbqCYpqFLD6YMdqkiwdU7u1eeMdBjUrXsByh7y7ODd2lXMfyHeLPjU+fugQ4zh/l1CvBEjpyzggpHlHWrom6sdMvWPcOv1+bxI/BrvG6xUwaUrRCm9yYsVHgWoWS0rDhGONKt4EOyZ+tw77PtO6jVFEOUrB2bdHQBe5UVDB93j/amsCaca0l9jxJjBEYPUMzmBn1EymDz/CTUclr10jP;4:9XRw/UdZwMNVeTctDawqYyNMpWa9UFMErGXz6FiSS0e/HS1+yvU6rds/XSJQM44R9mTe6m64R6n+9OtTeU2n3Ald9CER7wprWts+tRo8BQYfU9eqdAR+o4dDUIIOBGoYL8rERglPOnhCnHbvBk5IU4J5eFKkpkLZm8poykQftyClvFl3i5/lpy/iXwTzIJ6PrlvjF8Hgltg/dxf+S24j3cCpuDPFkIerWDsU1NBuIq6SfJNdOY4f7EE5tlkkPgaMLVsXvwBH+XXy6f/XDFOzs81Lgbk0z4/LgH1deRrvRWG81KUDg/9UZaZum+ZPLmPz X-Exchange-Antispam-Report-Test: UriScan:(171992500451332); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231021)(3002001)(10201501046)(100000703101)(100105400095)(6055026)(6041248)(20161123562025)(20161123560025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:HE1PR0501MB2764;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:HE1PR0501MB2764; X-Forefront-PRVS: 0480A51D4A X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(376002)(346002)(39860400002)(24454002)(189002)(199003)(81156014)(68736007)(16526018)(64126003)(65826007)(106356001)(83506002)(77096006)(39060400002)(189998001)(50466002)(6246003)(4326008)(101416001)(66066001)(31686004)(2870700001)(65806001)(47776003)(65956001)(33646002)(105586002)(5660300001)(81166006)(8676002)(2906002)(2950100002)(6486002)(6666003)(229853002)(6916009)(31696002)(305945005)(53936002)(3846002)(58126008)(6116002)(7736002)(54906003)(478600001)(7416002)(6306002)(3260700006)(316002)(53546010)(16576012)(50986999)(8936002)(97736004)(23676003)(25786009)(966005)(67846002)(76176999)(54356999)(36756003)(86362001)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR0501MB2764;H:[10.15.7.185];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA1MDFNQjI3NjQ7MjM6azBWQjUxZG1DZnF1TUp1Sm5MVjMxU2NW?= =?utf-8?B?UEtSZ2IzUkFLQzJoTXVrby9HekRrTlE0eWJrRDlGMHNnSnZYVURYd1d2WDhh?= =?utf-8?B?ckFneEozdzA2QXFQeXk0akRVUWhYOVE1ODRlYkV4OG5WYmJlKzQ0a2p5d1Ez?= =?utf-8?B?OXRVdm5HVlNQUVNkMjdJT2dyNXprRW1QT2huQndVdHhoWFRCNEU3Z1gwSlky?= =?utf-8?B?Y3V2ZVpYL0JxeTUxK0l3NUNsNmxqVmJkS0FYaTJOdDdaRkRFeEh1am0zQ1du?= =?utf-8?B?c2M3cUhSWW5uWENyMjNhTGdtSmlXK1BXMnFMUkNRTlRNKzd0U0svdUxOaVRH?= =?utf-8?B?UXNhQjFpam9RNTd3NnJOSHliUG1qVk1nS3FCOFliQ0Vram80TUxIdUREN1Bk?= =?utf-8?B?Yjg3ZkRoSUQzOWZtby9zbTVBV3RCak5OQlpHVU9EN0NXa25WZXhqVTlsbTJv?= =?utf-8?B?SXdjNzlhQmw2RkZQZlRGRnNaRGRRVmxNZWdSS0lWcnVGN3dGMnRrd2dKNlh0?= =?utf-8?B?V0I4MDlmSkhobE1HZnZDbTd2L0lxVWRsdEswODIxbVM1c2o0QWhIR0QzenlK?= =?utf-8?B?V0x4WVFzRzhhWk5IU1ZTdThPUjhnZ0VUam1WUDhDZS9oREdDSTFJY1ZwYlQz?= =?utf-8?B?Y3Y4RnZMODBoQnlDdHppRnExSkh0Tm90VFgvRnlZeCtVeHZpNjEvNTMyaTJK?= =?utf-8?B?cUxRdkFXMHRRem96SHI2eEErQTZuNW1VQzJMQ0t0YjRJdktjZFJrT3BIOUxh?= =?utf-8?B?aDNlVjVFWDZreEg2dXMxWGhqTjJxbGgzYnVnRjdYaE54cHhQQWlKL3IyRHN0?= =?utf-8?B?aTB2UG91MWFXLyszYmxhVEsvVDhrSFp0Q3NFOGVaQ3AwYUd2aHlNMEd2NnBF?= =?utf-8?B?NUVPTktUdVhBZmJySFpyYXRFZVZ0VkN1TUlFazRYNDlZSHB1SGZURnV0VHRQ?= =?utf-8?B?Qy9Va2I1WVJjU01TZnFXdDZZVVdTTVdiSmQ3cmRQMG1DQTZXRDVzRVJkczVm?= =?utf-8?B?Ty9PK2k0WlhsNUROMWlhMUtoNGZjUDJYZUlHelVRcktpaW5xc2ZncytEQkQz?= =?utf-8?B?cW1XYUZvVmxkU1hXeS9wSTMxTmRmOUlXbk93VzZNeGQvdFBkMDVIZEZ0UVhw?= =?utf-8?B?ZU5Gak5uWWpvK0NidE85ZERkVWFxNjBSYkUxLzJKbThmaTNyK2Fycjk3b3ZJ?= =?utf-8?B?YnI2bEZLeWJQNXptcTVvV0RDQW1OTWU1Q1J1MW5VNjZlbFNoNXhxRXdDTE9h?= =?utf-8?B?cjZ3WkI2L3ZxQUhRS0J2ZXBPenF2aUVTNGpZSWo5VThoZmtvcDFiY0JFdnIw?= =?utf-8?B?R1haTHVHTFFwdDZtNTFiaDhVTGRwRDVBV2pjcXl4RHlnWTQ0KzdMM1Bncnp4?= =?utf-8?B?ZHB5MVNhdUVibUEyQ000QmxKbTNxT0cxMXhZTWgrRC9DQUhNWU5Sd1dLcUQ4?= =?utf-8?B?ck5SY1pOZWFzOVYrR2NqcElENkxlcmRzdmI3UW9Ma01qckJkc1dDK25GVDds?= =?utf-8?B?WG5qZmM0dTc3bW1mVkVZWmFCVUhucmhpQzkxeFlicXdDWURrbnRWbEFDTWtK?= =?utf-8?B?a1hBdmxMVm9TNFpUT0R5dmJQTDVhcy9QQlBDdkZDZzMzU1JLcXBvZWJTWlg1?= =?utf-8?B?dXNHeFJPUm5QVHJOTWdtOGNrNnAvc1YvSCsrSDBaeFlSTW5jL1h6eHlMbDJa?= =?utf-8?B?TTBtNVp3V1ozdkFvUitaMmtITTBJZGZrdGJyZG9hTFBmZE1NaDBkVGsyUmF2?= =?utf-8?B?WE52OEM3R3NjaE5IdlJ6Q3JmOG1qZEJFWVdSa1BuVVcxc3NqY1p5MVFtZHQ0?= =?utf-8?B?dmU3WG56a21kQ05BYkRLRUZmTVlNbzAzTXg2K2dQUGhGK1VMaWFhNzBQS08x?= =?utf-8?B?WmpxR2ZxN1Q1S0E0a0lmRzd3V3MwV2FsY1hqVm5pbDE5NFRzM05DYWhNd284?= =?utf-8?B?L2dHZHVmZVpFRWdON0lHSEo1SDhjTVhuYlllNmxFNkdkTFBPdkpQdm5iS0lx?= =?utf-8?B?RDYzUHJUNm9ETDd2YVVta21HMFIrVzFpRmNRalVnZ0NGODROM3lIazJkSEVz?= =?utf-8?Q?3kY8vg=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0501MB2764;6:jvnAOO8fPnEwfPSgPedI1vfyJLrvTlKnj5cPGUlv2YR885C/3vYLunLkHa3MvrP4YTikbjeZ42jJpSGoTJqJmdoBXKdidyv+w5SBfrjW5XAg39eg+uGaKfT4lF4tOc3nyfPgCSThOCEQrI2/LC6wlmThlLqYnHshID3c21ChqzTW3f4/s1vMIKyVw9ZmSfkQQkhjiXanJc0IBj3Zeq2yPNfgLOrqbCpzBUnRJ4GesXWn+DFKhBU3zuHxBc3ANzifIu2xF3rjkhvmPuWvq3Imez7bETql8lt9A/wX1DthAmnXWN4XokXyleo5+DwUAjPIox1j4Edr3R6RChluPkXFQEaDrTlKlDjiKzBG9Tq4Gp8=;5:eFCMN0N1c4/8x1Kd8onst4s6sUTv1ttytWQjJ+2E0LRiGj5d+nUyhkQYrEndRz+Ghq3WknnmGrsVYL/BXSos6KZ5kjv3dc2mdvJ6dmX58yp7BNBmGqQ4fr/VAy89bJAxfYR9VNp0dwukAOE2PGqJXgMv4ruFAtIrI5AVbzqlpVM=;24:wflcNJ4Y4CI7mnvUhqeeF7AUsoGWhpbhmsRnNv1kYFuBfCeIKvrpzMbRkxDcxWCMmeq1U+M/nBsS2vJomDdNJcW+26HPcQ6gQqpHm/DRubA=;7:+QMotkP6uaFaCkgMdpy87m4KbL+a2GAilu+e7VRmefLvvAlNmcj0F9NdpC2+4CfC9Mvp8gWC9/71IziB2LnH31k+QUP0/hAGHa/5gV7dhRsjJkVX5NkO6KQmPZiz7tpHkUpapVNni7d99JJAnZeQrhA2g7S700cD6ZNZrPIoCn911/0tYYG/LxqRj/YO1+onJk/3EA9/8YxBbcc5YFoZilaInI+vmMC3Nm6koX4cjZxM8LihF8n1gbth2xeC409O SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2017 17:36:23.7349 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 27fd6148-b436-4f5d-f66f-08d522e168e9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2764 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/3/2017 1:18 PM, Mark Rutland wrote: > Hi Chris, > > On Fri, Nov 03, 2017 at 01:04:51PM -0400, Chris Metcalf wrote: >> diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c >> index fd4b7f684bd0..61ea7f907c56 100644 >> --- a/drivers/clocksource/arm_arch_timer.c >> +++ b/drivers/clocksource/arm_arch_timer.c >> @@ -722,6 +722,8 @@ static void __arch_timer_setup(unsigned type, >> } >> } >> >> + clk->set_state_oneshot_stopped = clk->set_state_shutdown; > AFAICT, we've set up this callback since commit: > > cf8c5009ee37d25c ("clockevents/drivers/arm_arch_timer: Implement ->set_state_oneshot_stopped()") > > ... so I don't beleive this is necessary, and I think this change can be > dropped. Thanks, I will drop it.  I missed the semantic merge conflict there. I extracted the arch/tile specific part of the change and just pushed it through the tile tree. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com