From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4468D2222C5 for ; Wed, 8 Jul 2026 14:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.122 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783519408; cv=none; b=mqfAX+Fh3O78ntGzupxVN/Pc1IPLol6puES2+VD0ALBVBTM+Z2WTqGYn9v5r6RLrQmjhTYL6rytRbNjU1kRbmgWEEScyLDo/+3fYdXJcW5s295DbrfmsdTiuxqsUx1kxELAcAx3OazP9TFfSp9NOtB+a/aeTaeEUxVDX12+54U0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783519408; c=relaxed/simple; bh=kuIMHQ3y/ccZZTUluDnRPE4B8AA6Wki3j0DzkfgNf98=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=qyPCgoRaud/pKny2SD1q7+OBkBliGNScXxoK0bVQUaAa48QYnzEdAN0cYyVOowFEZZ/5Rp643agV/91ue0kQCNPo3D3T0WOSoDeS1NOn1w/0dy1hKumZrHu4w9k2ehtqnFzRPjvdfmG5zwfrbk+LyTcKxL2Mw3udqCsW8EvJNN0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b=B76GdCSD; arc=none smtp.client-ip=185.125.188.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b="B76GdCSD" Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 04DF83F5D9 for ; Wed, 8 Jul 2026 14:03:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20251003; t=1783519398; bh=TnbkErJ6pkrTykU2gTiK0LYVxP5b43GJ8MOXtN09RnQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=B76GdCSDtgeuo3mlkzRzEjPwhul1MdYGDnWBSCh7QEVv8SjngM+VEbzWfhV3s59UZ CXuIcjJsC0Ic/XfPB94jmq86HEh+cMeKxgUYmhWgY2PahDQ1knMWKNk950mLTd3Bq6 21LyFbNd2Fw6VPFwNRuIm+zWWc8VlKHHIjLY9bO1QhRAJnuykiJB2BFk9aJvp9s8O/ XUOAP1W+6kjoUNHvE4ZsADo2cKSuIsWd72QPtMyzjLKN0C5l1YHS3TN61SCLvLmevf oFWibo3IgjmRAWW4M7rbVuAiFQoSYKhKhp+f/B88Wn0HaJGIYMUI17BgKLbd1YmLLI bY8qvoKqcr9V71bCOoAbxDEOj/gv9WFoX77zWYDIgcZ6uD99/pndiKtSRrElT2XLol SlZ0p4g5UaxUjqfeGfk3QG0CzT8q7GS48AL01r7+AvP6dIXRE4eGWv4H9XCLO/kLjU +xqbosTn9YmrqMKmi9m9I46rriBEzknh8BnH4/TwNHBIU7/P48wT6+7CrTxQ2bOigM oPDL0KLyu+bCAOAE/lC/g7CPRx4z6Axwf2/3c/qFW92Fr4JgU1tIMVeToEpsRuHOly zRoiKY4Yi6snd3ZZN33AVul9joGABrHvW1fVWimFjt+bCGnunuR6eznz5Cn1/hr21W YE5h+WQvLsWHkj8XojCSlG4w= Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-96925fc24a6so762566241.3 for ; Wed, 08 Jul 2026 07:03:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783519397; x=1784124197; h=mime-version:user-agent:content-transfer-encoding:content-type :organization:references:in-reply-to:date:cc:to:from:subject :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TnbkErJ6pkrTykU2gTiK0LYVxP5b43GJ8MOXtN09RnQ=; b=AYZv9qF//v+XT1oNaJYBwYhFupUL6UlkLwqPDeybbNQJM9cAhf0PmgWs2ZccscCIU4 Ww3BQg4Oe8GDORSbvjwFKwUqH2iBVY+ciH58XhVHu9l4A43/lWWmpT/9JO4PLPrUMHx+ nOkQY+upQPu2t9lafJ0cTsFRNhKVGQS0Hb/iBBNRPEgh8mYpfcDqPVCkytj10dIiSg1P UGk36NRP8I+5qJ64m6PBi0F5Nhh19blURUEpjh8rl5KTS+zRQdnWcPaMU+aKFjmpamip xV247PaneNZ3f1sVsP7uepUm64jDyWA0AThfzIjlpd7aeX5/zswE2kew0YSYy+8R+wK5 yYpg== X-Forwarded-Encrypted: i=1; AHgh+RrJFK+wFp8jW6TTXGkvjFTdvnH0YJQ6/H2Zt3rsonbVwAz5n3rbRVAE0XQT9UQC0z/QJ9bJ32faMXkdIdw=@vger.kernel.org X-Gm-Message-State: AOJu0YxsF4rwYKnJ6wA399FKuqG5toUASzUz0mpqIgxuoN4kNtaxu+Xc F4WEtpfGvElJkNYxCsRCD+Hvz7HvNGXf7rkAB4jNQyhtcuaP62WiGfxGl7yBzUK+wWaxQu0sbTo DBEg6yJphZBgJntecZjrfuXI5qClyPj9H0+7uxZwHySpKgZ7Ogrk5pse4Eg8x/dD/FdoqZWfoPH 9ybbEePCzYa6MeGQ== X-Gm-Gg: AfdE7ckeKDSLDvOOQVwX3rq5YosT2CXsJm0La8JbZkA5LpsUukCG5raMBRJNIxaD01g t5qiyRx8Ev5WoK+0xHkc+2a1Y0Yuh+xhqUXcDtqJgNcPYw01m1dazDv66nxv0oidE9cDNASNSAi K6E8XKG/guOl1ie7HhnmUCY9ll9ojq6+z/V8qMxZArH1tluTZPKm78i3i1bYF3H33wiW8a49IQ2 1FAgtsLf7NDasmTVK/WAZpEZXXrbWxqJxNlEKM67DwZjB1U3j/bgZfDz217aKCa93r/+tb1Pn8z thWVugcDhtpreZF/EJHaeiL22JCFHPtaWrPvHNgoyiVvpybGO2ilMC+x3UpEs7x1wi5IvbM5NrD IB7AdPMYnPGXNFP5sXUsSnmokxuN6JjU2b1hqafAuvWL3NNuo0SXoeEwd X-Received: by 2002:a05:6102:3e93:b0:737:d2e8:d64b with SMTP id ada2fe7eead31-744e03ca766mr1372088137.20.1783519396608; Wed, 08 Jul 2026 07:03:16 -0700 (PDT) X-Received: by 2002:a05:6102:3e93:b0:737:d2e8:d64b with SMTP id ada2fe7eead31-744e03ca766mr1372000137.20.1783519395894; Wed, 08 Jul 2026 07:03:15 -0700 (PDT) Received: from [192.168.0.106] ([138.36.35.75]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-744d6deb2a3sm1693152137.8.2026.07.08.07.03.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 07:03:14 -0700 (PDT) Message-ID: Subject: Re: [PATCH] apparmor: use SEND_SIG_NOINFO instead of NULL in aa_audit() From: Georgia Garcia To: Oleg Nesterov , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" Cc: apparmor@lists.ubuntu.com, linux-kernel@vger.kernel.org Date: Wed, 08 Jul 2026 11:03:08 -0300 In-Reply-To: References: Organization: Canonical Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.3-0ubuntu1.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Oleg, On Sun, 2026-07-05 at 18:52 +0200, Oleg Nesterov wrote: > SEND_SIG_NOINFO is defined as ((struct kernel_siginfo *) 0), so passing > NULL works, but: >=20 > - this works "by accident" and looks as if the caller doesn't understand > the signal sending API. >=20 > - more importantly, this hides the usage of SEND_SIG_NOINFO from grep, > and this is really bad. >=20 Acked-by: Georgia Garcia > Signed-off-by: Oleg Nesterov > --- > security/apparmor/audit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/security/apparmor/audit.c b/security/apparmor/audit.c > index 4a60b6fda75f..15e42e96b163 100644 > --- a/security/apparmor/audit.c > +++ b/security/apparmor/audit.c > @@ -192,7 +192,7 @@ int aa_audit(int type, struct aa_profile *profile, > aa_audit_msg(type, ad, cb); > =20 > if (ad->type =3D=3D AUDIT_APPARMOR_KILL) > - (void)send_sig_info(profile->signal, NULL, > + send_sig_info(profile->signal, SEND_SIG_NOINFO, > ad->common.type =3D=3D LSM_AUDIT_DATA_TASK && > ad->common.u.tsk ? ad->common.u.tsk : current); > =20