From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D02F622DF85 for ; Thu, 27 Feb 2025 11:19:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740655200; cv=none; b=Ygv7ad1RGclc8BRxOSPseUKYWWmJ4XH5AYFUmk2YlDZ8mZ5MckzZu8C43I0RT5wclzN7ICk4EQTUy/ZYeufSB57UXVVuoDH2HpJlTpojI7yjYuyoBNdVEiPqyAyznpwgEv+Y0uv5EXTtuymuW2Are4Hkb+EWdGVxKjjBv69KAWY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740655200; c=relaxed/simple; bh=mFk2iRlhqswVknidb/hzvERvekGfFTJg0dMalWU77y4=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=CJ4XxvXtOoceIgE9HdeVn96rd8kqF7QBy0VxaO2w9SfL4SGUdc/2AW069xfloW0C7s4J2G7acbXAtB1TYAkKiBN1JwekDL4RGXjhoAVI5zkjaST7/Y8Ym8RKI/ROQceu5atc9asWVe+zPgDh2h3ewBKo6y9WeGRKqvzerkvfztk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=TCAFzTcc; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TCAFzTcc" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-38a8b17d7a7so482362f8f.2 for ; Thu, 27 Feb 2025 03:19:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740655197; x=1741259997; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=nrBhEllEopBWP9HcbxGglPZEUP0T/ozOsx35CY7uHqE=; b=TCAFzTccKDEqN/cG7jdNOUx5oNnLP5XP7cdWrI16NZICBnJ5N6/BHeTAgKV/Nf7LBE UecM/jLQUfB0tTS5FsxtdxVxvKfbzeLaid7qJlACP0tIVsI7DueQw60igCvKHuvpDt8e AL9hDaXrOrE6fzG0zkEC2Yoha1kzA9O4PrCHfg05B82iwQlF2aNbsgnnWC/AyMVO8fJ6 VmL/IyoWRKw5cllvTsuNuXaNTr4cpk8koN/GJEmDKg3CL79fvyRZqv/pHZMXI0MhK/MW +Ig5KEJOTvNnp0yi6lUV6WuqVPwWx2jltdrOZuULM/VvMfLVwl4tsDKOiJwkroK519y0 FBsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740655197; x=1741259997; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nrBhEllEopBWP9HcbxGglPZEUP0T/ozOsx35CY7uHqE=; b=lu5XwiYrnPvcynr6+bZLdgO5e43cDQ8TeevHlp78zy+TaJJwcpKby0SoAOU5qOxfZi 7rbc1DHAMbGy7FapS60TbXmUbiAgF7gZmcvisF9d7YK1FKjYB1zzlnnP2ciwcbL3HoLB G5tAjJGGc6MbwLP4iHefinOQWSvRrsv6Rh6YT/6psengAJjzYtUrGWwH9LeGWiyOT7C1 Lslci2QKzjU6bOlV4hQ3KFw2QJBOeRNmv2CIY2BPGoL3NUXy5DItKBXsqycIS38Xj+J1 NYqtiwUNSrlk3nUKtfMjxiv3yp56+6hVqwNW50qz0Xz21WswWFGPQxLR4NE15fH/Gr8z 6SXQ== X-Forwarded-Encrypted: i=1; AJvYcCV8MLMRiCQjAjdRaRT4hcndyXOSVt9T1ze4+mE3xd1KYDSbn52YELvbOa3VNRiqODc0sRgoiknSIc+ABhM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxf2PHiZPo80pCVjKvFneMAJMTWXv2PVpdmSnKFyrDd1Sjd2LAF r+HNvH7wLTiIMshcbvHvXmDmmv1bnKPHN8Jm/mnlbVGevrtuWYlCkV8WxB1AlOw= X-Gm-Gg: ASbGncuRGJ8/PFy9P6vFqrj5GANOTAiJ3MuSdvRrDQ4JoOxzvfivZsACM76lpqKn3Gi hdWQ1CN+XyWaGvjj72WwC2cY4hZ3otE0ODMiEqNwVWjZDklkroWzkvcjjPbPx/CMYYTfvYEGM1/ 9AmlOY9h9XNIELHePBRAlgV/e+fMc3ir3+963TPxKN0BYtWKKcsNdbHc2676H5pquDcieXP7uoN 0dpMnjtppjzoWuM7fh77r7Uq8luilGdNlYuT2vbqNwylbgqw97yO1J8wO8M1poySnLiT8gssO9p 4/294qlRScG07TbcImiW9n5UiPqRDQ== X-Google-Smtp-Source: AGHT+IFNsHD/pjhFobiNqCnZP2X8gKHsds8DdBj5VgmPHcb5ULaRf/oWFT2BO7FN/J4etiEnEeAlQw== X-Received: by 2002:adf:ed49:0:b0:38f:483f:8319 with SMTP id ffacd0b85a97d-390d4f9cfb7mr5139769f8f.51.1740655197122; Thu, 27 Feb 2025 03:19:57 -0800 (PST) Received: from draszik.lan ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390e47a72d5sm1742403f8f.31.2025.02.27.03.19.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2025 03:19:56 -0800 (PST) Message-ID: Subject: Re: [PATCH v2 1/6] dt-bindings: gpio: add max77759 binding From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: "Rob Herring (Arm)" Cc: "Gustavo A. R. Silva" , devicetree@vger.kernel.org, Kees Cook , linux-gpio@vger.kernel.org, Srinivas Kandagatla , Tudor Ambarus , Will McVicker , Conor Dooley , kernel-team@android.com, Bartosz Golaszewski , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, Lee Jones , Peter Griffin , Krzysztof Kozlowski , Linus Walleij Date: Thu, 27 Feb 2025 11:19:55 +0000 In-Reply-To: <174060184807.3654907.17826939583833772128.robh@kernel.org> References: <20250226-max77759-mfd-v2-0-a65ebe2bc0a9@linaro.org> <20250226-max77759-mfd-v2-1-a65ebe2bc0a9@linaro.org> <174060184807.3654907.17826939583833772128.robh@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.53.2-1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2025-02-26 at 14:30 -0600, Rob Herring (Arm) wrote: >=20 > On Wed, 26 Feb 2025 17:51:20 +0000, Andr=C3=A9 Draszik wrote: > > The Maxim MAX77759 is a companion PMIC for USB Type-C applications and > > includes Battery Charger, Fuel Gauge, temperature sensors, USB Type-C > > Port Controller (TCPC), NVMEM, and a GPIO expander. > >=20 > > This describes its GPIO module. > >=20 > > Signed-off-by: Andr=C3=A9 Draszik > >=20 > > --- > > v2: > > * drop 'interrupts' property and sort properties alphabetically > > --- > > =C2=A0.../bindings/gpio/maxim,max77759-gpio.yaml=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 | 44 ++++++++++++++++++++++ > > =C2=A0MAINTAINERS=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 6 +++ > > =C2=A02 files changed, 50 insertions(+) > >=20 >=20 > My bot found errors running 'make dt_binding_check' on your patch: >=20 > yamllint warnings/errors: >=20 > dtschema/dtc warnings/errors: >=20 >=20 > doc reference errors (make refcheckdocs): > Warning: Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml = references a file that doesn't exist: > Documentation/devicetree/bindings/mfd/maxim,max77759.yaml > Documentation/devicetree/bindings/gpio/maxim,max77759-gpio.yaml: Document= ation/devicetree/bindings/mfd/maxim,max77759.yaml >=20 > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/202502= 26-max77759-mfd-v2-1-a65ebe2bc0a9@linaro.org >=20 > The base for the series is generally the latest rc1. A different dependen= cy > should be noted in *this* patch. >=20 > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: 'make dt_binding_check' doesn't invoke 'make refcheckdocs', unless I'm doing something wrong - and therefore 'make dt_binding_check' doesn't print any warning, contrary to what seems to be implied by the paragraph above, If I run 'make refcheckdocs', I do get the error, too, sure enough. I've never come across refcheckdocs, and it wasn't on my radar. The error is because the binding's 'description:' references the mfd binding using the complete path and the mfd binding is added in a later patch only in this version of the series: >=C2=A0... For additional information, see > Documentation/devicetree/bindings/mfd/maxim,max77759.yaml. the error goes away if a relative path is used instead: > ... For additional information, see > ../mfd/maxim,max77759.yaml. I'd like to keep the reference to the mfd binding, and keep refcheckdocs working as intended (i.e. keep using the full path), so I'll split the gpio binding patch into two, the first one without the path and a 2nd one to add the full mfd binding path, to be applied after the mfd binding. Same for the similar nvmem binding. Unless there is a different preference? Cheers, Andre'