From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 271281F4CA9 for ; Wed, 8 Apr 2026 12:51:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775652709; cv=none; b=AJesCKcg6bgr2KUYBOArXD796ELCIgbIhIQWkFIXdY5yoVfdHcM9EbKowg1QeEeV+pn4r2ZKocrCqQOtCnNQ8jCVlmjWmZgc4Kh1mVdKw6NlltTFkd5Yk6owutdi9tLZv8DcTabVSbELJtn3OCXlTG5J8sIa6OIKX+osnNFIXrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775652709; c=relaxed/simple; bh=0vLo7tp497CFjsUg5IlBcVQ/iuP+v2IaN/Ud73bs17E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ALRbfDhfPL7L7PqD88/Zv9EyTJEeDdLPUYS6SeInGqTk07yHeiIkdXYOd8Msm4zutii9vtMAuz3gihqQvzQowNhv6ydAsoDVTYiIC8coF/QuptNBL6zl2RXIKD5sfE5yCCB84j6Y2TLICWwpa11+2BUXgEZsbG5UKRtweN6BIHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b=xVcIaZEU; arc=none smtp.client-ip=209.85.161.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b="xVcIaZEU" Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-67c1b8b1f96so3239369eaf.2 for ; Wed, 08 Apr 2026 05:51:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20251104.gappssmtp.com; s=20251104; t=1775652707; x=1776257507; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zkJ3gH9TLnBN4l2XWLDJVveLcFNwieT7aov30h8JMgg=; b=xVcIaZEUQ5FEfLj1wGzhcYD191wDwGkSp1YuK90H9jXtvHxQ/erdbQUG8dvqQ0vcK7 A7v6GUL726dZ9MCZvVgXmtYYMbzS3fankZuEjlqfl5HjneSPJaDaqv773inkpPNdBahj zn+taG8ITmP3qGZoo0tfai92S18q9mKXB4Upn7+tY/4AxXPwX3mJ0o0xadFXvFBXd4Ou z98OaZVRdLOndCfBAC3F890uTbt37T0ohHK+/TCmbX47jKvVNPqhtaaxDdDF6ADscH1k 5ct/EDNh9UAemP2IhYGgbATvyrD6EM5qbW76bkNVLxeiYgt6WOpBCpARAbcdLe2a1qpn Wb8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775652707; x=1776257507; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zkJ3gH9TLnBN4l2XWLDJVveLcFNwieT7aov30h8JMgg=; b=KepBUgzk7NW7/39v6+6u/dAoZqXX4mweIJ29Jl5CojPFtM5JKYho+1GGi5A72B5Xqi 5OWYugndsMXX2dAElv1EMUcbfJJFeqSNQ3qGVyebbw2jm1QnAN+BD5z7+Q3b+T2AUy4H 2S4lPVLwZO3IK4x0tZEQM917MAUzlsDXK42ObXwJ014NqNgRObrQcezMwHxvaCPsIQPz TXdxTMzAm13v2/VWq8DGvlt7vuXTjj3ccz8z85TXZvpifjCjhIg7WpJGdcWAWsxvXUOE LSdpVP0jZ5hAB4WHfkPCZXF0g4enS1C2+NkTt/z6+xebx2kvkIB4ACPB7i2WdsW6nrX+ FkrA== X-Forwarded-Encrypted: i=1; AJvYcCUtcpBlYIj/K0Rdwnaw/5V3crcsMIy8dncGCkrC76YL7isDEz5TcOHD5eMF2cThwzHmggiq2/TOGfGJSas=@vger.kernel.org X-Gm-Message-State: AOJu0YwOEKTNfIr39MWq2eExbxQeCPigmeoHinILsvKu7pn9iFsfu6Bc yxSEkP/q4/zytBZvn7mLCtv55/SETm58s8swU6buP2kN4u/tmaRDL3M7mHiD1w0s0AM= X-Gm-Gg: AeBDieuXaDFA4KvlxWlIsPzlKDYFSknYJMGEE0D5D8AeAZdzbrckklZwfjpIcfV7XVj vipNVrP+0thQHiu5xTQoq/FVI8mbn6flbFrvJwoz7DXfixUCvlm4pLqAM+qrJ4WqT2uwo1wKkn6 AYQCYNph9nBR9sVNtTeSWClD9dfskO7R0nTj20Rl31HIVFi/GJMdfXEH61eeTD3ErbOWFH7Quph aRMvsG7cADRX7xxA0JVxDYEunNE8nz9c5iJWg5jE3Otcoe1ucEwlCWec9cR0sEhGX3Pfk6rXFAz gctWI+rUHJW/kfp+aM+OJS4qaO7QH9B0e9THmhLm4k10o3P10qV32BegVCtXGCKqVBycesb+qem c/W2TZKRe8ELJsyeTS+YLHhLlbG1zAjItqvUArjq8W7NaA0WCr9tv2IET+LI+Nqf7sgsXXUyM+V xufyG3svjPaJ1GrFBczaT67jphQLY1SDcxArlOtLHaTHV7pQzt57LgGMMNPvCUsoziBNov9jThj ch1a0Yu7g== X-Received: by 2002:a05:6820:f07:b0:680:322:4f36 with SMTP id 006d021491bc7-6821e261e79mr11791129eaf.25.1775652707173; Wed, 08 Apr 2026 05:51:47 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6892da88901sm1085560eaf.0.2026.04.08.05.51.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2026 05:51:46 -0700 (PDT) Message-ID: Date: Wed, 8 Apr 2026 06:51:46 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] io_uring: fix resource leak issues To: KobaK , Pavel Begunkov Cc: Keith Busch , Ming Lei , io-uring@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260408065408.2017967-1-kobak@nvidia.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <20260408065408.2017967-1-kobak@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/8/26 12:54 AM, KobaK wrote: > From: Koba Ko > > Three resource leak fixes found by code audit: > > 1. memmap: pinned pages and pages array leak on WARN_ON path in > io_region_pin_pages() ? mr->pages is never assigned so the caller's > cleanup is a no-op. > > 2. rsrc: kfree() used instead of io_cache_free() in > io_buffer_register_bvec() error path ? bypasses cache return. > > 3. zcrx: io_import_umem() leaves live pinned pages in a partially > initialized struct on io_account_mem() failure, and > io_release_area_mem() is not idempotent (missing pages = NULL), > creating a double-free hazard. General advice - anyone can point an LLM at a code base and get some reports, but please apply some actual critical thinking to the "issues" found before blindly sending them out. -- Jens Axboe