From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4712C77B6C for ; Wed, 29 Mar 2023 10:59:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229569AbjC2K7A (ORCPT ); Wed, 29 Mar 2023 06:59:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229482AbjC2K66 (ORCPT ); Wed, 29 Mar 2023 06:58:58 -0400 Received: from mx.sberdevices.ru (mx.sberdevices.ru [45.89.227.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD64A19BB for ; Wed, 29 Mar 2023 03:58:55 -0700 (PDT) Received: from s-lin-edge02.sberdevices.ru (localhost [127.0.0.1]) by mx.sberdevices.ru (Postfix) with ESMTP id DA0455FD1C; Wed, 29 Mar 2023 13:58:52 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1680087532; bh=2RiAZcjm7f7fZ6eDOOysdqaLXhVvLMfLn4XnqyG2nKM=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; b=MEnJ+y7qM8X68v4BX902DNuyddPZX+zOuwWBOqRh8gxt7xxAJa/dG8X/L2L+WrwI3 Z2CGIP3E+n3mAj/+o+GINFap/38+X/sSR84fmAe9WS0q6rbfhoIN5ioFURiQMNqM4S 1EezKrN/EoeXdL4uo3IJQgD5LEiJuDX/aWs6AGYjO754F4rZtz7YIqXbvkX2hTClV/ O1Rpc4VeDLhR76pKJaMy2eM39AnuaKCAZsekaAY8etg9b9ikLYQjJnQGmMDnuXrp/9 dyGl8hPkWnBxJtfLi80MKXafN3VUw+R2EzbJvJ39IsraJN6SfQ0hmCbilGyVbbMKMC zWmbmkZedjxpw== Received: from S-MS-EXCH01.sberdevices.ru (S-MS-EXCH01.sberdevices.ru [172.16.1.4]) by mx.sberdevices.ru (Postfix) with ESMTP; Wed, 29 Mar 2023 13:58:51 +0300 (MSK) Message-ID: Date: Wed, 29 Mar 2023 13:55:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2] mtd: rawnand: meson: fix bitmask for length in command word Content-Language: en-US To: Miquel Raynal CC: Tudor Ambarus , Liang Yang , Richard Weinberger , Vignesh Raghavendra , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jianxin Pan , Yixun Lan , , , , , , References: <3794ffbf-dfea-e96f-1f97-fe235b005e19@sberdevices.ru> <447abc1b-b4a3-5848-c99a-ecbff11486fe@linaro.org> <20230329110054.68455418@xps-13> From: Arseniy Krasnov In-Reply-To: <20230329110054.68455418@xps-13> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [172.16.1.6] X-ClientProxiedBy: S-MS-EXCH02.sberdevices.ru (172.16.1.5) To S-MS-EXCH01.sberdevices.ru (172.16.1.4) X-KSMG-Rule-ID: 4 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiPhishing: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 1.1.2.30, bases: 2023/03/29 07:09:00 #21026578 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29.03.2023 12:00, Miquel Raynal wrote: > Hi Arseniy, > > avkrasnov@sberdevices.ru wrote on Wed, 29 Mar 2023 11:33:38 +0300: > >> On 29.03.2023 11:09, Tudor Ambarus wrote: >>> >>> >>> On 3/29/23 08:47, Arseniy Krasnov wrote: >>>> Valid mask is 0x3FFF, without this patch the following problems were >>>> found: >>>> >>>> 1) [ 0.938914] Could not find a valid ONFI parameter page, trying >>>> bit-wise majority to recover it >>>> [ 0.947384] ONFI parameter recovery failed, aborting >>>> >>>> 2) Read with disabled ECC mode was broken. >>>> >>>> Fixes: 8fae856c5350 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller") >>>> Cc: >>>> Signed-off-by: Arseniy Krasnov >>>> --- >>>> drivers/mtd/nand/raw/meson_nand.c | 6 +++--- >>>> 1 file changed, 3 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c >>>> index a28574c00900..074e14225c06 100644 >>>> --- a/drivers/mtd/nand/raw/meson_nand.c >>>> +++ b/drivers/mtd/nand/raw/meson_nand.c >>>> @@ -280,7 +280,7 @@ static void meson_nfc_cmd_access(struct nand_chip *nand, int raw, bool dir, >>>> >>>> if (raw) { >>>> len = mtd->writesize + mtd->oobsize; >>>> - cmd = (len & GENMASK(5, 0)) | scrambler | DMA_DIR(dir); >>>> + cmd = (len & GENMASK(13, 0)) | scrambler | DMA_DIR(dir); >>> >>> What happens when len > GENMASK(13, 0)? Do you check this somewhere? >> >> 'len' will be trimmed. I'm not sure that this case is possible here, because GENMASK(13, 0) >> is hardware limit for this NAND controller, so 'writesize' and 'oobsize' will be initialized >> to fit this value. Moreover GENMASK(13, 0) is 16Kb - i think it is big enough for single >> read. Also i'm not sure that it is good approach to check 'len' here - we are in the middle >> of NAND read processing. > > No, you should check the page size will not exceed this limit in the > attach hook, likely. > > You should also refuse exec_op operations with a data length bigger > than 16k (either with a manual check in your own parser or just by > providing the max size to the parser table, depending on what's used). > Ok, I see. Thanks, Arseniy >> >>> >>> Please introduce a macro/field for GENMASK(13, 0), having such mask >>> scattered along the code looks hackish and doesn't help readability. >>> You'll get to use FIELD_PREP as well. >> >> Ack, i'll do it in v3 >> >> Thanks, Arseniy >> >>> >>>> writel(cmd, nfc->reg_base + NFC_REG_CMD); >>>> return; >>>> } >>>> @@ -544,7 +544,7 @@ static int meson_nfc_read_buf(struct nand_chip *nand, u8 *buf, int len) >>>> if (ret) >>>> goto out; >>>> >>>> - cmd = NFC_CMD_N2M | (len & GENMASK(5, 0)); >>>> + cmd = NFC_CMD_N2M | (len & GENMASK(13, 0)); >>>> writel(cmd, nfc->reg_base + NFC_REG_CMD); >>>> >>>> meson_nfc_drain_cmd(nfc); >>>> @@ -568,7 +568,7 @@ static int meson_nfc_write_buf(struct nand_chip *nand, u8 *buf, int len) >>>> if (ret) >>>> return ret; >>>> >>>> - cmd = NFC_CMD_M2N | (len & GENMASK(5, 0)); >>>> + cmd = NFC_CMD_M2N | (len & GENMASK(13, 0)); >>>> writel(cmd, nfc->reg_base + NFC_REG_CMD); >>>> >>>> meson_nfc_drain_cmd(nfc); > > > Thanks, > Miquèl