From: Daniel Thompson <daniel.thompson@linaro.org>
To: Emil Velikov <emil.l.velikov@gmail.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: DRI Development <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
Jingoo Han <jingoohan1@gmail.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state
Date: Wed, 17 Jan 2018 16:37:33 +0000 [thread overview]
Message-ID: <f3e2e046-9a26-39ad-d08f-3715722d7cd9@linaro.org> (raw)
In-Reply-To: <CACvgo53UTbyAMi+Cp-Oye+7QuSJqeBdZiSyEuTKGQPSf8UdeLw@mail.gmail.com>
On 17/01/18 14:36, Emil Velikov wrote:
> On 17 January 2018 at 14:01, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>> Nothing in the entire tree ever sets this, which means this is dead
>> code. Remove it.
>>
>> Cc: Lee Jones <lee.jones@linaro.org>
>> Cc: Daniel Thompson <daniel.thompson@linaro.org>
>> Cc: Jingoo Han <jingoohan1@gmail.com>
>> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>> ---
>> drivers/video/backlight/generic_bl.c | 5 -----
>
> Fly-by comment, while waiting for coffee to kick-in.
> I think this patch should be after pandora/others have stopped abusing
> BL_CORE_DRIVER1.
You sure?
I can't see why the use or disuse of BL_CORE_DRIVER1 in this driver
should influence another independent driver.
Daniel.
next prev parent reply other threads:[~2018-01-17 16:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 14:01 [PATCH 1/6] backlight: Nuke unused backlight.props.state states Daniel Vetter
2018-01-17 14:01 ` [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state Daniel Vetter
2018-01-17 14:36 ` Emil Velikov
2018-01-17 16:37 ` Daniel Thompson [this message]
2018-01-18 13:08 ` Emil Velikov
2018-01-17 16:44 ` Daniel Thompson
2018-01-17 17:13 ` Daniel Vetter
2018-01-18 9:20 ` Daniel Thompson
2018-01-17 14:01 ` [PATCH 3/6] backlight/pandora: Stop using BL_CORE_DRIVER1 Daniel Vetter
2018-01-17 16:47 ` Daniel Thompson
2018-01-17 21:38 ` Daniel Vetter
2018-01-18 9:42 ` Daniel Thompson
2018-01-17 14:01 ` [PATCH 4/6] staging/fbtft: " Daniel Vetter
2018-01-17 16:50 ` Daniel Thompson
2018-01-17 14:01 ` [PATCH 5/6] backlight: Also nuke BL_CORE_DRIVER1 Daniel Vetter
2018-01-17 16:51 ` Daniel Thompson
2018-01-17 14:01 ` [PATCH 6/6] MAINTAINERS: add dri-devel for backlight subsystem patches Daniel Vetter
2018-01-17 16:52 ` Daniel Thompson
2018-01-17 17:06 ` Jingoo Han
2018-01-17 14:56 ` [PATCH 1/6] backlight: Nuke unused backlight.props.state states Daniel Thompson
2018-01-18 8:32 ` Lee Jones
2018-04-25 17:42 Daniel Vetter
2018-04-25 17:42 ` [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state Daniel Vetter
2018-04-30 10:21 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3e2e046-9a26-39ad-d08f-3715722d7cd9@linaro.org \
--to=daniel.thompson@linaro.org \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®