From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 393763B1014 for ; Mon, 8 Jun 2026 08:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780908446; cv=none; b=TQhtVZ7e9GQb4vcv2Wx+P7cxNFtE8Rw44oZ5V7vjGxC98d+QCSHxkh+72de0il/Yltjg0FciMnXV5OuFJjuGepRcoX7M0cT5l40AMzhMwUhDbU5tUQPxs+xc4gdRwEbhicOQJqy/U2cwYkdLP9ywNl2n6gityYTHHmXQoTFkvZc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780908446; c=relaxed/simple; bh=6xNCPJlDGmDF9Xp6ttUWKlED/iCUdRMCN83uMzmYsz8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pukduvx/ICVYv3G0jF3kVF//cTBuwCsl2aPRCtZM/Q6fOI5NbtmAnh7vedJbylVK9KZq7ncScRYt9lv9foNYajmdeMcOwUY7uEvGtEoAxgbBYvZVlxraz8FHA8tQ1XGBlhZyz61/az2Zx64pV/8rLhKYAjtjljwqpvwVSyLvzcM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KhLLirOn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TK5iPseB; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KhLLirOn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TK5iPseB" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6586Omcl2317599 for ; Mon, 8 Jun 2026 08:47:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= I5c1IdhnDyBdLWOxAQ9HMrfbElKxjABUy9YPSRIBmho=; b=KhLLirOn2lfldufB NNINJFSUqjyC4IvyV4oCXa9OQbXHnUzcTKC2WRyYS45IIDvR6bktexaJjFm19imd XlMQG4M5UBUK+75Rft7R9YA9N/79QGxKfZjjHFZpkKbcnkSoePnGRgBsEfd9hw5W 9FucQ4TetdCF2ewkp/EiiJfF0ycB0wpqNUxOEurYBo/Re0M9eMB3AQV55cW4tPXj xuM545oayEnhMkhwbOqvWae3hmHghnX+HuOQx/Oh1xmwKkFkXxjrQ56USiL41ItM +H8J5E/fOeFCp1FS4VprZbWYPstz3Ij5TP11aLfuN1dsBuweatYJ4Zba5X4jLF9a Kvm0oQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4emcadxmpy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Jun 2026 08:47:23 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5177b12d7bbso7154891cf.1 for ; Mon, 08 Jun 2026 01:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780908442; x=1781513242; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I5c1IdhnDyBdLWOxAQ9HMrfbElKxjABUy9YPSRIBmho=; b=TK5iPseBj1N+vrm/suqSQJH6KXy28OKAt+lK2ymqqceAy8Hwxq4TgGezEReZlsNTin JUjQi0P5742qVx5k64EcfpoRUqAzqCPxmCcAbZeEPFVeEdtk+z9G1VYMt8QE8bchE1yA S9tlFxARNaHwrNJ/E3M2Urs7QE7RUgVJC3H5cSKkAZvYjaH1dRofcyGIgqjXVPQC9LNW xasjJDO+LNWWr0Mday21gsBcou5d8ZLYLXMho2ip+ZFZ24qgxtNYalgVzWslaFtQKtWg 1nPLDYCo5vOt+iuG6eSRkjb/LsNrKvrdbzTCxq9eo0ko458v9mxFOBk3cRUEo4pvt/+4 2fjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780908442; x=1781513242; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I5c1IdhnDyBdLWOxAQ9HMrfbElKxjABUy9YPSRIBmho=; b=Lxn/zqpacWKtEUgmgIUwz7pETuArRGjZe1SSvJOJzfTxdO+qhVwdk4u2N3ceXd/WhX wzdPCh7Yj9Vl/j7BkwTSuoB9C7pCJm2uWTQ4CxsQeYX0YKOfl+fDVmJ4XFQrSS8g5T6T OdXjHVxBf2lcit9N3cQ9FpEWtK9PjqSlXaeMWzkYlS619Rwv00YCA4Vz5rwOZD8i3qh9 ggvlEPr2tV1tPwD3BUtbT873m941AzAJLld5CdyxBxWzSTdY2v8nqU4S6TSHw+WsWD8y R8J0MgAAsIToQDpAfjb21XRqOR83doo2fta1y7eAJWpQj09buaQmc8BYHZNKd0qrWlT2 2FwQ== X-Forwarded-Encrypted: i=1; AFNElJ8lMc4EjPdhrwi0LxpAI5Cbs63po2zFCdBAJr8W3dRhEwWXhaNVO3RHOWX8UWl7b2gHjmeUCB5a80DpAnw=@vger.kernel.org X-Gm-Message-State: AOJu0YyitAnbKvk7XYGKicUsnbFFsswjEo0xeTcxdUm46Lr7Bw0NVAlY TNk4N6dcXAOve0nnT7MlYtBQM5sLw87/YDISw48BQQpf9jzHAg5GNaJFc+h4AitbGVUP4NiOANN SYWelERyy5lBP2KnicjGd/Ksd3xHSWx0W/yZ4Qwx41rxOfKm5PU7vQLKneS6SaFtQntI= X-Gm-Gg: Acq92OEywcozCbFAAF8tg9PeV3KgeLPec60tgs2efEQI/qJpliv/8TlBAvyAS7LNIo5 hzqHMKiazZDXS5Gx1XHKid7iwSZbSt3pD4si+ALF/QvyIsCE6uhzuxzu7DRCE4IUXJX4ILiBNT8 c+EfuuH1xqQKemj015pFq0k6ny6g1j+ngz8eV99l+cEBGka+lkjr8dbmgzcS/F3aLtlQCMBza9t NnXusJbtp2pkd/t6sAopjKznVVFPbybb8gSXFkdkK3/YJccmZqvslNhJKgJ3b4z/5aNfc+BhpBl g+2wWY4CCU7AP4UgDLs2VyAHSp7707g4Z6gWNAZs745zS+8VT+D2y+Tn48hAs6hLGayF3+1lnNL hPYSSe2FOD9aHHcjHCT97C4+3x8ShsWd9CWWZmKnFY2g5pJba9B95eeRO X-Received: by 2002:a05:622a:1809:b0:516:cae0:c6e9 with SMTP id d75a77b69052e-51795958520mr129035901cf.0.1780908442391; Mon, 08 Jun 2026 01:47:22 -0700 (PDT) X-Received: by 2002:a05:622a:1809:b0:516:cae0:c6e9 with SMTP id d75a77b69052e-51795958520mr129035761cf.0.1780908441925; Mon, 08 Jun 2026 01:47:21 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68e64e2c810sm6934134a12.9.2026.06.08.01.47.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2026 01:47:21 -0700 (PDT) Message-ID: Date: Mon, 8 Jun 2026 10:47:18 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] clk: qcom: common: introduce qcom_cc_sync_state() To: Brian Masney , Saravana Kannan , Abel Vesa , Maxime Ripard , Michael Turquette , Stephen Boyd , Russell King , Bjorn Andersson , Hans de Goede Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260603-clk-sync-state-v1-0-457120eed200@redhat.com> <20260603-clk-sync-state-v1-2-457120eed200@redhat.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260603-clk-sync-state-v1-2-457120eed200@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=DIa/JSNb c=1 sm=1 tr=0 ts=6a26819b cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=20KFwNOVAAAA:8 a=0rD7byl_W-EYyDmgqW0A:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: hD1Tkyun_BwEXZNd5l6pVM8P7DRQABu- X-Proofpoint-ORIG-GUID: hD1Tkyun_BwEXZNd5l6pVM8P7DRQABu- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDA4MCBTYWx0ZWRfX5ut/PYEgzwpT 1Q1WWQjVciSsLVXMx7Ya+DITkJkKTtJPpLykjb+KTdfhlIPT6FkHcOB+asxa4hwVIrl4zVM224F P9A1Tuu66fM1EqnKFFxRxozxMytTUstmUpvtrGHEOkbvFQN+LkwLmto12A/nVe64X3pPXgWzcst itIrycu26+gB/mhKkpKDHxhrkcdpQxAgISBxhrfL+deL5LcrFcsvjjsLNzDlES4W5unTLoWhyJU qpXTMv6OgHJHYHL5sBy30jsurVQuLgm2/pb5DggljNah1mh8YLmyGN/9qBN99PDatXtdJfzhxSA JF/HZKth7pMGdml6wxNbCdzP7bZofS1gRze6+gxLhvz/19IOC+CGNqaSS1L/RiKtU51But082yV pwCfX4q61jL2jf98zNhHkbmf8vfZCcjp21X6pHLQMIcMEv9d8eD9PeN95Rku14jf+z1jsGenTmr o11NjOvZUW4IRRN4MQQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_02,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 bulkscore=0 adultscore=0 malwarescore=0 clxscore=1015 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606080080 On 6/3/26 4:21 PM, Brian Masney wrote: > Several qcom clk providers currently have a sync_state helper set to > icc_sync_state(). With an upcoming change to the clk framework, if > sync_state is not defined for the device, then the clk framework sets it > to clk_sync_state(). > > Clk providers that require their own sync_state will need to call the > framework level clk_sync_state(). Let's introduce a new common helper > qcom_cc_sync_state() that calls icc_sync_state() and clk_sync_state(). > > Signed-off-by: Brian Masney > --- > drivers/clk/qcom/common.c | 9 +++++++++ > drivers/clk/qcom/common.h | 1 + > 2 files changed, 10 insertions(+) > > diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c > index eec369d2173b..31382c49c948 100644 > --- a/drivers/clk/qcom/common.c > +++ b/drivers/clk/qcom/common.c > @@ -3,12 +3,14 @@ > * Copyright (c) 2013-2014, The Linux Foundation. All rights reserved. > */ > > +#include > #include > #include > #include > #include > #include > #include > +#include > #include > #include > #include > @@ -464,5 +466,12 @@ int qcom_cc_probe_by_index(struct platform_device *pdev, int index, > } > EXPORT_SYMBOL_GPL(qcom_cc_probe_by_index); > > +void qcom_cc_sync_state(struct device *dev) > +{ > + icc_sync_state(dev); > + clk_sync_state(dev); > +} Do we expect more things to appear here? Currently it's only the qcom clock controllers that use icc_sync_state, but I wouldn't be surprised if that list grew OTOH, as Dmitry suggested, we may need to check some of the driver-specific data.. Konrad