From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753872AbdJIBML (ORCPT ); Sun, 8 Oct 2017 21:12:11 -0400 Received: from m12-13.163.com ([220.181.12.13]:58958 "EHLO m12-13.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753786AbdJIBMI (ORCPT ); Sun, 8 Oct 2017 21:12:08 -0400 To: forest@alittletooquiet.net, gregkh@linuxfoundation.org, simon@nikanor.nu, tvboxspy@gmail.com, scott@matheina.com, dan.a.cashman@gmail.com, golubev.mikhail@gmail.com, bhelgaas@google.com Cc: devel@driverdev.osuosl.org, Linux Kernel Mailing List , linux-pci@vger.kernel.org From: Jia-Ju Bai Subject: [BUG] vt6655: A possible sleep-in-atomic bug in vt6655_suspend Message-ID: Date: Mon, 9 Oct 2017 09:10:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-CM-TRANSID: DcCowAAnQ1SHzNpZliCyMQ--.36790S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUkOVkUUUUU X-Originating-IP: [166.111.70.12] X-CM-SenderInfo: xedlyx5dmximizq6il2tof0z/1tbiYwhselaDvJmbtAAAsi Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org According to device_main.c, the driver may sleep under a spinlock, and the function call path is: vt6655_suspend (acquire the spinlock) pci_set_power_state __pci_start_power_transition (drivers/pci/pci.c) msleep --> may sleep A possible fix is to replace msleep with mdelay in __pci_start_power_transition in drivers/pci/pci.c. This bug is found by my static analysis tool and my code review. Thanks, Jia-Ju Bai