From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753538AbeABLpA (ORCPT + 1 other); Tue, 2 Jan 2018 06:45:00 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35590 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753493AbeABLo6 (ORCPT ); Tue, 2 Jan 2018 06:44:58 -0500 X-Google-Smtp-Source: ACJfBotd7uQ2VkB5YbzCz4ut9FtvukXnSZqIo+gyw2/QE1LKfs+mITjyrkCPEl9XiWJhmX30nnCEsQ== Subject: Re: [PATCH v2 02/21] nvmem: Introduce devm_nvmem_(un)register() To: Andrey Smirnov Cc: Heiko Stuebner , Masahiro Yamada , Carlo Caione , Kevin Hilman , Matthias Brugger , cphealy@gmail.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <20180101232310.30420-1-andrew.smirnov@gmail.com> <20180101232310.30420-3-andrew.smirnov@gmail.com> From: Srinivas Kandagatla Message-ID: Date: Tue, 2 Jan 2018 11:44:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20180101232310.30420-3-andrew.smirnov@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: Thanks for the patch, On 01/01/18 23:22, Andrey Smirnov wrote: > Introduce devm_nvmem_register()/devm_nvmem_unregister() to make > .remove() unnecessary in trivial drivers. > > Cc: Srinivas Kandagatla > Cc: Heiko Stuebner > Cc: Masahiro Yamada > Cc: Carlo Caione > Cc: Kevin Hilman > Cc: Matthias Brugger > Cc: cphealy@gmail.com > Cc: linux-kernel@vger.kernel.org > Cc: linux-mediatek@lists.infradead.org > Cc: linux-rockchip@lists.infradead.org > Cc: linux-amlogic@lists.infradead.org > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Andrey Smirnov > --- > drivers/nvmem/core.c | 41 +++++++++++++++++++++++++++++++++++++++++ > include/linux/nvmem-provider.h | 17 +++++++++++++++++ > 2 files changed, 58 insertions(+) > Patch looks good, kernel doc for these exported symbols are missing, you should add them in next version! Thanks, Srini > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > index 57cbeacfbeb2..84f07ba1f36d 100644 > --- a/drivers/nvmem/core.c > +++ b/drivers/nvmem/core.c > @@ -551,6 +551,47 @@ int nvmem_unregister(struct nvmem_device *nvmem) > } > EXPORT_SYMBOL_GPL(nvmem_unregister); > > +static void devm_nvmem_release(struct device *dev, void *res) > +{ > + WARN_ON(nvmem_unregister(*(struct nvmem_device **)res)); > +} > + > +struct nvmem_device *devm_nvmem_register(struct device *dev, > + const struct nvmem_config *config) > +{ > + struct nvmem_device **ptr, *nvmem; > + > + ptr = devres_alloc(devm_nvmem_release, sizeof(*ptr), GFP_KERNEL); > + if (!ptr) > + return ERR_PTR(-ENOMEM); > + > + nvmem = nvmem_register(config); > + > + if (!IS_ERR(nvmem)) { > + *ptr = nvmem; > + devres_add(dev, ptr); > + } else { > + devres_free(ptr); > + } > + > + return nvmem; > +} > +EXPORT_SYMBOL_GPL(devm_nvmem_register); > + > +static int devm_nvmem_match(struct device *dev, void *res, void *data) > +{./drivers/base/devres.c > + struct nvmem_device **r = res; > + > + return *r == data; > +} > + > +int devm_nvmem_unregister(struct device *dev, struct nvmem_device *nvmem) > +{ > + return devres_release(dev, devm_nvmem_release, devm_nvmem_match, nvmem); > +} > +EXPORT_SYMBOL(devm_nvmem_unregister); > + > + > static struct nvmem_device *__nvmem_device_get(struct device_node *np, > struct nvmem_cell **cellp, > const char *cell_id) > diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h > index 497706f5adca..493f2f529f00 100644 > --- a/include/linux/nvmem-provider.h > +++ b/include/linux/nvmem-provider.h > @@ -47,6 +47,11 @@ struct nvmem_config { > struct nvmem_device *nvmem_register(const struct nvmem_config *cfg); > int nvmem_unregister(struct nvmem_device *nvmem); > > +struct nvmem_device *devm_nvmem_register(struct device *dev, > + const struct nvmem_config *cfg); > + > +int devm_nvmem_unregister(struct device *dev, struct nvmem_device *nvmem); > + > #else > > static inline struct nvmem_device *nvmem_register(const struct nvmem_config *c) > @@ -59,5 +64,17 @@ static inline int nvmem_unregister(struct nvmem_device *nvmem) > return -ENOSYS; > } > > +static inline struct nvmem_device * > +devm_nvmem_register(struct device *dev, const struct nvmem_config *c) > +{ > + return nvmem_register(c); > +} > + > +static inline int > +devm_nvmem_unregister(struct device *dev, struct nvmem_device *nvmem) > +{ > + return nvmem_unregister(nvmem); > +} > + > #endif /* CONFIG_NVMEM */ > #endif /* ifndef _LINUX_NVMEM_PROVIDER_H */ >