From: "Peter Feuerer" <peter@piie.net>
To: "Paul Gortmaker" <paul.gortmaker@windriver.com>,
platform-driver-x86@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"Darren Hart" <dvhart@infradead.org>,
"Andy Shevchenko" <andy@infradead.org>
Subject: Re: [PATCH 0/6] platform/x86: acerhdf: new BIOS string, better modparam handling
Date: Fri, 21 Sep 2018 06:20:27 +0000 [thread overview]
Message-ID: <f401b6fed813afb86f5442c7707bf9fb@piie.net> (raw)
In-Reply-To: <20180921014421.30804-1-paul.gortmaker@windriver.com>
Hi,
21. September 2018 03:45, "Paul Gortmaker" <paul.gortmaker@windriver.com> schrieb:
> I came across this older netbook over the xmas holidays, and noticed the
> acerhdf driver wouldn't load. Turns out the BIOS string was too new,
> and not listed in the driver. There were module params for overrides,
> but I found their use isn't quite clear without reading the source.
>
> Here I clarify some of the module parameter usage, and then add the new
> BIOS string, so they won't be needed for this particular platform. Some
> probe code is also shifted out to be __init to reduce the driver size a
> bit. Further details can be found in the respective commit logs.
>
> Since it was months ago when I created these patches, I retested on top
> of tree to ensure things still work, as can be seen below.
Thanks a lot for your work and this set of changes. This improves quality.
I reviewed all 6 patches.
Reviewed-by: Peter Feuerer <peter@piie.net>
Please also add CC: Boris Petkov <bp@suse.de> for review.
[...]
--
kind regards,
--peter;
next prev parent reply other threads:[~2018-09-21 6:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 1:44 Paul Gortmaker
2018-09-21 1:44 ` [PATCH 1/6] platform/x86: acerhdf: clarify modinfo messages for BIOS override Paul Gortmaker
2018-09-21 1:44 ` [PATCH 2/6] platform/x86: acerhdf: Enable ability to list supported systems Paul Gortmaker
2018-09-21 1:44 ` [PATCH 3/6] platform/x86: acerhdf: Remove cut-and-paste trap from instructions Paul Gortmaker
2018-09-21 1:44 ` [PATCH 4/6] platform/x86: acerhdf: Add BIOS entry for Gateway LT31 v1.3307 Paul Gortmaker
2018-09-21 1:44 ` [PATCH 5/6] platform/x86: acerhdf: mark appropriate content with __init prefix Paul Gortmaker
2018-09-21 1:44 ` [PATCH 6/6] platform/x86: acerhdf: restructure to allow large BIOS table be __initconst Paul Gortmaker
2018-09-21 6:20 ` Peter Feuerer [this message]
2018-09-26 11:09 ` [PATCH 0/6] platform/x86: acerhdf: new BIOS string, better modparam handling Andy Shevchenko
2018-09-26 11:13 ` Andy Shevchenko
2018-09-26 14:11 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f401b6fed813afb86f5442c7707bf9fb@piie.net \
--to=peter@piie.net \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®