From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 161CFC433DF for ; Sat, 20 Jun 2020 09:53:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7EF723AF8 for ; Sat, 20 Jun 2020 09:53:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="UimnWIqp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727960AbgFTJx3 (ORCPT ); Sat, 20 Jun 2020 05:53:29 -0400 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:9331 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727861AbgFTJx3 (ORCPT ); Sat, 20 Jun 2020 05:53:29 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Sat, 20 Jun 2020 02:53:16 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Sat, 20 Jun 2020 02:53:28 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Sat, 20 Jun 2020 02:53:28 -0700 Received: from [10.26.73.131] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sat, 20 Jun 2020 09:53:22 +0000 Subject: Re: [PATCH] [v3] dmaengine: tegra210-adma: Fix runtime PM imbalance on error To: CC: , Laxman Dewangan , Dan Williams , Vinod Koul , Thierry Reding , , , References: <20200618105727.14669-1-dinghao.liu@zju.edu.cn> <9f7684d9-7a75-497d-db1c-75cf0991a072@nvidia.com> <24ea1ef1.10213.172ca4d45be.Coremail.dinghao.liu@zju.edu.cn> From: Jon Hunter Message-ID: Date: Sat, 20 Jun 2020 10:53:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <24ea1ef1.10213.172ca4d45be.Coremail.dinghao.liu@zju.edu.cn> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1592646796; bh=skDQ77maO2GC7cm4xW7BXoWafTy1w2SK+o9txAtL5SE=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=UimnWIqpRJy7kUAKmx0otVxsMGTTOcIcq44DP2Q5g9xTeWqUH6NSnNDqR6hnTZ/mO RW22vRCa6BZ6k/TDgdYcAmeWCLgM+1gQHulmACKUapQXyooMt7XRyx/UKASP+XhFBB XN1AXJtTB3koVzlED+vKIUKDGJkEGtjP+AdLktNtOINJfFLMTafwfYGt0AfZZlTZ5C djhZUysytC6torZrMRhRcjfHk3IpOnp9GURpLmvi5AdwIVa4HsC5C3j09ZMBbrOv3L tHH7g9g8VZfW89oOtP94NLhHaSV7L3E0wlc1z0QcQ29SDRUIF9HOklT6Kc/rjqDeFN E+L169HQ1F3xQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/06/2020 02:59, dinghao.liu@zju.edu.cn wrote: >> >> Why noidle? >> > > _noidle is enough for fixing this bug. _sync may suspend > the device beyond expectation. In that case, then the other instance you are fixing with this patch is not correct. Jon -- nvpublic