mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	dietmar.eggemann@arm.com, rui.zhang@intel.com,
	amit.kucheria@verdurent.com, amit.kachhap@gmail.com,
	daniel.lezcano@linaro.org, viresh.kumar@linaro.org,
	len.brown@intel.com, pavel@ucw.cz, mhiramat@kernel.org,
	qyousef@layalina.io, wvw@google.com
Subject: Re: [PATCH v6 07/23] PM: EM: Refactor how the EM table is allocated and populated
Date: Wed, 10 Jan 2024 13:58:44 +0000	[thread overview]
Message-ID: <f405ad09-cfae-40b9-b73a-a194d39090ed@arm.com> (raw)
In-Reply-To: <CAJZ5v0jETcdATvjgULoGmr_g+cGA3=XWyCTjO1vkBZURCsGuLw@mail.gmail.com>



On 1/4/24 19:18, Rafael J. Wysocki wrote:
> The changelog actually sets what happens here, so why don't you put
> that into the changelog too?  Something like: "Split the allocation
> and initialization of the EM table"

OK I will do that.

> 
> On Thu, Jan 4, 2024 at 6:15 PM Lukasz Luba <lukasz.luba@arm.com> wrote:
>>
>> Split the process of allocation and data initialization for the EM table.
>> The upcoming changes for modifiable EM will use it.
>>
>> This change is not expected to alter the general functionality.
>>
>> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
>> ---
>>   kernel/power/energy_model.c | 55 ++++++++++++++++++++++---------------
>>   1 file changed, 33 insertions(+), 22 deletions(-)

[snip]

>> --
> 
> The code changes LGTM.

Thanks

  reply	other threads:[~2024-01-10 13:57 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-04 17:15 [PATCH v6 00/23] Introduce runtime modifiable Energy Model Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 01/23] PM: EM: Add missing newline for the message log Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 02/23] PM: EM: Refactor em_cpufreq_update_efficiencies() arguments Lukasz Luba
2024-01-04 19:07   ` Rafael J. Wysocki
2024-01-10 13:56     ` Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 03/23] PM: EM: Find first CPU active while updating OPP efficiency Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 04/23] PM: EM: Refactor em_pd_get_efficient_state() to be more flexible Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 05/23] PM: EM: Refactor a new function em_compute_costs() Lukasz Luba
2024-01-04 19:15   ` Rafael J. Wysocki
2024-01-10 13:57     ` Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 06/23] PM: EM: Check if the get_cost() callback is present in em_compute_costs() Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 07/23] PM: EM: Refactor how the EM table is allocated and populated Lukasz Luba
2024-01-04 19:18   ` Rafael J. Wysocki
2024-01-10 13:58     ` Lukasz Luba [this message]
2024-01-04 17:15 ` [PATCH v6 08/23] PM: EM: Introduce runtime modifiable table Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 09/23] PM: EM: Use runtime modified EM for CPUs energy estimation in EAS Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 10/23] PM: EM: Add API for memory allocations for new tables Lukasz Luba
2024-01-04 19:35   ` Rafael J. Wysocki
2024-01-10 14:09     ` Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 11/23] PM: EM: Add API for updating the runtime modifiable EM Lukasz Luba
2024-01-04 19:47   ` Rafael J. Wysocki
2024-01-10 14:11     ` Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 12/23] PM: EM: Add helpers to read under RCU lock the EM table Lukasz Luba
2024-01-04 19:55   ` Rafael J. Wysocki
2024-01-10 14:06     ` Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 13/23] PM: EM: Add performance field to struct em_perf_state and optimize Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 14/23] PM: EM: Support late CPUs booting and capacity adjustment Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 15/23] PM: EM: Optimize em_cpu_energy() and remove division Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 16/23] powercap/dtpm_cpu: Use new Energy Model interface to get table Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 17/23] powercap/dtpm_devfreq: " Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 18/23] drivers/thermal/cpufreq_cooling: Use new Energy Model interface Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 19/23] drivers/thermal/devfreq_cooling: " Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 20/23] PM: EM: Change debugfs configuration to use runtime EM table data Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 21/23] PM: EM: Remove old table Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 22/23] PM: EM: Add em_dev_compute_costs() as API for device drivers Lukasz Luba
2024-01-04 17:15 ` [PATCH v6 23/23] Documentation: EM: Update with runtime modification design Lukasz Luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f405ad09-cfae-40b9-b73a-a194d39090ed@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=amit.kachhap@gmail.com \
    --cc=amit.kucheria@verdurent.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=pavel@ucw.cz \
    --cc=qyousef@layalina.io \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=viresh.kumar@linaro.org \
    --cc=wvw@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®