From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E63F0C433B4 for ; Fri, 16 Apr 2021 07:26:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC83C6101B for ; Fri, 16 Apr 2021 07:26:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239472AbhDPH1B (ORCPT ); Fri, 16 Apr 2021 03:27:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:44422 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231666AbhDPH0z (ORCPT ); Fri, 16 Apr 2021 03:26:55 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8FF2C60238; Fri, 16 Apr 2021 07:26:29 +0000 (UTC) Subject: Re: [PATCH v2 0/2] Fix binfmt_flat loader for RISC-V To: Damien Le Moal , Al Viro , Christoph Hellwig Cc: Palmer Dabbelt , "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "jcmvbkbc@gmail.com" , Anup Patel , "uclinux-dev@uclinux.org" References: <20210415055605.GB8947@lst.de> From: Greg Ungerer Message-ID: Date: Fri, 16 Apr 2021 17:26:27 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/4/21 10:26 am, Damien Le Moal wrote: > On 2021/04/16 9:22, Al Viro wrote: >> On Thu, Apr 15, 2021 at 07:56:05AM +0200, Christoph Hellwig wrote: >>> binfmt_flat tends to go through Greg's uclinux tree, adding him and >>> the list. >> >> FWIW, my involvement with binfmt_flat had been pretty much nil - >> the least trivial had been "binfmt_flat: flat_{get,put}_addr_from_rp() >> should be able to fail" about 4 years ago and that fell out of hunting >> for places where __get_user() had been used without checking error values. >> >> It's in fs/*, but I've no way to test it and I have pretty much >> zero familiarity with the guts of that one, so I can't give any useful >> feedback on that series. So consider the Christoph's comment seconded - >> you want it reviewed by gerg et.al., and it probably ought to go via >> gerg/uclinux.git tree. >> >> I'm reasonably familiar with binfmt_{elf,misc,script}; anything >> else gets touched as part of larger series and only with sanity checks >> from other folks, if the changes are not entirely trivial. > > Al, > > Thanks for the clarification. Would it make sense to have an entry in > MAINTAINERS file pointing to Greg and the uclinux tree for binfmt_flat.c ? > Greg ? Yep, looks like it does need that. Regards Greg