From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752424AbdKVMDT (ORCPT ); Wed, 22 Nov 2017 07:03:19 -0500 Received: from mga06.intel.com ([134.134.136.31]:25086 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752210AbdKVMDS (ORCPT ); Wed, 22 Nov 2017 07:03:18 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,436,1505804400"; d="scan'208";a="4624343" Subject: Re: [PATCH 3/6 v3] mmc: sdhci-acpi: Handle return value of platform_get_irq To: Arvind Yadav , ben-linux@fluff.org, ulf.hansson@linaro.org, vireshk@kernel.org, maxime.ripard@free-electrons.com, wens@csie.org, linux@armlinux.org.uk, carlo@caione.org, khilman@baylibre.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org References: From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Wed, 22 Nov 2017 14:02:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/11/17 06:52, Arvind Yadav wrote: > platform_get_irq() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav Acked-by: Adrian Hunter > --- > changes in v2 : > Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. > changes in v3 : > return -EINVAL instead of host->irq. > > drivers/mmc/host/sdhci-acpi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c > index b988997..0d9965b 100644 > --- a/drivers/mmc/host/sdhci-acpi.c > +++ b/drivers/mmc/host/sdhci-acpi.c > @@ -566,6 +566,10 @@ static int sdhci_acpi_probe(struct platform_device *pdev) > host->hw_name = "ACPI"; > host->ops = &sdhci_acpi_ops_dflt; > host->irq = platform_get_irq(pdev, 0); > + if (host->irq <= 0) { > + err = -EINVAL; > + goto err_free; > + } > > host->ioaddr = devm_ioremap_nocache(dev, iomem->start, > resource_size(iomem)); >