From: Dave Hansen <dave.hansen@intel.com>
To: kirill.shutemov@linux.intel.com, Kai Huang <kai.huang@intel.com>
Cc: peterz@infradead.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de, bp@alien8.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, seanjc@google.com,
pbonzini@redhat.com, isaku.yamahata@intel.com,
sathyanarayanan.kuppuswamy@linux.intel.com,
n.borisov.lkml@gmail.com
Subject: Re: [PATCH v3 11/12] x86/virt/tdx: Allow SEAMCALL to handle #UD and #GP
Date: Mon, 7 Aug 2023 07:46:45 -0700 [thread overview]
Message-ID: <f410c645-b1d1-2bc1-1271-0653eedb74e3@intel.com> (raw)
In-Reply-To: <20230806114131.2ilofgmxhdaa2u6b@box.shutemov.name>
On 8/6/23 04:41, kirill.shutemov@linux.intel.com wrote:
> On Wed, Jul 26, 2023 at 11:25:13PM +1200, Kai Huang wrote:
>> @@ -20,6 +21,9 @@
>> #define TDX_SW_ERROR (TDX_ERROR | GENMASK_ULL(47, 40))
>> #define TDX_SEAMCALL_VMFAILINVALID (TDX_SW_ERROR | _UL(0xFFFF0000))
>>
>> +#define TDX_SEAMCALL_GP (TDX_SW_ERROR | X86_TRAP_GP)
>> +#define TDX_SEAMCALL_UD (TDX_SW_ERROR | X86_TRAP_UD)
> Is there any explantion how these error codes got chosen? Looks very
> arbitrary and may collide with other error codes in the future.
If they collide, we can just fix it then.
So, please, do comment what the limitations are and what must be avoided
in the future, but I don't think we need to go mucking with this at all.
next prev parent reply other threads:[~2023-08-07 14:46 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 11:25 [PATCH v3 00/12] Unify TDCALL/SEAMCALL and TDVMCALL assembly Kai Huang
2023-07-26 11:25 ` [PATCH v3 01/12] x86/tdx: Zero out the missing RSI in TDX_HYPERCALL macro Kai Huang
2023-07-27 12:48 ` kirill.shutemov
2023-07-26 11:25 ` [PATCH v3 02/12] x86/tdx: Skip saving output regs when SEAMCALL fails with VMFailInvalid Kai Huang
2023-07-27 12:52 ` kirill.shutemov
2023-07-27 22:55 ` Huang, Kai
2023-07-26 11:25 ` [PATCH v3 03/12] x86/tdx: Make macros of TDCALLs consistent with the spec Kai Huang
2023-07-27 13:00 ` kirill.shutemov
2023-07-28 1:54 ` Sathyanarayanan Kuppuswamy
2023-07-28 2:45 ` Huang, Kai
2023-07-26 11:25 ` [PATCH v3 04/12] x86/tdx: Rename __tdx_module_call() to __tdcall() Kai Huang
2023-07-27 13:02 ` kirill.shutemov
2023-07-28 15:33 ` Sathyanarayanan Kuppuswamy
2023-07-26 11:25 ` [PATCH v3 05/12] x86/tdx: Pass TDCALL/SEAMCALL input/output registers via a structure Kai Huang
2023-07-27 16:36 ` kirill.shutemov
2023-07-27 22:54 ` Huang, Kai
2023-08-03 10:58 ` kirill.shutemov
2023-08-03 11:35 ` Huang, Kai
2023-08-03 11:47 ` kirill.shutemov
2023-07-26 11:25 ` [PATCH v3 06/12] x86/tdx: Extend TDX_MODULE_CALL to support more TDCALL/SEAMCALL leafs Kai Huang
2023-07-27 16:50 ` kirill.shutemov
2023-07-27 22:58 ` Huang, Kai
2023-07-26 11:25 ` [PATCH v3 07/12] x86/tdx: Make TDX_HYPERCALL asm similar to TDX_MODULE_CALL Kai Huang
2023-07-27 17:10 ` kirill.shutemov
2023-07-27 23:05 ` Huang, Kai
2023-08-03 11:45 ` kirill.shutemov
2023-08-03 11:56 ` Huang, Kai
2023-08-03 12:12 ` kirill.shutemov
2023-08-03 12:41 ` Huang, Kai
2023-08-03 13:47 ` kirill.shutemov
2023-08-03 22:41 ` Huang, Kai
2023-07-26 11:25 ` [PATCH v3 08/12] x86/tdx: Reimplement __tdx_hypercall() using TDX_MODULE_CALL asm Kai Huang
2023-08-06 11:25 ` kirill.shutemov
2023-07-26 11:25 ` [PATCH v3 09/12] x86/tdx: Remove 'struct tdx_hypercall_args' Kai Huang
2023-08-06 11:29 ` kirill.shutemov
2023-07-26 11:25 ` [PATCH v3 10/12] x86/virt/tdx: Wire up basic SEAMCALL functions Kai Huang
2023-08-06 11:36 ` kirill.shutemov
2023-08-07 1:40 ` Huang, Kai
2023-08-07 14:30 ` Sean Christopherson
2023-08-07 23:51 ` Huang, Kai
2023-07-26 11:25 ` [PATCH v3 11/12] x86/virt/tdx: Allow SEAMCALL to handle #UD and #GP Kai Huang
2023-08-06 11:41 ` kirill.shutemov
2023-08-07 2:14 ` Huang, Kai
2023-08-07 9:53 ` kirill.shutemov
2023-08-07 12:41 ` Huang, Kai
2023-08-07 14:27 ` kirill.shutemov
2023-08-07 14:46 ` Dave Hansen [this message]
2023-07-26 11:25 ` [PATCH v3 12/12] x86/virt/tdx: Adjust 'struct tdx_module_args' to use x86 "register index" layout Kai Huang
2023-08-02 21:32 ` Isaku Yamahata
2023-08-02 23:20 ` Huang, Kai
2023-08-02 21:39 ` Isaku Yamahata
2023-08-06 11:50 ` kirill.shutemov
2023-08-07 2:16 ` Huang, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f410c645-b1d1-2bc1-1271-0653eedb74e3@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=isaku.yamahata@intel.com \
--cc=kai.huang@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=n.borisov.lkml@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®