From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1FAAC4708D for ; Wed, 4 Jan 2023 20:06:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235552AbjADUGI (ORCPT ); Wed, 4 Jan 2023 15:06:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233776AbjADUGF (ORCPT ); Wed, 4 Jan 2023 15:06:05 -0500 Received: from mail-40134.protonmail.ch (mail-40134.protonmail.ch [185.70.40.134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0D29FADF for ; Wed, 4 Jan 2023 12:06:03 -0800 (PST) Date: Wed, 04 Jan 2023 20:05:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail3; t=1672862761; x=1673121961; bh=nTNb3+2A3F0vXm3gxoPk4UkBGCvDMUP/Ksj+2KDWSd8=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=UDAq/S+Z/lc71ukStEw/o1u/CgeJmL+vojEKBhEChCW6UwVszI4OWquBYhR0vxZwx 063SscOn8R8AjY9hqHn0mhAyF5RJzvhD9zjVGmJH/6THOWUT7XfOD9Zv0SKMmso+Q5 MrlP6c7pLmBk9JF+/lcjsMlKxapLFdeiQo4d6148/LcQ/53HelPI1lKUKtR+zjZbXr QtHK6POg3EAQPLm6IzSmEJzcyXk0pEc6Og8W3ytFfYl1uQU8mc6e2hlZdTUKGvUTd4 gac2vhEfDVHxPIYgtZEYFCL0Kp8kaPU4dNKxrZkOquBEbK7zDmoeDPK4QOU2PCXkR7 xXpRRwMmnZwKg== To: Bagas Sanjaya , stable@vger.kernel.org From: Waldek Andrukiewicz Cc: regressions@lists.linux.dev, LKML Subject: Re: i2c-CLSA0100:00-cs35l41-hda.1: System Suspend not supported Message-ID: In-Reply-To: References: Feedback-ID: 6286898:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04.01.23 03:18, Bagas Sanjaya wrote: > On Tue, Jan 03, 2023 at 08:45:05PM +0000, Waldek Andrukiewicz wrote: >> Hello, >> >> I am running Manjaro, after upgrading from kernel 6.0.15 to 6.1.1 >> (https://gitlab.manjaro.org/packages/core/linux61) I have noticed that >> suspend stopped working, what I can see in the logs is the following >> issue which IMO points to cs35l41 >> >> Machine: >> =C2=A0 Type: Laptop System: LENOVO product: 82N6 v: Legion 7 16ACHg6 >> >> journalctl output below: >> >> Jan 02 21:52:54 legion16 systemd[1]: Starting System Suspend... >> Jan 02 21:52:54 legion16 wpa_supplicant[1193]: wlp4s0: >> CTRL-EVENT-DSCP-POLICY clear_all >> Jan 02 21:52:54 legion16 systemd-sleep[2912]: Entering sleep state >> 'suspend'... >> Jan 02 21:52:54 legion16 kernel: PM: suspend entry (deep) >> Jan 02 21:52:54 legion16 kernel: Filesystems sync: 0.008 seconds >> Jan 02 21:52:54 legion16 wpa_supplicant[1193]: wlp4s0: >> CTRL-EVENT-DSCP-POLICY clear_all >> Jan 02 21:52:54 legion16 wpa_supplicant[1193]: nl80211: deinit >> ifname=3Dwlp4s0 disabled_11b_rates=3D0 >> Jan 02 21:52:54 legion16 plasmashell[1770]: qml: [DEBUG] - onNewData >> Jan 02 21:52:54 legion16 kernel: Freezing user space processes ... >> (elapsed 0.002 seconds) done. >> Jan 02 21:52:54 legion16 kernel: OOM killer disabled. >> Jan 02 21:52:54 legion16 kernel: Freezing remaining freezable tasks ... >> (elapsed 0.001 seconds) done. >> Jan 02 21:52:54 legion16 kernel: printk: Suspending console(s) (use >> no_console_suspend to debug) >> Jan 02 21:52:54 legion16 kernel: cs35l41-hda >> i2c-CLSA0100:00-cs35l41-hda.1: System Suspend not supported >> Jan 02 21:52:54 legion16 kernel: cs35l41-hda >> i2c-CLSA0100:00-cs35l41-hda.0: System Suspend not supported >> Jan 02 21:52:54 legion16 kernel: cs35l41-hda >> i2c-CLSA0100:00-cs35l41-hda.1: PM: dpm_run_callback(): >> cs35l41_system_suspend+0x0/0xd0 [snd_hda_scodec_cs35l41] returns -22 >> Jan 02 21:52:54 legion16 kernel: cs35l41-hda >> i2c-CLSA0100:00-cs35l41-hda.0: PM: dpm_run_callback(): >> cs35l41_system_suspend+0x0/0xd0 [snd_hda_scodec_cs35l41] returns -22 >> Jan 02 21:52:54 legion16 kernel: cs35l41-hda >> i2c-CLSA0100:00-cs35l41-hda.1: PM: failed to suspend async: error -22 >> Jan 02 21:52:54 legion16 kernel: cs35l41-hda >> i2c-CLSA0100:00-cs35l41-hda.0: PM: failed to suspend async: error -22 >> Jan 02 21:52:54 legion16 kernel: PM: Some devices failed to suspend, or >> early wake event detected >> Jan 02 21:52:54 legion16 kernel: OOM killer enabled. >> Jan 02 21:52:54 legion16 kernel: Restarting tasks ... done. >> Jan 02 21:52:54 legion16 kernel: random: crng reseeded on system resumpt= ion >> Jan 02 21:52:54 legion16 syncthing[1588]: [RBC2R] INFO: Relay listener >> (dynamic+https://relays.syncthing.net/endpoint) shutting down >> Jan 02 21:52:54 legion16 syncthing[1588]: [RBC2R] INFO: >> listenerSupervisor@dynamic+https://relays.syncthing.net/endpoint: >> service dynamic+https://relays.syncthing.net/endpoint failed: could not >> find a connectable relay >> Jan 02 21:52:54 legion16 syncthing[1588]: [RBC2R] INFO: Relay listener >> (dynamic+https://relays.syncthing.net/endpoint) starting >> Jan 02 21:52:54 legion16 syncthing[1588]: [RBC2R] INFO: Relay listener >> (dynamic+https://relays.syncthing.net/endpoint) shutting down >> Jan 02 21:52:54 legion16 syncthing[1588]: [RBC2R] INFO: >> listenerSupervisor@dynamic+https://relays.syncthing.net/endpoint: >> service dynamic+https://relays.syncthing.net/endpoint failed: Get >> "https://relays.syncthing.net/endpoint": dial tcp: lookup >> relays.syncthing.net on [::1]:53: read udp [::1]:58193->[::1]:53: read: >> connection refused >> Jan 02 21:52:54 legion16 syncthing[1588]: [RBC2R] INFO: Relay listener >> (dynamic+https://relays.syncthing.net/endpoint) starting >> Jan 02 21:52:54 legion16 syncthing[1588]: [RBC2R] INFO: Relay listener >> (dynamic+https://relays.syncthing.net/endpoint) shutting down >> Jan 02 21:52:54 legion16 syncthing[1588]: [RBC2R] INFO: >> listenerSupervisor@dynamic+https://relays.syncthing.net/endpoint: >> service dynamic+https://relays.syncthing.net/endpoint failed: Get >> "https://relays.syncthing.net/endpoint": dial tcp: lookup >> relays.syncthing.net on [::1]:53: read udp [::1]:35430->[::1]:53: read: >> connection refused >> Jan 02 21:52:55 legion16 bluetoothd[942]: Controller resume with wake >> event 0x0 >> Jan 02 21:52:55 legion16 kernel: PM: suspend exit >> Jan 02 21:52:55 legion16 kernel: PM: suspend entry (s2idle) >> Jan 02 21:52:55 legion16 kernel: Filesystems sync: 0.004 seconds >> Jan 02 21:52:55 legion16 kernel: Freezing user space processes ... >> (elapsed 0.001 seconds) done. >> Jan 02 21:52:55 legion16 kernel: OOM killer disabled. >> Jan 02 21:52:55 legion16 kernel: Freezing remaining freezable tasks ... >> (elapsed 0.216 seconds) done. >> Jan 02 21:52:55 legion16 kernel: printk: Suspending console(s) (use >> no_console_suspend to debug) >> Jan 02 21:52:55 legion16 kernel: cs35l41-hda >> i2c-CLSA0100:00-cs35l41-hda.1: System Suspend not supported >> Jan 02 21:52:55 legion16 kernel: cs35l41-hda >> i2c-CLSA0100:00-cs35l41-hda.1: PM: dpm_run_callback(): >> cs35l41_system_suspend+0x0/0xd0 [snd_hda_scodec_cs35l41] returns -22 >> Jan 02 21:52:55 legion16 kernel: cs35l41-hda >> i2c-CLSA0100:00-cs35l41-hda.1: PM: failed to suspend async: error -22 >> Jan 02 21:52:55 legion16 kernel: PM: Some devices failed to suspend, or >> early wake event detected >> Jan 02 21:52:55 legion16 kernel: OOM killer enabled. >> Jan 02 21:52:55 legion16 plasmashell[1770]: qml: [DEBUG] - onNewData >> Jan 02 21:52:55 legion16 kernel: Restarting tasks ... done. >> Jan 02 21:52:55 legion16 kernel: random: crng reseeded on system resumpt= ion >> Jan 02 21:52:55 legion16 systemd-sleep[2912]: Failed to put system to >> sleep. System resumed again: Invalid argument >> Jan 02 21:52:55 legion16 kernel: PM: suspend exit >> Jan 02 21:52:55 legion16 bluetoothd[942]: Controller resume with wake >> event 0x0 >> Jan 02 21:52:55 legion16 systemd[1]: systemd-suspend.service: Main >> process exited, code=3Dexited, status=3D1/FAILURE >> Jan 02 21:52:55 legion16 systemd[1]: systemd-suspend.service: Failed >> with result 'exit-code'. >> Jan 02 21:52:55 legion16 systemd[1]: Failed to start System Suspend. >> Jan 02 21:52:55 legion16 systemd[1]: Dependency failed for Suspend. >> >> I have to admit I have not tried 6.1.2 yet but I could not find any >> changes related to this module (opposite to 6.1 where there was quite a >> few including suspend - commit dca45efbe3c870a4ad2107fe625109b3765c0fea)= . >> > Can you please try building mainline (Linus's tree) and boot from it? > If the suspend success in the mainline, can you also bisect to find the > culprit? > > In any case, I'm adding this to regzbot: > > #regzbot ^introduced v6.0..v6.1 > #regzbot title Suspend not supported on Lenovo Legion 7 since v6.1 > > Thanks. > I have received a patch from Takashi Iwai and tested it, it helped, I can suspend my laptop same as I could with kernels prior to 6.1. Thank you.