From: Guenter Roeck <linux@roeck-us.net>
To: Franz Forstmayr <forstmayr.franz@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/3] docs: hwmon: Add support for ina2xx
Date: Tue, 25 Feb 2020 06:49:34 -0800 [thread overview]
Message-ID: <f4142460-ec38-a427-8429-8a4aa660aa8a@roeck-us.net> (raw)
In-Reply-To: <20200224232647.29213-2-forstmayr.franz@gmail.com>
On 2/24/20 3:26 PM, Franz Forstmayr wrote:
> Add documentation for INA260, power/current monitor with I2C interface.
>
Subject should match description here (this patch does not add support
for ina2xx).
> Signed-off-by: Franz Forstmayr <forstmayr.franz@gmail.com>
> ---
> Documentation/hwmon/ina2xx.rst | 19 ++++++++++++++++---
> 1 file changed, 16 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/hwmon/ina2xx.rst b/Documentation/hwmon/ina2xx.rst
> index 94b9a260c518..74267dd433dd 100644
> --- a/Documentation/hwmon/ina2xx.rst
> +++ b/Documentation/hwmon/ina2xx.rst
> @@ -53,6 +53,16 @@ Supported chips:
>
> http://www.ti.com/
>
> + * Texas Instruments INA260
> +
> + Prefix: 'ina260'
> +
> + Addresses: I2C 0x40 - 0x4f
> +
> + Datasheet: Publicly available at the Texas Instruments website
> +
> + http://www.ti.com/
> +
> Author: Lothar Felten <lothar.felten@gmail.com>
>
> Description
> @@ -72,14 +82,17 @@ INA230 and INA231 are high or low side current shunt and power monitors
> with an I2C interface. The chips monitor both a shunt voltage drop and
> bus supply voltage.
>
> +INA260 is a high or low side current and power monitor with an integrated
> +shunt and I2C interface.
> +
> The shunt value in micro-ohms can be set via platform data or device tree at
> compile-time or via the shunt_resistor attribute in sysfs at run-time. Please
> refer to the Documentation/devicetree/bindings/hwmon/ina2xx.txt for bindings
> if the device tree is used.
>
> -Additionally ina226 supports update_interval attribute as described in
> -Documentation/hwmon/sysfs-interface.rst. Internally the interval is the sum of
> -bus and shunt voltage conversion times multiplied by the averaging rate. We
> +Additionally ina226 and ina260 supports update_interval attribute as described
s/supports/support/
> +in Documentation/hwmon/sysfs-interface.rst. Internally the interval is the sum
> +of bus and shunt voltage conversion times multiplied by the averaging rate. We
> don't touch the conversion times and only modify the number of averages. The
> lower limit of the update_interval is 2 ms, the upper limit is 2253 ms.
> The actual programmed interval may vary from the desired value.
>
next prev parent reply other threads:[~2020-02-25 14:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 23:26 [PATCH 1/3] dt-bindings: hwmon: Add compatible for ti,ina260 Franz Forstmayr
2020-02-24 23:26 ` [PATCH 2/3] docs: hwmon: Add support for ina2xx Franz Forstmayr
2020-02-25 14:49 ` Guenter Roeck [this message]
2020-02-24 23:26 ` [PATCH 3/3] hwmon: (ina2xx) Add support for ina260 Franz Forstmayr
2020-02-26 2:16 ` Guenter Roeck
2020-05-19 5:21 ` Michal Simek
2020-05-19 14:14 ` Guenter Roeck
2020-05-19 15:28 ` Michal Simek
2020-03-02 20:50 ` [PATCH 1/3] dt-bindings: hwmon: Add compatible for ti,ina260 Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4142460-ec38-a427-8429-8a4aa660aa8a@roeck-us.net \
--to=linux@roeck-us.net \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=forstmayr.franz@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®