From: Jiri Slaby <jirislaby@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-serial <linux-serial@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v2] serial: Convert serial_rs485 to kernel doc
Date: Tue, 27 Sep 2022 12:58:07 +0200 [thread overview]
Message-ID: <f4143edb-cbc2-8b36-c227-b1ca13f3619b@kernel.org> (raw)
In-Reply-To: <1c401476-8f4d-827c-f8e1-b4853988e2@linux.intel.com>
On 27. 09. 22, 12:47, Ilpo Järvinen wrote:
> --- a/Documentation/driver-api/serial/serial-rs485.rst
> +++ b/Documentation/driver-api/serial/serial-rs485.rst
> @@ -29,11 +29,11 @@ RS485 Serial Communications
> 3. Data Structures Already Available in the Kernel
> ==================================================
>
> - The Linux kernel provides the serial_rs485 structure (see [1]) to handle
> - RS485 communications. This data structure is used to set and configure RS485
> + The Linux kernel provides the serial_rs485 structure to handle RS485
> + communications. This data structure is used to set and configure RS485
> parameters in the platform data and in ioctls.
>
> - The device tree can also provide RS485 boot time parameters (see [2]
> + The device tree can also provide RS485 boot time parameters (see [1]
> for bindings). The driver is in charge of filling this data structure from
> the values given by the device tree.
>
> @@ -47,6 +47,9 @@ RS485 Serial Communications
> for the uart_port. TIOCGRS485 ioctl can be used to read back the
> serial_rs485 structure matching to the current configuration.
>
> +.. kernel-doc:: include/uapi/linux/serial.h
> + :identifiers: serial_rs485
> +
> 4. Usage from user-level
> ========================
>
> @@ -126,6 +129,4 @@ RS485 Serial Communications
> 6. References
> =============
>
> - [1] include/uapi/linux/serial.h
> -
> - [2] Documentation/devicetree/bindings/serial/rs485.txt
> + [1] Documentation/devicetree/bindings/serial/rs485.txt
BTW could that [1] be converted into proper hyperlink too (separately)?
thanks,
--
js
suse labs
prev parent reply other threads:[~2022-09-27 10:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 10:47 Ilpo Järvinen
2022-09-27 10:56 ` Jiri Slaby
2022-09-27 11:07 ` Ilpo Järvinen
2022-09-27 10:58 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4143edb-cbc2-8b36-c227-b1ca13f3619b@kernel.org \
--to=jirislaby@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®